Patchwork libobjc: run testcases with Apple runtime as well

login
register
mail settings
Submitter Nicola Pero
Date Dec. 26, 2010, 10:50 p.m.
Message ID <D32FA102-F9A3-437A-8A22-F2C64F304FFE@meta-innovation.com>
Download mbox | patch
Permalink /patch/76726/
State New
Headers show

Comments

Nicola Pero - Dec. 26, 2010, 10:50 p.m.
Dominique

thanks for the quick feedback :-)

Apologies for the failures - I did test on an Apple m32 but forgot to  
disable the tests on m64 (we still can't compile
Objective-C for m64 on Apple yet, as it requires outputting code for  
the new ABI which we haven't implemented
yet). ;-)

I disabled them in that case.  Can you try updating from subversion  
and running the tests again and confirming it
all looks good now ?

Thanks

PS: Here is the (trivial) change that I applied to disable them on m64  
--

  /* To get the modern GNU Objective-C Runtime API, you include
     objc/runtime.h.  */
Dominique Dhumieres - Dec. 27, 2010, 8:11 a.m.
Nicola,

> I disabled them in that case.  Can you try updating from subversion
> and running the tests again and confirming it
> all looks good now ?

Yes it does. Thanks,

Dominique

Patch

Index: ChangeLog
===================================================================
--- ChangeLog   (revision 168255)
+++ ChangeLog   (working copy)
@@ -1,5 +1,24 @@ 
  2010-12-26  Nicola Pero  <nicola.pero@meta-innovation.com>

+       * objc.dg/gnu-api-2-class.m: Xfail the test on Apple Darwin m64.
+       * objc.dg/gnu-api-2-ivar.m: Same.
+       * objc.dg/gnu-api-2-method.m: Same.
+       * objc.dg/gnu-api-2-objc.m: Same.
+       * objc.dg/gnu-api-2-object.m: Same.
+       * objc.dg/gnu-api-2-protocol.m: Same.
+       * obj-c++.dg/gnu-api-2-class.mm: Same.
+       * obj-c++.dg/gnu-api-2-ivar.mm: Same.
+       * obj-c++.dg/gnu-api-2-method.mm: Same.
+       * obj-c++.dg/gnu-api-2-objc.mm: Same.
+       * obj-c++.dg/gnu-api-2-object.mm: Same.
+       * obj-c++.dg/gnu-api-2-protocol.mm: Same.
+
+2010-12-26  Nicola Pero  <nicola.pero@meta-innovation.com>
+
         * objc.dg/pr44509.m: New.

  2010-12-26  Nicola Pero  <nicola.pero@meta-innovation.com>
Index: objc.dg/gnu-api-2-ivar.m
===================================================================
--- objc.dg/gnu-api-2-ivar.m    (revision 168255)
+++ objc.dg/gnu-api-2-ivar.m    (working copy)
@@ -3,6 +3,7 @@ 
    This is test 'ivar', covering all functions starting with 'ivar'.   
*/

  /* { dg-do run } */
+/* { dg-xfail-run-if "Needs OBJC2 ABI" { *-*-darwin* && { lp64 && { !  
objc2 } } } { "-fnext-runtime" } { "" } } */

  /* To get the modern GNU Objective-C Runtime API, you include
     objc/runtime.h.  */
Index: objc.dg/gnu-api-2-object.m
===================================================================
--- objc.dg/gnu-api-2-object.m  (revision 168255)
+++ objc.dg/gnu-api-2-object.m  (working copy)
@@ -3,6 +3,7 @@ 
    This is test 'object', covering all functions starting with  
'object'.  */

  /* { dg-do run } */
+/* { dg-xfail-run-if "Needs OBJC2 ABI" { *-*-darwin* && { lp64 && { !  
objc2 } } } { "-fnext-runtime" } { "" } } */

  /* To get the modern GNU Objective-C Runtime API, you include
     objc/runtime.h.  */
Index: objc.dg/gnu-api-2-objc.m
===================================================================
--- objc.dg/gnu-api-2-objc.m    (revision 168255)
+++ objc.dg/gnu-api-2-objc.m    (working copy)
@@ -3,6 +3,7 @@ 
    This is test 'objc', covering all functions starting with 'objc'.   
*/

  /* { dg-do run } */
+/* { dg-xfail-run-if "Needs OBJC2 ABI" { *-*-darwin* && { lp64 && { !  
objc2 } } } { "-fnext-runtime" } { "" } } */

  /* To get the modern GNU Objective-C Runtime API, you include
     objc/runtime.h.  */
Index: objc.dg/gnu-api-2-protocol.m
===================================================================
--- objc.dg/gnu-api-2-protocol.m        (revision 168255)
+++ objc.dg/gnu-api-2-protocol.m        (working copy)
@@ -3,6 +3,7 @@ 
    This is test 'protocol', covering all functions starting with  
'protocol'.  */

  /* { dg-do run } */
+/* { dg-xfail-run-if "Needs OBJC2 ABI" { *-*-darwin* && { lp64 && { !  
objc2 } } } { "-fnext-runtime" } { "" } } */

  /* To get the modern GNU Objective-C Runtime API, you include
     objc/runtime.h.  */
Index: objc.dg/gnu-api-2-class.m
===================================================================
--- objc.dg/gnu-api-2-class.m   (revision 168255)
+++ objc.dg/gnu-api-2-class.m   (working copy)
@@ -3,6 +3,7 @@ 
    This is test 'class', covering all functions starting with  
'class'.  */

  /* { dg-do run } */
+/* { dg-xfail-run-if "Needs OBJC2 ABI" { *-*-darwin* && { lp64 && { !  
objc2 } } } { "-fnext-runtime" } { "" } } */

  /* To get the modern GNU Objective-C Runtime API, you include
     objc/runtime.h.  */
Index: objc.dg/gnu-api-2-method.m
===================================================================
--- objc.dg/gnu-api-2-method.m  (revision 168255)
+++ objc.dg/gnu-api-2-method.m  (working copy)
@@ -3,6 +3,7 @@ 
    This is test 'method', covering all functions starting with  
'method'.  */

  /* { dg-do run } */
+/* { dg-xfail-run-if "Needs OBJC2 ABI" { *-*-darwin* && { lp64 && { !  
objc2 } } } { "-fnext-runtime" } { "" } } */

  /* To get the modern GNU Objective-C Runtime API, you include
     objc/runtime.h.  */
Index: obj-c++.dg/gnu-api-2-protocol.mm
===================================================================
--- obj-c++.dg/gnu-api-2-protocol.mm    (revision 168255)
+++ obj-c++.dg/gnu-api-2-protocol.mm    (working copy)
@@ -3,6 +3,7 @@ 
    This is test 'protocol', covering all functions starting with  
'protocol'.  */

  /* { dg-do run } */
+/* { dg-xfail-run-if "Needs OBJC2 ABI" { *-*-darwin* && { lp64 && { !  
objc2 } } } { "-fnext-runtime" } { "" } } */

  /* To get the modern GNU Objective-C Runtime API, you include
     objc/runtime.h.  */
Index: obj-c++.dg/gnu-api-2-object.mm
===================================================================
--- obj-c++.dg/gnu-api-2-object.mm      (revision 168255)
+++ obj-c++.dg/gnu-api-2-object.mm      (working copy)
@@ -3,6 +3,7 @@ 
    This is test 'object', covering all functions starting with  
'object'.  */

  /* { dg-do run } */
+/* { dg-xfail-run-if "Needs OBJC2 ABI" { *-*-darwin* && { lp64 && { !  
objc2 } } } { "-fnext-runtime" } { "" } } */

  /* To get the modern GNU Objective-C Runtime API, you include
     objc/runtime.h.  */
Index: obj-c++.dg/gnu-api-2-method.mm
===================================================================
--- obj-c++.dg/gnu-api-2-method.mm      (revision 168255)
+++ obj-c++.dg/gnu-api-2-method.mm      (working copy)
@@ -3,6 +3,7 @@ 
    This is test 'method', covering all functions starting with  
'method'.  */

  /* { dg-do run } */
+/* { dg-xfail-run-if "Needs OBJC2 ABI" { *-*-darwin* && { lp64 && { !  
objc2 } } } { "-fnext-runtime" } { "" } } */

  /* To get the modern GNU Objective-C Runtime API, you include
     objc/runtime.h.  */
Index: obj-c++.dg/gnu-api-2-objc.mm
===================================================================
--- obj-c++.dg/gnu-api-2-objc.mm        (revision 168255)
+++ obj-c++.dg/gnu-api-2-objc.mm        (working copy)
@@ -3,6 +3,7 @@ 
    This is test 'objc', covering all functions starting with 'objc'.   
*/

  /* { dg-do run } */
+/* { dg-xfail-run-if "Needs OBJC2 ABI" { *-*-darwin* && { lp64 && { !  
objc2 } } } { "-fnext-runtime" } { "" } } */

  /* To get the modern GNU Objective-C Runtime API, you include
     objc/runtime.h.  */
Index: obj-c++.dg/gnu-api-2-ivar.mm
===================================================================
--- obj-c++.dg/gnu-api-2-ivar.mm        (revision 168255)
+++ obj-c++.dg/gnu-api-2-ivar.mm        (working copy)
@@ -3,6 +3,7 @@ 
    This is test 'ivar', covering all functions starting with 'ivar'.   
*/

  /* { dg-do run } */
+/* { dg-xfail-run-if "Needs OBJC2 ABI" { *-*-darwin* && { lp64 && { !  
objc2 } } } { "-fnext-runtime" } { "" } } */

  /* To get the modern GNU Objective-C Runtime API, you include
     objc/runtime.h.  */
Index: obj-c++.dg/gnu-api-2-class.mm
===================================================================
--- obj-c++.dg/gnu-api-2-class.mm       (revision 168255)
+++ obj-c++.dg/gnu-api-2-class.mm       (working copy)
@@ -3,6 +3,7 @@ 
    This is test 'class', covering all functions starting with  
'class'.  */

  /* { dg-do run } */
+/* { dg-xfail-run-if "Needs OBJC2 ABI" { *-*-darwin* && { lp64 && { !  
objc2 } } } { "-fnext-runtime" } { "" } } */