Patchwork [U-Boot] Change the chip name to fit the eth_device struct

login
register
mail settings
Submitter Yanjun Yang
Date Dec. 26, 2010, 2:40 a.m.
Message ID <AANLkTikeX3K2sKs9fN92gn52DKGLUdzvxYxPJozx+hr+@mail.gmail.com>
Download mbox | patch
Permalink /patch/76712/
State Accepted
Headers show

Comments

Yanjun Yang - Dec. 26, 2010, 2:40 a.m.
The eth_device.name field length is limited by NAMESIZE,
which is 16 defined in include/net.h. Unfortunately, two
of the names in lan91c96.c are beyond that.

Signed-off-by: YanJun Yang <yangyj.ee@gmail.com>
---
 drivers/net/lan91c96.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

--
1.5.6.5
Wolfgang Denk - Jan. 10, 2011, 9:39 p.m.
Dear Yanjun Yang,

In message <AANLkTikeX3K2sKs9fN92gn52DKGLUdzvxYxPJozx+hr+@mail.gmail.com> you wrote:
> The eth_device.name field length is limited by NAMESIZE,
> which is 16 defined in include/net.h. Unfortunately, two
> of the names in lan91c96.c are beyond that.
> 
> Signed-off-by: YanJun Yang <yangyj.ee@gmail.com>
> ---
>  drivers/net/lan91c96.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/lan91c96.c b/drivers/net/lan91c96.c
> index 810079f..bd6966e 100644
> --- a/drivers/net/lan91c96.c
> +++ b/drivers/net/lan91c96.c
> @@ -767,8 +767,8 @@ static struct id_type supported_chips[] = {
>        {8, "LAN91C100FD"},
>        {7, "LAN91C100"},
>        {5, "LAN91C95"},
> -       {4, "LAN91C94/LAN91C96"},
> -       {3, "LAN91C90/LAN91C92"},
> +       {4, "LAN91C94/96"},
> +       {3, "LAN91C90/92"},

Your patch is white space corrupted, applied manually.

Please use git-send-email next time.

Best regards,

Wolfgang Denk

Patch

diff --git a/drivers/net/lan91c96.c b/drivers/net/lan91c96.c
index 810079f..bd6966e 100644
--- a/drivers/net/lan91c96.c
+++ b/drivers/net/lan91c96.c
@@ -767,8 +767,8 @@  static struct id_type supported_chips[] = {
       {8, "LAN91C100FD"},
       {7, "LAN91C100"},
       {5, "LAN91C95"},
-       {4, "LAN91C94/LAN91C96"},
-       {3, "LAN91C90/LAN91C92"},
+       {4, "LAN91C94/96"},
+       {3, "LAN91C90/92"},
 };
 /* lan91c96_detect_chip
 * See: