| Message ID | f7t7f14vlgc.fsf@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
On Thu, May 25, 2017 at 02:29:55PM -0400, Aaron Conole wrote: > Hi Ben, > > Ben Pfaff <blp@ovn.org> writes: > > > Until now, most ovs-ofctl commands have not accepted names for ports, only > > numbers, and have not been able to display port names either. It's a lot > > easier for users if they can use and see meaningful names instead of > > arbitrary numbers. This commit adds that support. > > > > For backward compatibility, only interactive ovs-ofctl commands by default > > display port names; to display them in scripts, use the new --names > > option. > > > > Signed-off-by: Ben Pfaff <blp@ovn.org> > > --- > > Tested-by: Aaron Conole <aconole@redhat.com> > > I suggest folding in the following (otherwise, I'm happy with it): Thanks a lot for reviewing and testing! Since this is a big change, I'm going to leave this out for comments from others for a while before I consider pushing it.
On Thu, May 25, 2017 at 02:41:04PM -0700, Ben Pfaff wrote: > On Thu, May 25, 2017 at 02:29:55PM -0400, Aaron Conole wrote: > > Hi Ben, > > > > Ben Pfaff <blp@ovn.org> writes: > > > > > Until now, most ovs-ofctl commands have not accepted names for ports, only > > > numbers, and have not been able to display port names either. It's a lot > > > easier for users if they can use and see meaningful names instead of > > > arbitrary numbers. This commit adds that support. > > > > > > For backward compatibility, only interactive ovs-ofctl commands by default > > > display port names; to display them in scripts, use the new --names > > > option. > > > > > > Signed-off-by: Ben Pfaff <blp@ovn.org> > > > --- > > > > Tested-by: Aaron Conole <aconole@redhat.com> > > > > I suggest folding in the following (otherwise, I'm happy with it): > > Thanks a lot for reviewing and testing! > > Since this is a big change, I'm going to leave this out for comments > from others for a while before I consider pushing it. No one else had comments, so I applied this. Thanks again!
diff --git a/lib/dpctl.c b/lib/dpctl.c index 1ebf5da..7f87603 100644 --- a/lib/dpctl.c +++ b/lib/dpctl.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2008, 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016, 2017 Nicira, Inc. + * Copyright (c) 2008-2017 Nicira, Inc. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License.