From patchwork Sat Dec 25 22:16:11 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Rosenberg X-Patchwork-Id: 76703 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id EA022B70EC for ; Sun, 26 Dec 2010 09:16:44 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751646Ab0LYWQi (ORCPT ); Sat, 25 Dec 2010 17:16:38 -0500 Received: from mx1.vsecurity.com ([209.67.252.12]:50366 "EHLO mx1.vsecurity.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751049Ab0LYWQi (ORCPT ); Sat, 25 Dec 2010 17:16:38 -0500 Received: (qmail 41430 invoked from network); 25 Dec 2010 22:16:35 -0000 Received: from c-98-229-66-118.hsd1.ma.comcast.net (HELO [192.168.1.109]) (drosenbe@[98.229.66.118]) (envelope-sender ) by mx1.vsecurity.com (qmail-ldap-1.03) with SMTP for ; 25 Dec 2010 22:16:35 -0000 Subject: [PATCH] CAN: Use inode instead of kernel address for /proc file From: Dan Rosenberg To: Oliver Hartkopp , Urs Thuermann , "David S. Miller" Cc: netdev@vger.kernel.org, security@kernel.org Date: Sat, 25 Dec 2010 17:16:11 -0500 Message-ID: <1293315371.9764.44.camel@Dan> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Since the socket address is just being used as a unique identifier, its inode number is an alternative that does not leak potentially sensitive information. CC-ing stable because MITRE has assigned CVE-2010-4565 to the issue. Signed-off-by: Dan Rosenberg Cc: stable Acked-by: Oliver Hartkopp --- net/can/bcm.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/can/bcm.c b/net/can/bcm.c index 6faa825..5748901 100644 --- a/net/can/bcm.c +++ b/net/can/bcm.c @@ -1520,8 +1520,8 @@ static int bcm_connect(struct socket *sock, struct sockaddr *uaddr, int len, bo->bound = 1; if (proc_dir) { - /* unique socket address as filename */ - sprintf(bo->procname, "%p", sock); + /* socket inode as filename */ + sprintf(bo->procname, "%lx", sock_i_ino(sk)); bo->bcm_proc_read = proc_create_data(bo->procname, 0644, proc_dir, &bcm_proc_fops, sk);