From patchwork Sat Dec 25 20:30:08 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesper Juhl X-Patchwork-Id: 76700 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id ECB36B70EA for ; Sun, 26 Dec 2010 07:40:20 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752547Ab0LYUj4 (ORCPT ); Sat, 25 Dec 2010 15:39:56 -0500 Received: from swampdragon.chaosbits.net ([90.184.90.115]:16177 "EHLO swampdragon.chaosbits.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752521Ab0LYUjx (ORCPT ); Sat, 25 Dec 2010 15:39:53 -0500 Received: by swampdragon.chaosbits.net (Postfix, from userid 1000) id AB41D9403F; Sat, 25 Dec 2010 21:30:08 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by swampdragon.chaosbits.net (Postfix) with ESMTP id A38DC9403B; Sat, 25 Dec 2010 21:30:08 +0100 (CET) Date: Sat, 25 Dec 2010 21:30:08 +0100 (CET) From: Jesper Juhl To: netdev@vger.kernel.org cc: vortex@scyld.com, becker@scyld.com, Steffen Klassert , linux-kernel@vger.kernel.org Subject: [PATCH] 3c59x: Don't assign when a comparison is intended Message-ID: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, In drivers/net/3c59x.c::vortex_probe1() we have this code: if (gendev) { if ((pdev = DEVICE_PCI(gendev))) { print_name = pci_name(pdev); } if ((edev = DEVICE_EISA(gendev))) { print_name = dev_name(&edev->dev); } } I believe these assignments were intended to be comparisons. If I'm correct, then here's a patch to fix that up. Signed-off-by: Jesper Juhl --- 3c59x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/3c59x.c b/drivers/net/3c59x.c index 0a92436f..db8a80e 100644 --- a/drivers/net/3c59x.c +++ b/drivers/net/3c59x.c @@ -1110,11 +1110,11 @@ static int __devinit vortex_probe1(struct device *gendev, } if (gendev) { - if ((pdev = DEVICE_PCI(gendev))) { + if ((pdev == DEVICE_PCI(gendev))) { print_name = pci_name(pdev); } - if ((edev = DEVICE_EISA(gendev))) { + if ((edev == DEVICE_EISA(gendev))) { print_name = dev_name(&edev->dev); } }