| Message ID | 20170524234916.16181-5-chris.packham@alliedtelesis.co.nz |
|---|---|
| State | Superseded |
| Delegated to: | Brian Norris |
| Headers | show |
On Thu, 25 May 2017 11:49:15 +1200 Chris Packham <chris.packham@alliedtelesis.co.nz> wrote: > Setting the of_node for the mtd device allows the generic mtd code to > setup the partitions. Additionally we must specify a non-zero erasesize > for the partitions to be writeable. > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > Tested-by: Andrew Lunn <andrew@lunn.ch> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com> > --- > Changes in v2 > - collect revew/test from Andrew > Changes in v3: > - remove setting of erasesize > Changes in v4: > - none > > drivers/mtd/devices/mchp23k256.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/devices/mchp23k256.c b/drivers/mtd/devices/mchp23k256.c > index 2542f5b8b63f..3e5feb454644 100644 > --- a/drivers/mtd/devices/mchp23k256.c > +++ b/drivers/mtd/devices/mchp23k256.c > @@ -143,6 +143,7 @@ static int mchp23k256_probe(struct spi_device *spi) > > data = dev_get_platdata(&spi->dev); > > + mtd_set_of_node(&flash->mtd, spi->dev.of_node); > flash->mtd.dev.parent = &spi->dev; > flash->mtd.type = MTD_RAM; > flash->mtd.flags = MTD_CAP_RAM;
On Thu, May 25, 2017 at 11:49:15AM +1200, Chris Packham wrote: > Setting the of_node for the mtd device allows the generic mtd code to > setup the partitions. Additionally we must specify a non-zero erasesize > for the partitions to be writeable. The last sentence here is no longer applicable.
diff --git a/drivers/mtd/devices/mchp23k256.c b/drivers/mtd/devices/mchp23k256.c index 2542f5b8b63f..3e5feb454644 100644 --- a/drivers/mtd/devices/mchp23k256.c +++ b/drivers/mtd/devices/mchp23k256.c @@ -143,6 +143,7 @@ static int mchp23k256_probe(struct spi_device *spi) data = dev_get_platdata(&spi->dev); + mtd_set_of_node(&flash->mtd, spi->dev.of_node); flash->mtd.dev.parent = &spi->dev; flash->mtd.type = MTD_RAM; flash->mtd.flags = MTD_CAP_RAM;