From patchwork Sat Dec 25 12:10:44 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jarek Poplawski X-Patchwork-Id: 76668 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 52FE7B6EEB for ; Sat, 25 Dec 2010 23:11:37 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751550Ab0LYMKy (ORCPT ); Sat, 25 Dec 2010 07:10:54 -0500 Received: from mail-bw0-f46.google.com ([209.85.214.46]:63740 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751101Ab0LYMKw (ORCPT ); Sat, 25 Dec 2010 07:10:52 -0500 Received: by bwz15 with SMTP id 15so8693415bwz.19 for ; Sat, 25 Dec 2010 04:10:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=jVKqxgpk+Rtl14cTm3/LoK1qJ6fmAM+5hNKw2BZArgw=; b=mrWnufbo/I84sSkzh3LxA2tj4EmHWqAttK+JSa27JysPIZoEglwKUWPWrcYAoALngo qNIwQEM+q0olSzIAv/9gEpMn6AvndpP0nli9G4WkYb7C6QgBLGs85OlpPh907M/0vAm1 PH8C5gKXHQPUOFVN7igfYYkPAkETtaGGMt79A= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=LJqfpmSNZfOxLSI6K/gLj1majZ8fPE04vMCvWbBz1rd6dYG/Qyz8TA41MdkB0OzFu0 x/31s73QgnKoygTi/eZALIBV0tV52SXRvY2TplPPliSZhW3YD3XSHPFqvEysDRXOsxpA SxtgLFx8Os3WGYd/CuQggcKlW6zXZgVBe6sqk= Received: by 10.204.98.12 with SMTP id o12mr8987841bkn.32.1293279050280; Sat, 25 Dec 2010 04:10:50 -0800 (PST) Received: from del.dom.local (public79653.xdsl.centertel.pl [79.162.183.37]) by mx.google.com with ESMTPS id q18sm6562961bka.3.2010.12.25.04.10.47 (version=SSLv3 cipher=RC4-MD5); Sat, 25 Dec 2010 04:10:48 -0800 (PST) Date: Sat, 25 Dec 2010 13:10:44 +0100 From: Jarek Poplawski To: Joel Soete Cc: Eric Dumazet , Andrew Morton , Linux Kernel , netdev@vger.kernel.org Subject: Re: Help: major pppoe regression since 2.6.35 (panic on first ppp conection)? Message-ID: <20101225121044.GA1841@del.dom.local> References: <20101222110021.GA8985@ff.dom.local> <4D122093.6060900@scarlet.be> <1293035100.3027.247.camel@edumazet-laptop> <4D132C5F.8090404@scarlet.be> <1293106348.7789.5.camel@edumazet-laptop> <20101223202523.GA1913@del.dom.local> <4D148271.8030509@scarlet.be> <20101224151325.GA1895@del.dom.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20101224151325.GA1895@del.dom.local> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Dec 24, 2010 at 04:13:25PM +0100, Jarek Poplawski wrote: > On Fri, Dec 24, 2010 at 11:22:25AM +0000, Joel Soete wrote: > > Hello Jarek, > Hi Joel, > > > Ok I get a clean 2.6.37-rc7 vanilla src and apply your debugging > > patch and grab the attached syslog-2.6.37-rc7-t2.gz with obviously a > > lot of "warning" (but as well as with Eric's patch, kernel survived > > to a lynx connection to ftp.eu.kernel.org to download of a snapshot > > patch ;<) ) > > Yes, even more than I expected... I hope the list will forgive us ;-) Alas the list rejected your message (try to limit it to ~200kb next time). Anyway, it looks like the sundance driver is the main guilty. The patch below removes one obvious bug but there could be something more. Please, apply this one and my previous debugging patch to the clean 2.6.37-rc7. (If there're still warnings the first ~20kb should do.) Thanks, Jarek P. --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/sundance.c b/drivers/net/sundance.c index 3ed2a67..b409d7e 100644 --- a/drivers/net/sundance.c +++ b/drivers/net/sundance.c @@ -1016,7 +1016,7 @@ static void init_ring(struct net_device *dev) /* Fill in the Rx buffers. Handle allocation failure gracefully. */ for (i = 0; i < RX_RING_SIZE; i++) { - struct sk_buff *skb = dev_alloc_skb(np->rx_buf_sz); + struct sk_buff *skb = dev_alloc_skb(np->rx_buf_sz + 2); np->rx_skbuff[i] = skb; if (skb == NULL) break; @@ -1407,7 +1407,7 @@ static void refill_rx (struct net_device *dev) struct sk_buff *skb; entry = np->dirty_rx % RX_RING_SIZE; if (np->rx_skbuff[entry] == NULL) { - skb = dev_alloc_skb(np->rx_buf_sz); + skb = dev_alloc_skb(np->rx_buf_sz + 2); np->rx_skbuff[entry] = skb; if (skb == NULL) break; /* Better luck next round. */