Patchwork Remove unused REG_VALUE_PROFILE reg note

login
register
mail settings
Submitter Steven Bosscher
Date Dec. 24, 2010, 9:17 p.m.
Message ID <AANLkTikpT107NQ-0WON6rXOjo1GsxHkLisyn_Ny3U6jv@mail.gmail.com>
Download mbox | patch
Permalink /patch/76638/
State New
Headers show

Comments

Steven Bosscher - Dec. 24, 2010, 9:17 p.m.
Hello,

Just remove an unused REG_NOTE. Hasn't been used in years...
Bootstrapped on ia64-unknown-linux-gnu. OK for trunk?

Merry Christmas!

Ciao!
Steven


	* doc/invoke.texi: Remove reference to compiler internals from
	user documentation.

	* reg-notes.def: Remove REG_VALUE_PROFILE.
	* combine.c (distribute_notes): Do not handle REG_VALUE_PROFILE.
Richard Guenther - Dec. 26, 2010, 10:15 p.m.
On Fri, Dec 24, 2010 at 10:17 PM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
> Hello,
>
> Just remove an unused REG_NOTE. Hasn't been used in years...
> Bootstrapped on ia64-unknown-linux-gnu. OK for trunk?

Ok!

Thanks,
Richard.

> Merry Christmas!
>
> Ciao!
> Steven
>
>
>        * doc/invoke.texi: Remove reference to compiler internals from
>        user documentation.
>
>        * reg-notes.def: Remove REG_VALUE_PROFILE.
>        * combine.c (distribute_notes): Do not handle REG_VALUE_PROFILE.
>
> Index: doc/invoke.texi
> ===================================================================
> --- doc/invoke.texi     (revision 168231)
> +++ doc/invoke.texi     (working copy)
> @@ -7992,8 +7992,7 @@ If combined with @option{-fprofile-arcs}
>  data about values of expressions in the program is gathered.
>
>  With @option{-fbranch-probabilities}, it reads back the data gathered
> -from profiling values of expressions and adds @samp{REG_VALUE_PROFILE}
> -notes to instructions for their later usage in optimizations.
> +from profiling values of expressions for usage in optimizations.
>
>  Enabled with @option{-fprofile-generate} and @option{-fprofile-use}.
>
> Index: combine.c
> ===================================================================
> --- combine.c   (revision 168231)
> +++ combine.c   (working copy)
> @@ -13133,10 +13133,6 @@ distribute_notes (rtx notes, rtx from_in
>          place = i3;
>          break;
>
> -       case REG_VALUE_PROFILE:
> -         /* Just get rid of this note, as it is unused later anyway.  */
> -         break;
> -
>        case REG_NON_LOCAL_GOTO:
>          if (JUMP_P (i3))
>            place = i3;
> Index: reg-notes.def
> ===================================================================
> --- reg-notes.def       (revision 168231)
> +++ reg-notes.def       (working copy)
> @@ -99,11 +99,6 @@ REG_NOTE (DEP_ANTI)
>    won't return.  */
>  REG_NOTE (BR_PROB)
>
> -/* REG_VALUE_PROFILE is attached when the profile is read in to an
> -   insn before that the code to profile the value is inserted.  It
> -   contains the results of profiling.  */
> -REG_NOTE (VALUE_PROFILE)
> -
>  /* Attached to a call insn; indicates that the call is malloc-like and
>    that the pointer returned cannot alias anything else.  */
>  REG_NOTE (NOALIAS)
>

Patch

Index: doc/invoke.texi
===================================================================
--- doc/invoke.texi	(revision 168231)
+++ doc/invoke.texi	(working copy)
@@ -7992,8 +7992,7 @@  If combined with @option{-fprofile-arcs}
 data about values of expressions in the program is gathered.

 With @option{-fbranch-probabilities}, it reads back the data gathered
-from profiling values of expressions and adds @samp{REG_VALUE_PROFILE}
-notes to instructions for their later usage in optimizations.
+from profiling values of expressions for usage in optimizations.

 Enabled with @option{-fprofile-generate} and @option{-fprofile-use}.

Index: combine.c
===================================================================
--- combine.c	(revision 168231)
+++ combine.c	(working copy)
@@ -13133,10 +13133,6 @@  distribute_notes (rtx notes, rtx from_in
 	  place = i3;
 	  break;

-	case REG_VALUE_PROFILE:
-	  /* Just get rid of this note, as it is unused later anyway.  */
-	  break;
-
 	case REG_NON_LOCAL_GOTO:
 	  if (JUMP_P (i3))
 	    place = i3;
Index: reg-notes.def
===================================================================
--- reg-notes.def	(revision 168231)
+++ reg-notes.def	(working copy)
@@ -99,11 +99,6 @@  REG_NOTE (DEP_ANTI)
    won't return.  */
 REG_NOTE (BR_PROB)

-/* REG_VALUE_PROFILE is attached when the profile is read in to an
-   insn before that the code to profile the value is inserted.  It
-   contains the results of profiling.  */
-REG_NOTE (VALUE_PROFILE)
-
 /* Attached to a call insn; indicates that the call is malloc-like and
    that the pointer returned cannot alias anything else.  */
 REG_NOTE (NOALIAS)