| Message ID | 20170523210530.30688-1-jernej.skrabec@siol.net |
|---|---|
| State | Accepted |
| Commit | bdc906dba9309f919db79377f024fdd93acff60b |
| Delegated to: | Anatolij Gustschin |
| Headers | show |
On Tue, May 23, 2017 at 11:05:30PM +0200, Jernej Skrabec wrote: > This commit fixes the warning produced by gcc 7.1. > > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> Reviewed-by: Tom Rini <trini@konsulko.com> And I'm curious, where is your gcc-7.1 toolchain from, self built or something else? Thanks!
Hi, Dne sreda, 24. maj 2017 ob 03:00:16 CEST je Tom Rini napisal(a): > On Tue, May 23, 2017 at 11:05:30PM +0200, Jernej Skrabec wrote: > > This commit fixes the warning produced by gcc 7.1. > > > > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> > > Reviewed-by: Tom Rini <trini@konsulko.com> > > And I'm curious, where is your gcc-7.1 toolchain from, self built or > something else? Thanks! It's from Arch Linux repository. I'm sorry to say that there seems to be something wrong with either gcc 7.1 or bootp code. With OrangePi 2 board, bootp crashes and resets the board (ethernet cable is not connected). I didn't have time to investigate it further. Best regards, Jernej
On Wed, May 24, 2017 at 5:35 AM, Jernej Škrabec <jernej.skrabec@siol.net> wrote: > Hi, > > Dne sreda, 24. maj 2017 ob 03:00:16 CEST je Tom Rini napisal(a): >> On Tue, May 23, 2017 at 11:05:30PM +0200, Jernej Skrabec wrote: >> > This commit fixes the warning produced by gcc 7.1. >> > >> > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> >> >> Reviewed-by: Tom Rini <trini@konsulko.com> >> >> And I'm curious, where is your gcc-7.1 toolchain from, self built or >> something else? Thanks! > > It's from Arch Linux repository. > > I'm sorry to say that there seems to be something wrong with either gcc 7.1 or > bootp code. With OrangePi 2 board, bootp crashes and resets the board > (ethernet cable is not connected). I didn't have time to investigate it > further. I think we might have seen something similar with Fedora and gcc-7, I'll ask some of the QA people and see if they can provide any more details. Peter
On 23 May 2017 at 15:05, Jernej Skrabec <jernej.skrabec@siol.net> wrote: > This commit fixes the warning produced by gcc 7.1. > > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> > --- > > common/edid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org>
On Tue, 23 May 2017 23:05:30 +0200 Jernej Skrabec jernej.skrabec@siol.net wrote: > This commit fixes the warning produced by gcc 7.1. > > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> > --- > > common/edid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied to u-boot-video/master, thanks! -- Anatolij
diff --git a/common/edid.c b/common/edid.c index 19410aa4fc..854d40c8f8 100644 --- a/common/edid.c +++ b/common/edid.c @@ -295,7 +295,7 @@ static void edid_print_dtd(struct edid_monitor_descriptor *monitor, h_total = h_active + h_blanking; v_total = v_active + v_blanking; - if (v_total * h_total) + if (v_total > 0 && h_total > 0) vfreq = pixclock / (v_total * h_total); else vfreq = 1; /* Error case */
This commit fixes the warning produced by gcc 7.1. Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> --- common/edid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)