| Message ID | 1495550852-3672-1-git-send-email-ckeepax@opensource.wolfsonmicro.com |
|---|---|
| State | New |
| Headers | show |
On Tuesday 23 May 2017 08:17 PM, Charles Keepax wrote: > Commit 4c0facddb7d8 ("gpio: core: Decouple open drain/source flag with > active low/high") decoupled the open collector outputs from active > low/high but did not update the documentation. > > Update the device tree documentation to correctly reflect this new > separation between the two concepts. > > Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> > --- Acked-by: Laxman Dewangan <ldewangan@nvidia.com> Thanks, Laxman ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ----------------------------------------------------------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, May 23, 2017 at 4:47 PM, Charles Keepax <ckeepax@opensource.wolfsonmicro.com> wrote: > Commit 4c0facddb7d8 ("gpio: core: Decouple open drain/source flag with > active low/high") decoupled the open collector outputs from active > low/high but did not update the documentation. > > Update the device tree documentation to correctly reflect this new > separation between the two concepts. > > Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> Awesome, patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/gpio/gpio.txt b/Documentation/devicetree/bindings/gpio/gpio.txt index 2209c16..bccb8623 100644 --- a/Documentation/devicetree/bindings/gpio/gpio.txt +++ b/Documentation/devicetree/bindings/gpio/gpio.txt @@ -74,11 +74,12 @@ GPIO pin number, and GPIO flags as accepted by the "qe_pio_e" gpio-controller. Optional standard bitfield specifiers for the last cell: - Bit 0: 0 means active high, 1 means active low -- Bit 1: 1 means single-ended wiring, see: +- Bit 1: 0 mean push-pull wiring, see: + https://en.wikipedia.org/wiki/Push-pull_output + 1 means single-ended wiring, see: https://en.wikipedia.org/wiki/Single-ended_triode - When used with active-low, this means open drain/collector, see: +- Bit 2: 0 means open-source, 1 means open drain, see: https://en.wikipedia.org/wiki/Open_collector - When used with active-high, this means open source/emitter 1.1) GPIO specifier best practices ----------------------------------
Commit 4c0facddb7d8 ("gpio: core: Decouple open drain/source flag with active low/high") decoupled the open collector outputs from active low/high but did not update the documentation. Update the device tree documentation to correctly reflect this new separation between the two concepts. Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> --- New to the series. Thanks, Charles Documentation/devicetree/bindings/gpio/gpio.txt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)