diff mbox

[PULL,2/9] net/dump: Issue a warning for the deprecated "-net dump"

Message ID 1495507439-1784-3-git-send-email-jasowang@redhat.com
State New
Headers show

Commit Message

Jason Wang May 23, 2017, 2:43 a.m. UTC 
From: Thomas Huth <thuth@redhat.com>

Network dumping should be done with "-object filter-dump" nowadays.
Using "-net dump" via the VLAN mechanism is considered as deprecated
and might be removed in a future release. So warn the users now
to inform them to user the filter-dump method instead.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 net/dump.c | 3 +++
 1 file changed, 3 insertions(+)
diff mbox

Patch

diff --git a/net/dump.c b/net/dump.c
index 89a149b..442eb53 100644
--- a/net/dump.c
+++ b/net/dump.c
@@ -194,6 +194,9 @@  int net_init_dump(const Netdev *netdev, const char *name,
 
     assert(peer);
 
+    error_report("'-net dump' is deprecated. "
+                 "Please use '-object filter-dump' instead.");
+
     if (dump->has_file) {
         file = dump->file;
     } else {