diff mbox

toolchain: disable PIE for static build with musl

Message ID e5ceac77a5ace9cfb989319cb33261d32885bd04.1495490829.git.baruch@tkos.co.il
State Accepted
Headers show

Commit Message

Baruch Siach May 22, 2017, 10:07 p.m. UTC 
As mentioned in commit 3c93901bcd2 (toolchain: add hidden symbol for PIE
support), support for static PIE using musl requires a gcc patch[1]. Buildroot
doesn't carry this patch. Don't enable BR2_TOOLCHAIN_SUPPORTS_PIE in static
build with musl.

Fixes:
http://autobuild.buildroot.net/results/d19/d19bcfcfb33cc5f5b082b97bbd5852d479823b97/
http://autobuild.buildroot.net/results/91f/91f7c6954c337b03f5ac141050d9b1bee1623376/
http://autobuild.buildroot.net/results/996/996116da9241686110b9525eed08cc5acfd379a6/

[1] https://github.com/richfelker/musl-cross-make/blob/b854a42fc1ea19b8c4ec7104848f9d1a6d7995f0/patches/gcc-6.3.0/0010-static-pie-support.diff

Acked-by: Waldemar Brodkorb <wbx@openadk.org>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 toolchain/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Petazzoni May 23, 2017, 1:37 p.m. UTC | #1 
Hello,

On Tue, 23 May 2017 01:07:09 +0300, Baruch Siach wrote:
> As mentioned in commit 3c93901bcd2 (toolchain: add hidden symbol for PIE
> support), support for static PIE using musl requires a gcc patch[1]. Buildroot
> doesn't carry this patch. Don't enable BR2_TOOLCHAIN_SUPPORTS_PIE in static
> build with musl.
> 
> Fixes:
> http://autobuild.buildroot.net/results/d19/d19bcfcfb33cc5f5b082b97bbd5852d479823b97/
> http://autobuild.buildroot.net/results/91f/91f7c6954c337b03f5ac141050d9b1bee1623376/
> http://autobuild.buildroot.net/results/996/996116da9241686110b9525eed08cc5acfd379a6/
> 
> [1] https://github.com/richfelker/musl-cross-make/blob/b854a42fc1ea19b8c4ec7104848f9d1a6d7995f0/patches/gcc-6.3.0/0010-static-pie-support.diff
> 
> Acked-by: Waldemar Brodkorb <wbx@openadk.org>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  toolchain/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas
Peter Korsgaard June 1, 2017, 2:12 p.m. UTC | #2 
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 > As mentioned in commit 3c93901bcd2 (toolchain: add hidden symbol for PIE
 > support), support for static PIE using musl requires a gcc patch[1]. Buildroot
 > doesn't carry this patch. Don't enable BR2_TOOLCHAIN_SUPPORTS_PIE in static
 > build with musl.

 > Fixes:
 > http://autobuild.buildroot.net/results/d19/d19bcfcfb33cc5f5b082b97bbd5852d479823b97/
 > http://autobuild.buildroot.net/results/91f/91f7c6954c337b03f5ac141050d9b1bee1623376/
 > http://autobuild.buildroot.net/results/996/996116da9241686110b9525eed08cc5acfd379a6/

 > [1] https://github.com/richfelker/musl-cross-make/blob/b854a42fc1ea19b8c4ec7104848f9d1a6d7995f0/patches/gcc-6.3.0/0010-static-pie-support.diff

 > Acked-by: Waldemar Brodkorb <wbx@openadk.org>
 > Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Committed to 2017.02.x, thanks.
diff mbox

Patch

diff --git a/toolchain/Config.in b/toolchain/Config.in
index 652c9d8c1df4..6aaf68bf6547 100644
--- a/toolchain/Config.in
+++ b/toolchain/Config.in
@@ -28,7 +28,7 @@  config BR2_TOOLCHAIN_USES_MUSL
 	select BR2_TOOLCHAIN_HAS_THREADS
 	select BR2_TOOLCHAIN_HAS_THREADS_DEBUG
 	select BR2_TOOLCHAIN_HAS_THREADS_NPTL
-	select BR2_TOOLCHAIN_SUPPORTS_PIE
+	select BR2_TOOLCHAIN_SUPPORTS_PIE if !BR2_STATIC_LIBS
 
 choice
 	prompt "Toolchain type"