| Message ID | 20170522185031.13096-1-bernd.kuhls@t-online.de |
|---|---|
| State | Changes Requested |
| Headers | show |
Hello, On Mon, 22 May 2017 20:50:31 +0200, Bernd Kuhls wrote: > +ifeq ($(BR2_PACKAGE_AVAHI),y) > +MINIDLNA_CONF_OPTS += --enable-tivo > +MINIDLNA_DEPENDENCIES += avahi > +endif > + While indeed, Avahi is currently only used by the Tivo code, this is not directly encoded in the project configure.ac. It is checking separately for the Tivo option and the availability of Avahi, and the Tivo support can apparently be built without Avahi support. So, I would prefer: - A patch simply adding avahi as an optional dependency (i.e the same patch as yours, without the --enable-tivo line. - A patch that adds Config.in options to enable tivo, netgear, readynas support. I believe this would be matching more closely with what minidlna's configure script is doing. Thanks! Thomas
diff --git a/package/minidlna/minidlna.mk b/package/minidlna/minidlna.mk index 4fa55454c..21b0a931b 100644 --- a/package/minidlna/minidlna.mk +++ b/package/minidlna/minidlna.mk @@ -17,6 +17,11 @@ MINIDLNA_DEPENDENCIES = \ MINIDLNA_CONF_OPTS = \ --disable-static +ifeq ($(BR2_PACKAGE_AVAHI),y) +MINIDLNA_CONF_OPTS += --enable-tivo +MINIDLNA_DEPENDENCIES += avahi +endif + define MINIDLNA_INSTALL_CONF $(INSTALL) -D -m 644 $(@D)/minidlna.conf $(TARGET_DIR)/etc/minidlna.conf endef
Minidlna uses Avahi when TiVo support is enabled: https://sourceforge.net/p/minidlna/git/ci/0575299a8792d936f75d6e760e58c9d9bee4015f/#diff-4 Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> --- package/minidlna/minidlna.mk | 5 +++++ 1 file changed, 5 insertions(+)