| Message ID | 24442429-99f7-7d83-5f56-f84776a81880@users.sourceforge.net |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
On Mon, May 22, 2017 at 06:37:19PM +0200, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Mon, 22 May 2017 17:20:11 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > > This issue was detected by using the Coccinelle software. > > * Replace the specification of a data structure by a pointer dereference > to make the corresponding size determination a bit safer according to > the Linux coding style convention. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> > --- > net/sctp/protocol.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c > index 989a900383b5..2b1a6215bd2f 100644 > --- a/net/sctp/protocol.c > +++ b/net/sctp/protocol.c > @@ -1442,6 +1442,6 @@ static __init int sctp_init(void) > > /* Allocate and initialize the endpoint hash table. */ > sctp_ep_hashsize = 64; > - sctp_ep_hashtable = > - kmalloc(64 * sizeof(struct sctp_hashbucket), GFP_KERNEL); > + sctp_ep_hashtable = kmalloc_array(64, sizeof(*sctp_ep_hashtable), > + GFP_KERNEL); > if (!sctp_ep_hashtable) { > -- > 2.13.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sctp" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
On 05/22/2017 12:37 PM, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Mon, 22 May 2017 17:20:11 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > > This issue was detected by using the Coccinelle software. > > * Replace the specification of a data structure by a pointer dereference > to make the corresponding size determination a bit safer according to > the Linux coding style convention. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Acked-by: Vlad Yasevich <vyasevich@gmail.com> -vlad > --- > net/sctp/protocol.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c > index 989a900383b5..2b1a6215bd2f 100644 > --- a/net/sctp/protocol.c > +++ b/net/sctp/protocol.c > @@ -1442,6 +1442,6 @@ static __init int sctp_init(void) > > /* Allocate and initialize the endpoint hash table. */ > sctp_ep_hashsize = 64; > - sctp_ep_hashtable = > - kmalloc(64 * sizeof(struct sctp_hashbucket), GFP_KERNEL); > + sctp_ep_hashtable = kmalloc_array(64, sizeof(*sctp_ep_hashtable), > + GFP_KERNEL); > if (!sctp_ep_hashtable) { >
diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c index 989a900383b5..2b1a6215bd2f 100644 --- a/net/sctp/protocol.c +++ b/net/sctp/protocol.c @@ -1442,6 +1442,6 @@ static __init int sctp_init(void) /* Allocate and initialize the endpoint hash table. */ sctp_ep_hashsize = 64; - sctp_ep_hashtable = - kmalloc(64 * sizeof(struct sctp_hashbucket), GFP_KERNEL); + sctp_ep_hashtable = kmalloc_array(64, sizeof(*sctp_ep_hashtable), + GFP_KERNEL); if (!sctp_ep_hashtable) {