Patchwork mark flow_cache_cpu_prepare() as __init

login
register
mail settings
Submitter Alexey Dobriyan
Date Nov. 7, 2008, 3:40 a.m.
Message ID <20081107034059.GA20845@x200.localdomain>
Download mbox | patch
Permalink /patch/7654/
State Accepted
Delegated to: David Miller
Headers show

Comments

Alexey Dobriyan - Nov. 7, 2008, 3:40 a.m.
It's called from __init code only. And__devinit in generic networking code
is pretty strange :^)

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 net/core/flow.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Nov. 7, 2008, 7:07 a.m.
From: Alexey Dobriyan <adobriyan@gmail.com>
Date: Fri, 7 Nov 2008 06:40:59 +0300

> It's called from __init code only. And__devinit in generic networking code
> is pretty strange :^)
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>

I believe the history of this is that we used to call this thing
as a CPU hotplug operation, and at the time that was the appropriate
marker to use for such things.

Applied to net-next-2.6, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- a/net/core/flow.c
+++ b/net/core/flow.c
@@ -307,7 +307,7 @@  void flow_cache_flush(void)
 	put_online_cpus();
 }
 
-static void __devinit flow_cache_cpu_prepare(int cpu)
+static void __init flow_cache_cpu_prepare(int cpu)
 {
 	struct tasklet_struct *tasklet;
 	unsigned long order;