| Message ID | 20170522062552.19026-5-wens@csie.org |
|---|---|
| State | New |
| Headers | show |
On 22 May 2017 at 08:25, Chen-Yu Tsai <wens@csie.org> wrote: > The A83T SoC has a DMA controller that supports 8 DMA channels > to and from various peripherals. > > Add a device node for it. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > --- > arch/arm/boot/dts/sun8i-a83t.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi > index e12dd7170b8f..47196feda26b 100644 > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > @@ -163,6 +163,15 @@ > #size-cells = <1>; > ranges; > > + dma: dma-controller@1c02000 { > + compatible = "allwinner,sun8i-a83t-dma"; > + reg = <0x01c02000 0x1000>; > + interrupts = <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&ccu 21>; > + resets = <&ccu 7>; Hi Wens, these should be ccu defines, otherwise everything else looks great. Great Work, CK > + #dma-cells = <1>; > + }; > + > ccu: clock@1c20000 { > compatible = "allwinner,sun8i-a83t-ccu"; > reg = <0x01c20000 0x400>; > -- > 2.11.0 > > -- > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, May 22, 2017 at 3:18 PM, Code Kipper <codekipper@gmail.com> wrote: > On 22 May 2017 at 08:25, Chen-Yu Tsai <wens@csie.org> wrote: >> The A83T SoC has a DMA controller that supports 8 DMA channels >> to and from various peripherals. >> >> Add a device node for it. >> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> >> --- >> arch/arm/boot/dts/sun8i-a83t.dtsi | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi >> index e12dd7170b8f..47196feda26b 100644 >> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi >> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi >> @@ -163,6 +163,15 @@ >> #size-cells = <1>; >> ranges; >> >> + dma: dma-controller@1c02000 { >> + compatible = "allwinner,sun8i-a83t-dma"; >> + reg = <0x01c02000 0x1000>; >> + interrupts = <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&ccu 21>; >> + resets = <&ccu 7>; > Hi Wens, > these should be ccu defines, otherwise everything else looks great. Correct. Since the CCU bindings was just introduced, I'm saving all the macros for v4.13-rc2. ChenYu > Great Work, > CK >> + #dma-cells = <1>; >> + }; >> + >> ccu: clock@1c20000 { >> compatible = "allwinner,sun8i-a83t-ccu"; >> reg = <0x01c20000 0x400>; >> -- >> 2.11.0 >> >> -- >> You received this message because you are subscribed to the Google Groups "linux-sunxi" group. >> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, May 22, 2017 at 02:25:50PM +0800, Chen-Yu Tsai wrote: > The A83T SoC has a DMA controller that supports 8 DMA channels > to and from various peripherals. > > Add a device node for it. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> Applied, thanks! Maxime
Hi Markus, On Mon, May 22, 2017 at 09:18:49AM +0200, Code Kipper wrote: > On 22 May 2017 at 08:25, Chen-Yu Tsai <wens@csie.org> wrote: > > The A83T SoC has a DMA controller that supports 8 DMA channels > > to and from various peripherals. > > > > Add a device node for it. > > > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > > --- > > arch/arm/boot/dts/sun8i-a83t.dtsi | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi > > index e12dd7170b8f..47196feda26b 100644 > > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > > @@ -163,6 +163,15 @@ > > #size-cells = <1>; > > ranges; > > > > + dma: dma-controller@1c02000 { > > + compatible = "allwinner,sun8i-a83t-dma"; > > + reg = <0x01c02000 0x1000>; > > + interrupts = <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&ccu 21>; > > + resets = <&ccu 7>; > > these should be ccu defines, otherwise everything else looks great. In general, yes. In this particular case however, this is made on purpose, since Chen-Yu just introduced those defines that are part of a commit that will go in a different tree. We will switch to the defines once it reaches Linus' tree. Maxime
diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi index e12dd7170b8f..47196feda26b 100644 --- a/arch/arm/boot/dts/sun8i-a83t.dtsi +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi @@ -163,6 +163,15 @@ #size-cells = <1>; ranges; + dma: dma-controller@1c02000 { + compatible = "allwinner,sun8i-a83t-dma"; + reg = <0x01c02000 0x1000>; + interrupts = <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&ccu 21>; + resets = <&ccu 7>; + #dma-cells = <1>; + }; + ccu: clock@1c20000 { compatible = "allwinner,sun8i-a83t-ccu"; reg = <0x01c20000 0x400>;
The A83T SoC has a DMA controller that supports 8 DMA channels to and from various peripherals. Add a device node for it. Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- arch/arm/boot/dts/sun8i-a83t.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)