From patchwork Thu Dec 23 12:42:54 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 76510 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 9E89CB70E0 for ; Thu, 23 Dec 2010 23:48:38 +1100 (EST) Received: from localhost ([127.0.0.1]:40318 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PVkax-0000KT-OM for incoming@patchwork.ozlabs.org; Thu, 23 Dec 2010 07:48:35 -0500 Received: from [140.186.70.92] (port=55791 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PVkVY-0006L5-Bq for qemu-devel@nongnu.org; Thu, 23 Dec 2010 07:43:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PVkVX-0000pT-F3 for qemu-devel@nongnu.org; Thu, 23 Dec 2010 07:43:00 -0500 Received: from mail-wy0-f173.google.com ([74.125.82.173]:49297) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PVkVX-0000j4-6A for qemu-devel@nongnu.org; Thu, 23 Dec 2010 07:42:59 -0500 Received: by mail-wy0-f173.google.com with SMTP id 36so6559023wyg.4 for ; Thu, 23 Dec 2010 04:42:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:from:to:subject:date :message-id:x-mailer:in-reply-to:references; bh=w/wWwxwS4xtcctTc/P8XU1HrLGWV/1EMAEaNqbpUPu4=; b=li9ts4o7tEfv441zsCvj4qnZZYmlnsT8iaJkPA+yctbuoKmeM9ztnlr+XPopnT8MOK /jvSB+u04r2G+lJg2z1iTIcAte8swFeJIbtl3suRhA49SxRwBzT+2v8n9ltxZohJVx3l 7sS5IzrC2vP+Ul8pxyzKadukqs6j72lgZ+vCM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:subject:date:message-id:x-mailer:in-reply-to :references; b=vPhy+7bNUU3hInODugwGObL40fyfwSrVxShwdao9Hz/BLG8dJJS+YJp2sx5qFcm99+ XRIQGRYGpC16c6hgUw7gthfQmY3aFfWM7DwBKPVuqzK1+YWtCLB7PRcVdnhFrksO2YxY Pf0mZgbPHprxtTWpjyUKAVAB8b10UuiHjcgOM= Received: by 10.227.134.82 with SMTP id i18mr4947545wbt.50.1293108178833; Thu, 23 Dec 2010 04:42:58 -0800 (PST) Received: from localhost.localdomain (93-34-160-115.ip50.fastwebnet.it [93.34.160.115]) by mx.google.com with ESMTPS id 11sm5273491wbj.19.2010.12.23.04.42.57 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 23 Dec 2010 04:42:57 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Thu, 23 Dec 2010 13:42:54 +0100 Message-Id: <1293108174-24895-9-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.7.3.2 In-Reply-To: <1293108174-24895-1-git-send-email-pbonzini@redhat.com> References: <1293108174-24895-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: [Qemu-devel] [PATCH 8/8] fix QemuOpts leak X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Now that no backend's open function saves the passed QemuOpts, fix a leak in the qemu_chr_open backwards-compatible parser. Signed-off-by: Paolo Bonzini --- qemu-char.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 7b61a62..b99b77b 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2555,6 +2555,7 @@ CharDriverState *qemu_chr_open(const char *label, const char *filename, void (*i if (chr && qemu_opt_get_bool(opts, "mux", 0)) { monitor_init(chr, MONITOR_USE_READLINE); } + qemu_opts_del(opts); return chr; }