Message ID | 1495357860-28280-2-git-send-email-Yuval.Mintz@cavium.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show
Return-Path: <netdev-owner@vger.kernel.org> X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3wVwyd0qnjz9s78 for <patchwork-incoming@ozlabs.org>; Sun, 21 May 2017 19:11:37 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=CAVIUMNETWORKS.onmicrosoft.com header.i=@CAVIUMNETWORKS.onmicrosoft.com header.b="HJXwZwlh"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752523AbdEUJLV (ORCPT <rfc822;patchwork-incoming@ozlabs.org>); Sun, 21 May 2017 05:11:21 -0400 Received: from mail-by2nam03on0059.outbound.protection.outlook.com ([104.47.42.59]:29376 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752421AbdEUJLS (ORCPT <rfc822;netdev@vger.kernel.org>); Sun, 21 May 2017 05:11:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=pPBRWgOdXA6Bqm+ZSHneznPlPfRqNDROgxlr8Po3wR0=; b=HJXwZwlhyS3PUvd0zz+t/99iCkqD0j5wHiohDP2I0ZXuaBt0uIsrd3MRd45mxgqHw5/qQHEz7eLLgeZSJ7R/hcPLYCwg8A6O38Du4NYYQD6ft43YiXxxeM/odcu/dvyZkCT5XaLRAeqC1SDvH73+JDYczjNdGqdOAzH7EQy9nfk= Received: from SN1PR07CA0007.namprd07.prod.outlook.com (2a01:111:e400:3000::17) by DM2PR07MB431.namprd07.prod.outlook.com (2a01:111:e400:243a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1101.14; Sun, 21 May 2017 09:11:17 +0000 Received: from BN1AFFO11FD033.protection.gbl (2a01:111:f400:7c10::157) by SN1PR07CA0007.outlook.office365.com (2a01:111:e400:3000::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1101.14 via Frontend Transport; Sun, 21 May 2017 09:11:16 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BN1AFFO11FD033.mail.protection.outlook.com (10.58.52.246) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.1075.5 via Frontend Transport; Sun, 21 May 2017 09:11:16 +0000 Received: from localhost.qlogic.org (10.185.6.94) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Sun, 21 May 2017 02:11:13 -0700 From: Yuval Mintz <Yuval.Mintz@cavium.com> To: <davem@davemloft.net>, <netdev@vger.kernel.org> CC: Yuval Mintz <Yuval.Mintz@cavium.com> Subject: [PATCH net-next 01/10] qede: Allow WoL to activate by default Date: Sun, 21 May 2017 12:10:52 +0300 Message-ID: <1495357860-28280-2-git-send-email-Yuval.Mintz@cavium.com> X-Mailer: git-send-email 1.9.3 In-Reply-To: <1495357860-28280-1-git-send-email-Yuval.Mintz@cavium.com> References: <1495357860-28280-1-git-send-email-Yuval.Mintz@cavium.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(39410400002)(39450400003)(39400400002)(39840400002)(39850400002)(2980300002)(428002)(189002)(199003)(9170700003)(81166006)(50226002)(101416001)(76176999)(50986999)(8936002)(77096006)(50466002)(48376002)(8676002)(2906002)(356003)(104016004)(47776003)(5660300001)(305945005)(38730400002)(53416004)(86362001)(76506005)(107886003)(2950100002)(106466001)(105586002)(6666003)(478600001)(36756003)(5003940100001)(4326008)(72206003)(189998001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM2PR07MB431; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; MLV:sfv; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD033; 1:eP90weev8vK17A2vHtGpCEyoxFxqoz+R7js5NNm1J07kyFEiz8S4R65tf+qNY6Ka0N90oJIpCno29uVAxjXeDfF5zdhtNCejqJNlDZ3pWe51nc19ptYZtrwAmSAkxlS+9SBxVgMn9+gOt74QkREy8Ex4Y00zGRdqTpg1IVyfGUmpBLKisA8wz65IqcnZL765VskdwU0sp0h49CJGWWL5nWZ1WMwMh+NWMzJEfI0cIsNF5IIx337FTbMcY/Wfl7FmVCqNECFqw6ldODiynlcGvXGuTCfBAQSpKnDjncFs3rQF/9kCRdrpNvFIX5AaPuz2IrBC5HMXACWweSGwud2CgaHoZP2hMyVNmOJW/p3dFFVTNTVu/DpJkLbUvr1CDGv6Y6aVefB4oxVZvK8/kF3Tvk19zglP9cA2ou558rbboClcKJLJSySJF9rbj5KzsT0OnH0izWfoOL5SZadtww91rQ2CGS5XoZkW1GYWqJuzSZ7IKtOgQvrGhhALUT8RLxqMYbo6n06AH6WN5nHCAWamF9TdjSiwLUIMMdmNnNq8rg4= X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM2PR07MB431: X-MS-Office365-Filtering-Correlation-Id: 91c92f5b-9dfc-446b-a20f-08d4a0295650 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(201703131423075)(201703031133081)(201702281549075); SRVR:DM2PR07MB431; X-Microsoft-Exchange-Diagnostics: 1; DM2PR07MB431; 3:XnnpC37gmz6TsTZB/7RMD3kNhbChjj+LYaZdceNg9/uYziFNx4BOiW/KjldGkhQLWFgNuHvZ7PFum5bL0l6U1OfmNo0IqL57LZ9psCDBZCdmjynSZ8FiyXBIi65FD9eQbnuTwVodnr024LpIc3q6+32ELUw/De+LY0e+GDiR6lMqqGdOS4VBZiSzMyz1rqVKuA32d5ffZZ+NjOE4O5IdHkHN1gs7bXjPLa6TqOo2u75QaKxgSZhLSxrcwQNZjH8BtU9IguoaDqkiicMbt3u0mJi9rieqlthxLeR6udi0lZmfYNhN1c1TzbiC26/OtLtDIkG+ZWdFCkLG8mmnmNM3TMiwsL+1XzH6rECvgW5XFUpk+jnEKD2ICwZqEdUGAel84TVtojo1P4wVgdrJaEkH0XLy1NIM6AlBxG0/VPDIh7jgPbgNgPktg9/jSEwcMi1rGFUO9urU860i/XpQ0HonySTSb7+vLzt0ILc8gtArzBJsJpqURYiFK5hAB/ln7Yxi X-Microsoft-Exchange-Diagnostics: 1; DM2PR07MB431; 25:Tut6sbvguDvHKe6jGFz3YnWyEZNbRC06nDnGD8eCDWxMuBoJSXKhMvKePEZcicw51nnSG0raHdsnq14DXJx7avBF/UvP/syvxaOirR8KIM8hdqvwZnxKOoL5L5j9bxHLosr//XfGBf1bc36mG4W7MHzU0pCtgjfT/OrR2YxJ8e3s9uBAl1pE9+J3dlgTC02XTOnNWmB1HLwIKN2C1Ks/bLpY7fwgrss7qu0wqsrE0VGoUJvUZq96xHrz2Fmgb8homyQVuTKATf3dHqVGC/kQCn3iC5XlglbXps4DLN7+yBkw3ad5EDFC+oGNXynqVjAUMgdHUsKGCsGejyR59xFcRMiAVyC+B0aGZ4R1637pc9Xeiz0nrxlbSQiAGaaRDiPq7WQSbVySIzd0f+b8+A1tR9JypkA20XISvVAF/qUmMfxnk3yOMbV+h+wvhftnG2lNW6JZQeiCGrP9QlnCFtuQLfgbE4GY5x/ifrq0GaOJe9c=; 31:pkvb1nbG/oELavVP++R6GEqYj512I/XO+3JFuuCYgE31N5/D8TEttosBJEJXjhdWlFeSgAYmbbXardXGd5ECBpfprKx0zV6NQn3h4mcbMD0nNbOwhvdsG6RQjzKDw7QD8wadHUodLejITjjRDfGmvgsr4vjXIN+bY3C2d9WZInAb3zwYAAnujHKJ9pGF3Lhba7SVZ5wsN3xfOvoEcRc+2XM+M28W6G/741aHro7SGm+23LrnyDWUWp3L0MfiP46vMZUEvyai6zANRx1ISvKjbQ== X-Microsoft-Exchange-Diagnostics: 1; DM2PR07MB431; 20:tmp2B9uObCJcIy3Ni4LuDd0/YpMP+Kt0VnEh320iWYA6lwRM1OdmQ1EdVKewn3QbMvORpHaLvcSe9srclVlOOI1UbIT+VJM5dwHgyJ1AC+qnLiiwqtyOB+4XaBRnsA+VTByMupHk5cN8ZBCyYEAeeqfrTUwr1jxaXQIHcGRdQ83ti85OypD2NJKjVCgtm7aTYEHI2j2prCWokarEit96WeTpBQZRhnjdpI+bRHA9BcyISs3X5TZmTiAPC81bDuJo61Z3iKBrg+KLMbgL8oGfVvUWyhmbyQH4+3ltXGUgxwQ0/8m5QVx9HMjPdAuC3jPj5SWotAoEZd53n62/Wp5xGk3EXTe6eRWU4xO04ZLu4aU8l7eTRHajNmBD+L3A/9x3sJWVjcP/MMI+sF2/TgdtIqOxK+/7qIrjQ3I5oqfxnjsEy/P+5RelZbYl1v2WDfBxfSfBH3lq/D4Sz+we7EatSJsHI5d/XgDHSZdgJX+9xphBACnRUJvjA9ucp95jC0eQ X-Microsoft-Antispam-PRVS: <DM2PR07MB43142F71893C9B786E660A08DFB0@DM2PR07MB431.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(13017025)(13015025)(5005006)(13024025)(13023025)(8121501046)(13018025)(3002001)(93006095)(93001095)(10201501046)(6041248)(20161123560025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(6072148); SRVR:DM2PR07MB431; BCL:0; PCL:0; RULEID:; SRVR:DM2PR07MB431; X-Microsoft-Exchange-Diagnostics: 1; DM2PR07MB431; 4:UfKQZU73TqGI7C1TomVkmUflh5a8UeUyoOVoebgJ494KNs7dKihhVidFraRI93LHo1O8/QNIOcUWq1pGy2r9KQbKz+ZVK+NpKWivLz28qfl/kXtnOEggio5A8tF8o7m1cLEGnTmUYXHnT0B5m8igqEKeloyyrHWqodsDFOGiissKkgXTv1akBFx30eY9zRgYypQTqhaYmgTjv4L4K2m2NNHtiMTATTJdYrhEyP6MKVDOpY/WgFmnnY9rzV9teb7aYaoXPYCDpWmGwGKKw3LoJit5YHh6QCLP84DzkSeURTEALISDanPr9p2tKKPrsRl3EgUDSIwBI4QCot3xIihTdV9Qg5Lrt100adN+bvMTYBpxN+9UaN6WICPW3jyeMqtpIGCyFJTv1ehwmSK2YBktq+4dKOdd5s443utciQeWAapXsJiY6HuUUeTucKQtl36luxJrusxqLauRxtJS/zP8/d0hdEyu94oxE+2Ju3d5j+q0pUauF4YBwcC0tdt2DUxf/6Cjwdvcu3s96gAIWZRGqlkGAZwCMPEAVKtCkjU/PQjRr9HsMO3axPJKvq2zEyAaoXAYxmhQHJgrk2oQUyPvD/Ov7E1tzrtwyfGiOZqJ7jZ1tLLac2nCj7pR146UumevweUNJfl4TJnbhpUDJnV9hUL5IYGqJxggdDSxGdJGet+CDYNDM8jDPVyOigX5mmN60CoRTUf0iSxb0DzY4tMAYS6b4kKEBjRdiag6JqIxyxN9HNtzChWu/cyxipPuFEFbMcVlcdrYWXuY3tYo504v6jxDh9DeKfj4v06g43WBvy0Rc3zJbeWjwnBAtRnpARTZoqJO+oh45K+FOoBqPE/6mUwUigVUy63hMSUqm1lQpFSy0pKGp4jEwnLb1n4Xwj8V X-Forefront-PRVS: 03142412E2 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM2PR07MB431; 23:tg26VmqStsyOgVEib8Z1LYPVyTGO77jjgK4yzX+5aZ?= =?us-ascii?Q?nu2FS7LE49KDdxkb/e9YUiXdN2pL3vAR9+N+T4Hd7x0L7VDPvXL+zgTH+QkK?= =?us-ascii?Q?B8VKs6Q+3f4hXiKwC8W82cU1x+f/WjFG8tF7NIU6ryUv3Swjvcs48AwoaccY?= =?us-ascii?Q?WzVnMd4bW3VqNxBoiArl6bxuSUOCzRZVVAI3X3QZMmbLVCkSEoNXtR0gjEjX?= =?us-ascii?Q?2SSgRXWP31+stE6mr3ibbsxqKfqWuIKg/ZvmHjiL1L0QhGk1mBps4ZD8nUlm?= =?us-ascii?Q?PJ96gTk+eoapjKScAqrF5tLC9AU8hRh//enAQTZ08n+A0LrmIpUuCUiKxIq7?= =?us-ascii?Q?VBVTqkyw5CncVVXFbRWpNCRrYQrBmcqIzabKYww5OOPjjlF2Lt04QsBTXslC?= =?us-ascii?Q?/AJ1c3v2euYn6BZCkGWu44fZe/nh51sXUC193zH4VIrdWJ3r0fBjuPm0s0XF?= =?us-ascii?Q?pUoOYDhrGMnyIHb6vXSWUP6AXprojCLsGT3lGP8h9fARFRPOECxkpminqszk?= =?us-ascii?Q?7lEobvWplK+D+JWgxMHQqhzXwXHVq2F7iooLrz6geU6TuNtewR0rtYp1Pxft?= =?us-ascii?Q?wjWMO94Zr6SvdTxTeuflrE66FsHiWotcJa7k+yJv13ngtIsFPKaaSZ43oFXP?= =?us-ascii?Q?TVQFpeS0sLBZSdmxAWrXFVebIgi7TaiNUlXHhPFtP2DxreJVSBHqddJeLMup?= =?us-ascii?Q?U1gEZ4UCKPhp9OqpU/au50CSWsT1kYEhDEqnAn9pDOciasDkGOAjRa+YlDzu?= =?us-ascii?Q?9W4KFr9aYsDp0EaWz6cUB5I+5oWUzoaT4mSDeAltgX5xpNYQzLj4X2QoUH/N?= =?us-ascii?Q?ESY9Wxj6vihzSFWeGaq3N6Xxq23xBjytKa5QWth+iE8EBkOPJ1mpgl0Ly0jl?= =?us-ascii?Q?lNlThUM5nb7MX+1NZhHP0ocKtve0305CHA0Db9LtC7CQ+xQCo1W4CkA1AuLY?= =?us-ascii?Q?8aai2pQ0GHo3KWLZprJppqbIm+lh9KULlIkcBek8eB6P8+mMKMreO8u/XlI/?= =?us-ascii?Q?vA1WNCgkJt2bT29uixPze2FgA1a70mxKN09NMtRl47rqlBTM2DWL2XLsuBpZ?= =?us-ascii?Q?ZrJlQ/UTwphlmYtxI2rImW99Ra?= X-Microsoft-Exchange-Diagnostics: 1; DM2PR07MB431; 6:okdjAb/09ryfhJsUq1xpG1DB6AU7rEH/fknYqJ0T1shM+hmUUQcEFqRVL0fW2PRKwbmnEglCJW2foTSuIMCvFgWjGUNfFVIrrI7wrClK3lloc9osbpgkXDyID82kLb2CVHKd/pNh84RRFZnGZrm+dyjMeVrGe7UouaWVIgs5Q6uXRZX/8E+JNc6ETpW8DskkWMwKXGPDPpe9qgHqzUBBWdrpqWoKm+ZF5ScCQBBy94/olmgyAGu5SwPBZwzoz4Yz4vAKuBzNNY19mdx6GvWVwmJ8w+d2DGrvvrpRAr0ShIFVWi5hhnW7LNTkDfk4hSC7ksrjKAo6dg4FIUg7LUKrcHH2SIlY1/eOZVObPOY0xuD76DT7rbjdscn+Gnus59i1O9neautHPG30TjaFvhRu2YflB+6p8ao1EdYbRhwVfmW+dR46Ji+DHRyM/jVSsPVegLvzL0QxDdbX79Z0v7TSUgFtLYfkluj59unbzAWz4esdGzAGI8NmkxpAayH9W5BicgmaujrryiLcO6hK61gz1g==; 5:cVKKtr//FuN3krUYKD4dc5cBpvh3808WfAPIMg2ZmYZkwUAnAS65Yj/k8+wwVisow5AaZyqJ2J7//N9WIQwtr+GgBb0Byclpcugm+vPqDcKTqHhkAvDpaRmEZgzXdoAgcLrH2F7i62HLg14nocDtnA==; 24:eEltGlVxp2N4BHylwKiaWERcsQQRO04roMxynSa53/tiXLBOD/qq/9E703s1EsYMiIz2+fGgR331pwZyJL+vxCoCiGmVqkC+Xc/tWFZfXRc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM2PR07MB431; 7:Zk55UABUy3GmWBFzXY5Y+NoK+j6LDEAmAx4IHaLpG774KXa//roNLdQpJj8pYiV4PAgmHvIyMhO5/dUXHSa5NLe0AngrjtXyALgli4XzYFDhkcv17mLI3JucZwoPBbFn947w2dkjSoz/GdVzjGOo8zoXJotYuvtizaR5LIxe6WDuELTt7Hkqe48RoEvgY45hvPtz8Mku7kWruPfAp+QFybeT9t/nQHlSHew1xnPD0nc17fg3RsVEbLkdK4zgkSvNoyomOIy77k9hWB7wEGYF8/XeM8YqvJT4Fv93N+Y3CdYRyb7w8H6NvWGgdbx3BYOc3r20erb7PjAchLmOqJSBxg== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2017 09:11:16.4878 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR07MB431 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: <netdev.vger.kernel.org> X-Mailing-List: netdev@vger.kernel.org |
diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c index 38b77bb..4a46052 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_main.c +++ b/drivers/net/ethernet/qlogic/qede/qede_main.c @@ -618,6 +618,12 @@ static struct qede_dev *qede_alloc_etherdev(struct qed_dev *cdev, memset(&edev->stats, 0, sizeof(edev->stats)); memcpy(&edev->dev_info, info, sizeof(*info)); + /* As ethtool doesn't have the ability to show WoL behavior as + * 'default', if device supports it declare it's enabled. + */ + if (edev->dev_info.common.wol_support) + edev->wol_enabled = true; + INIT_LIST_HEAD(&edev->vlan_list); return edev;
When management firmware declares that the device is WoL-capable, the default driver behavior would be to allow the management firmware to take the decision of whether it's actually needed or not. Problem is ethtool interface doesn't have a 'default' kind of option, and user would see the interface WoL as disabled, which doesn't accurately reflect the actual configuration. More-so, if the user actually wants to explicitly disable WoL he'd have to first enable it [otherwise ethtool would block the command]. Instead of allowing management to make the decision, enable WoL by default on all devices capable of it. Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com> --- drivers/net/ethernet/qlogic/qede/qede_main.c | 6 ++++++ 1 file changed, 6 insertions(+)