[build,objc] Link libobjc*.la with -shared-libgcc

Message ID	ydd1v58iv92.fsf@manam.CeBiTec.Uni-Bielefeld.DE
State	New
Headers	show Return-Path: <gcc-patches-return-281669-incoming=patchwork.ozlabs.org@gcc.gnu.org> From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> To: Andrew Pinski <pinskia@gmail.com> Cc: gcc-patches@gcc.gnu.org, Paolo Bonzini <bonzini@gnu.org>, Nicola Pero <nicola.pero@meta-innovation.com> Subject: Re: [build, objc] Link libobjc*.la with -shared-libgcc References: <ydd4oa5ltxz.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <AANLkTin5t9k4ENRRhShzdKHe7pK7e-QrdjHvX0ktds-Z@mail.gmail.com> Date: Thu, 23 Dec 2010 12:28:09 +0100 In-Reply-To: <AANLkTin5t9k4ENRRhShzdKHe7pK7e-QrdjHvX0ktds-Z@mail.gmail.com> (Andrew Pinski's message of "Wed, 22 Dec 2010 13:13:46 -0800") Message-ID: <ydd1v58iv92.fsf@manam.CeBiTec.Uni-Bielefeld.DE> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk Sender: gcc-patches-owner@gcc.gnu.org

Message ID

ydd1v58iv92.fsf@manam.CeBiTec.Uni-Bielefeld.DE

State

New

Headers

From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Andrew Pinski <pinskia@gmail.com>
Cc: gcc-patches@gcc.gnu.org, Paolo Bonzini <bonzini@gnu.org>,
	Nicola Pero <nicola.pero@meta-innovation.com>
Subject: Re: [build, objc] Link libobjc*.la with -shared-libgcc
References: <ydd4oa5ltxz.fsf@manam.CeBiTec.Uni-Bielefeld.DE>	<AANLkTin5t9k4ENRRhShzdKHe7pK7e-QrdjHvX0ktds-Z@mail.gmail.com>
Date: Thu, 23 Dec 2010 12:28:09 +0100
In-Reply-To: <AANLkTin5t9k4ENRRhShzdKHe7pK7e-QrdjHvX0ktds-Z@mail.gmail.com>	(Andrew
	Pinski's message of "Wed, 22 Dec 2010 13:13:46 -0800")
Message-ID: <ydd1v58iv92.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (usg-unix-v)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: quoted-printable
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
Sender: gcc-patches-owner@gcc.gnu.org

Commit Message

Rainer Orth Dec. 23, 2010, 11:28 a.m. UTC

Andrew Pinski <pinskia@gmail.com> writes:

> On Wed, Dec 22, 2010 at 7:15 AM, Rainer Orth
> <ro@cebitec.uni-bielefeld.de> wrote:
>>
>> As described in the third link, 6 bootstraps (i386 and sparc, sun ld
>> with as, gas, gld with gas) are currently running.  Ok for mainline if
>> they all pass?
>>
>> Thanks.
>>        Rainer
>>
>>
>> 2010-12-22  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
>>
>>        * Makefile.in (libobjc$(libsuffix).la): Link with -shared-libgcc.
>>        (libobjc_gc$(libsuffix).la): Likewise.
>
> Yes this is ok.

Thanks.  Actual testing revealed that a plain -shared-libgcc is
swallowed by libtool, but using -Wc,-shared-libgcc works as expected.
So here's the actual patch I've checked in.  Libtool continues to remain
a mystery to me ;-)

	Rainer


2010-12-22  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	* Makefile.in (libobjc$(libsuffix).la): Link with -Wc,-shared-libgcc.
	(libobjc_gc$(libsuffix).la): Likewise.

diff -r ba5f37177ba3 libobjc/Makefile.in
--- a/libobjc/Makefile.in	Wed Dec 22 12:22:52 2010 +0100
+++ b/libobjc/Makefile.in	Wed Dec 22 17:08:02 2010 +0100
@@ -1,6 +1,6 @@ 
 # Makefile for GNU Objective C runtime library.
 # Copyright 1993, 1995, 1996, 1997, 1998, 1999, 2001, 2002, 2003, 2004,
-# 2005, 2006, 2007, 2008, 2009 Free Software Foundation, Inc.
+# 2005, 2006, 2007, 2008, 2009, 2010 Free Software Foundation, Inc.
 
 #This file is part of GCC.
 
@@ -325,13 +325,13 @@ 
 
 libobjc$(libsuffix).la: $(OBJS)
 	$(LIBTOOL_LINK) $(CC) -o $@ $(OBJS) \
-		-rpath $(toolexeclibdir) \
+		-Wc,-shared-libgcc -rpath $(toolexeclibdir) \
 		-version-info $(LIBOBJC_VERSION) $(extra_ldflags_libobjc) \
 		$(LTLDFLAGS)
 
 libobjc_gc$(libsuffix).la: $(OBJS_GC)
 	$(LIBTOOL_LINK) $(CC) -o $@ $(OBJS_GC) $(OBJC_BOEHM_GC_LIBS) \
-		-rpath $(toolexeclibdir) \
+		-Wc,-shared-libgcc -rpath $(toolexeclibdir) \
 		-version-info $(LIBOBJC_GC_VERSION) $(extra_ldflags_libobjc) \
 		$(LTLDFLAGS)

[build,objc] Link libobjc*.la with -shared-libgcc

Commit Message

Patch