| Message ID | 20170519165556.483-4-sthemmin@microsoft.com |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Stephen Hemminger <stephen@networkplumber.org> Date: Fri, 19 May 2017 09:55:50 -0700 > udp_queue_rcv_skb was global but only used in one file. > Identified by this warning: > net/ipv4/udp.c:1775:5: warning: no previous prototype for ‘udp_queue_rcv_skb’ [-Wmissing-prototypes] > int udp_queue_rcv_skb(struct sock *sk, struct sk_buff *skb) > > Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com> Already fixed in net-next, please generate patches against current sources.
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c index e7b6cfcca627..8d7980ca27a0 100644 --- a/net/ipv4/udp.c +++ b/net/ipv4/udp.c @@ -1772,7 +1772,7 @@ EXPORT_SYMBOL(udp_encap_enable); * Note that in the success and error cases, the skb is assumed to * have either been requeued or freed. */ -int udp_queue_rcv_skb(struct sock *sk, struct sk_buff *skb) +static int udp_queue_rcv_skb(struct sock *sk, struct sk_buff *skb) { struct udp_sock *up = udp_sk(sk); int is_udplite = IS_UDPLITE(sk); diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c index f78fdf8c9f0f..d558c1fef6fd 100644 --- a/net/ipv6/udp.c +++ b/net/ipv6/udp.c @@ -570,7 +570,7 @@ void udpv6_encap_enable(void) } EXPORT_SYMBOL(udpv6_encap_enable); -int udpv6_queue_rcv_skb(struct sock *sk, struct sk_buff *skb) +static int udpv6_queue_rcv_skb(struct sock *sk, struct sk_buff *skb) { struct udp_sock *up = udp_sk(sk); int is_udplite = IS_UDPLITE(sk);
udp_queue_rcv_skb was global but only used in one file. Identified by this warning: net/ipv4/udp.c:1775:5: warning: no previous prototype for ‘udp_queue_rcv_skb’ [-Wmissing-prototypes] int udp_queue_rcv_skb(struct sock *sk, struct sk_buff *skb) Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com> --- net/ipv4/udp.c | 2 +- net/ipv6/udp.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)