From patchwork Wed Dec 22 23:09:43 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: jvrao X-Patchwork-Id: 76451 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 9355AB70DA for ; Thu, 23 Dec 2010 09:43:14 +1100 (EST) Received: from localhost ([127.0.0.1]:46451 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PVXOj-0006vY-QL for incoming@patchwork.ozlabs.org; Wed, 22 Dec 2010 17:43:05 -0500 Received: from [140.186.70.92] (port=55077 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PVXOF-0006vK-DS for qemu-devel@nongnu.org; Wed, 22 Dec 2010 17:42:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PVXOE-00011B-4H for qemu-devel@nongnu.org; Wed, 22 Dec 2010 17:42:35 -0500 Received: from e4.ny.us.ibm.com ([32.97.182.144]:59190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PVXOE-0000zw-1P for qemu-devel@nongnu.org; Wed, 22 Dec 2010 17:42:34 -0500 Received: from d01dlp02.pok.ibm.com (d01dlp02.pok.ibm.com [9.56.224.85]) by e4.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id oBMMP5Y1003103 for ; Wed, 22 Dec 2010 17:25:05 -0500 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 05A6D4DE803B for ; Wed, 22 Dec 2010 17:40:09 -0500 (EST) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id oBMMgTrX150018 for ; Wed, 22 Dec 2010 17:42:30 -0500 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id oBMMgTvc030359 for ; Wed, 22 Dec 2010 15:42:29 -0700 Received: from localhost.localdomain (elm3c187.beaverton.ibm.com [9.47.69.187]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id oBMMgSNf030341; Wed, 22 Dec 2010 15:42:29 -0700 From: "Venkateswararao Jujjuri (JV)" To: qemu-devel@nongnu.org Date: Wed, 22 Dec 2010 15:09:43 -0800 Message-Id: <1293059383-9443-1-git-send-email-jvrao@linux.vnet.ibm.com> X-Mailer: git-send-email 1.6.0.6 X-Content-Scanned: Fidelis XPS MAILER X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Cc: aliguori@us.ibm.com, "Venkateswararao Jujjuri \(JV\)" Subject: [Qemu-devel] [PATCH] Add a check for readlink in mapped mode. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Venkateswararao Jujjuri Reviewed-by: Stefan Hajnoczi --- hw/9pfs/virtio-9p-local.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/hw/9pfs/virtio-9p-local.c b/hw/9pfs/virtio-9p-local.c index a8e7525..9a106d4 100644 --- a/hw/9pfs/virtio-9p-local.c +++ b/hw/9pfs/virtio-9p-local.c @@ -112,6 +112,13 @@ static ssize_t local_readlink(FsContext *fs_ctx, const char *path, ssize_t tsize = -1; if (fs_ctx->fs_sm == SM_MAPPED) { int fd; + mode_t tmp_mode; + /* Make sure that it is a symlink */ + if (getxattr(rpath(fs_ctx, path), "user.virtfs.mode", &tmp_mode, + sizeof(mode_t)) <= 0 || !(tmp_mode & S_IFLNK)) { + errno = EINVAL; + return -1; + } fd = open(rpath(fs_ctx, path), O_RDONLY); if (fd == -1) { return -1;