| Message ID | 1495178867-817-1-git-send-email-geert+renesas@glider.be |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
Hi Geert, On 2017-05-19 09:27:47 +0200, Geert Uytterhoeven wrote: > The documentation for the "interrupt-names" property only mentions the > per-channel interrupts, while the error interrupt has always been > mandatory, too. > > Fixes: 10f5c8438475909a ("dmaengine: rcar-dmac: Add device tree bindings > documentation") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt > index 3316a9c2e638b98c..79a204d50234f287 100644 > --- a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt > +++ b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt > @@ -30,8 +30,9 @@ Required Properties: > > - interrupts: interrupt specifiers for the DMAC, one for each entry in > interrupt-names. > -- interrupt-names: one entry per channel, named "ch%u", where %u is the > - channel number ranging from zero to the number of channels minus one. > +- interrupt-names: one entry for the error interrupt, named "error", plus one > + entry per channel, named "ch%u", where %u is the channel number ranging from > + zero to the number of channels minus one. Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > - clock-names: "fck" for the functional clock > - clocks: a list of phandle + clock-specifier pairs, one for each entry > -- > 2.7.4 >
On Fri, May 19, 2017 at 09:27:47AM +0200, Geert Uytterhoeven wrote: > The documentation for the "interrupt-names" property only mentions the > per-channel interrupts, while the error interrupt has always been > mandatory, too. Applied, thanks
diff --git a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt index 3316a9c2e638b98c..79a204d50234f287 100644 --- a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt +++ b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt @@ -30,8 +30,9 @@ Required Properties: - interrupts: interrupt specifiers for the DMAC, one for each entry in interrupt-names. -- interrupt-names: one entry per channel, named "ch%u", where %u is the - channel number ranging from zero to the number of channels minus one. +- interrupt-names: one entry for the error interrupt, named "error", plus one + entry per channel, named "ch%u", where %u is the channel number ranging from + zero to the number of channels minus one. - clock-names: "fck" for the functional clock - clocks: a list of phandle + clock-specifier pairs, one for each entry
The documentation for the "interrupt-names" property only mentions the per-channel interrupts, while the error interrupt has always been mandatory, too. Fixes: 10f5c8438475909a ("dmaengine: rcar-dmac: Add device tree bindings documentation") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)