From patchwork Fri May 19 07:05:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dong Aisheng X-Patchwork-Id: 764464 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3wTfP358m1z9s5L for ; Fri, 19 May 2017 17:11:35 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753348AbdESHLS (ORCPT ); Fri, 19 May 2017 03:11:18 -0400 Received: from mail-cys01nam02on0065.outbound.protection.outlook.com ([104.47.37.65]:21682 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751388AbdESHFs (ORCPT ); Fri, 19 May 2017 03:05:48 -0400 Received: from BN6PR03CA0029.namprd03.prod.outlook.com (10.175.124.15) by BN3PR0301MB0898.namprd03.prod.outlook.com (10.160.156.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1101.14; Fri, 19 May 2017 07:05:46 +0000 Received: from BN1AFFO11FD044.protection.gbl (2a01:111:f400:7c10::110) by BN6PR03CA0029.outlook.office365.com (2603:10b6:404:10c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1101.14 via Frontend Transport; Fri, 19 May 2017 07:05:45 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1AFFO11FD044.mail.protection.outlook.com (10.58.52.191) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1075.5 via Frontend Transport; Fri, 19 May 2017 07:05:45 +0000 Received: from b29396-OptiPlex-7040.ap.freescale.net (b29396-OptiPlex-7040.ap.freescale.net [10.192.242.182]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v4J75bFk023171; Fri, 19 May 2017 00:05:41 -0700 From: Dong Aisheng To: CC: , , , , , , , Dong Aisheng Subject: [PATCH V2 1/5] pinctrl: imx: fix debug message for SHARE_MUX_CONF_REG case Date: Fri, 19 May 2017 15:05:41 +0800 Message-ID: <1495177545-23006-2-git-send-email-aisheng.dong@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1495177545-23006-1-git-send-email-aisheng.dong@nxp.com> References: <1495177545-23006-1-git-send-email-aisheng.dong@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131396511459978752; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39410400002)(39380400002)(39850400002)(39400400002)(39860400002)(39840400002)(39450400003)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(9170700003)(110136004)(53936002)(8676002)(356003)(81166006)(54906002)(498600001)(104016004)(8936002)(50226002)(4326008)(2950100002)(6916009)(15650500001)(5660300001)(85426001)(2906002)(77096006)(38730400002)(36756003)(33646002)(305945005)(76176999)(48376002)(50466002)(189998001)(106466001)(86362001)(5003940100001)(2351001)(50986999)(105606002)(47776003)(8656002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR0301MB0898; H:az84smr01.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; MX:1; A:1; PTR:InfoDomainNonexistent; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD044; 1:WShMReeXGE1YQyEgKlfa1uvJr7fhH6eO/oKv1FmQhlyZ2bxn5vas/2h4A4aoJjR6fKxIgvgpN5M5gNnCAaDp/Ys2NLMxMeQEZC5wJEkfB/OsaWYRHSyi33XtsL1iuw/uq6nf47EU4PSuvxRtRjkr+o5sQ4h6hNqdBxRwlIApX7EwiG97b431B8BWU80HQX83KvelnEArrY1odBQ2cF6nfP0BuBSV29ES7vvcr9lC71Yaf9qyHXnHKY5hJkyPxSc1k+2MxyoZh51izm2IqzZcglrBy+ZEjfZfZLtqzAlt4dq4ZAHwQ3IuU3SmlQvKuQaqeo8HjjUDtccDv89Lsxt4XEvqB7t0tTQ63aNlgY/VRFPNsampIAIU1U2ZFNM1m/Yg5pOz909vDLPtwZTyH/wBh9kq/fxcpKjKpVRtyhkqF+H+pF7PTcir+hUH+XpZT5C7U+WXlE1chzWIJYSIVdQtaiElySc/t0ix0GeLSSsd+dxLB1QmsIudh5WWfwglcn/VqckV692kIA2ttaArfDO1xadkcr7R1r6ZpBc7X8/umsbjfK5Uit8HeSdH4oomnVm5estyvaXa4aLxvD/hBBru+WoyCbVBGzfmViQTRcH3+9A6bBNIsxfJhxjtQSUI9fGfZ7WoK3xbRuhjh4vW84JpnBhxCu1vmQ0+cHfUritsqUilQK/ZaQ+QlUsVSazrZf8W7s0vcSFP3MIoSInOKdz3HxnoxikohIRXi4MKlioiPmI= MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PR0301MB0898: X-MS-Office365-Filtering-Correlation-Id: 24377326-d936-4699-cc9f-08d49e8578c0 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131430075)(201703131517081); SRVR:BN3PR0301MB0898; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0301MB0898; 3:zPEIt+KCxjmTIN57DBxs5sABA1RH6jSIyWYIn0Zdz92dFUrrA3wM62JDIu0JmZdvTyygdHEo2FCpLm3qm2j2yrVw1hhJluwrIPdZuIkcE170OhBTAMKMRElGtFsZ2yPknLVLuEg51RyTAfqunzPnc7AKdeMszPFSwWCg5uYf/l7PlKTLhHd+YsNZUO2aTnQAqpnrya7R0zZ4VXnoz+gX+8oMuzoGvIyC8tJpTLimuww8G1aMIaw6cy2pjfE2GstNPKcmcD0+YNxQSXSoPcS3Do8nBjUYGbL4pu/bMm8rBVboTqqm80kKQNrzwM2YBi6TXeVPdDzo6sFD4jiLDVH/pJS7hbI00j7D2OVUWb5lIUiST/F/C5Yom4dww8+WW3+G24JH/H7D8QCU5M86tBaraMT/UTR5yuKQOLmitFTGsDIw2hDwez0EqplKcGYssgnJ; 25:cB8NPf6b9lh0QbCu2qir+cegPpXVHOWSRwUodFGCyWJrR3O990IbY3leRVabsYFnIQC2HQnebDFmlM7yNVbjfnOL618VpWIeAgXvQSCIjrTkpf5G9gJxqfJJ/foT2qRgQIvEd32Far52WBQdyEkyGdobfqVCct4CH7Dh83u6JhGqXW1GEk2ZyVPo/4ZYBI5Gu5t5NtIr0/G9xdcBvtvxnERX9i+8EREiRII8TV4EUQZK7mHXudjb38y8NiD53kckvoP82z+R/5FCa8Frffzm0bCwmT7HPgf+OLVtwgMXo22KR3zyMD9+xvZlyRXD50xll3gH7Zwx+PvQHt5v6KgeeXuNOeN1vboWsWjV8lmSz5LjeAJXrNAYWU3kSUUzTrdGUywFyygt/JiKWEDBx7HUqc3d/IYXtAAwNlvvMstlmi8l/VFPdwWROlaA5/f7BtbNSTARzEvAdYKHX7fEgxACnLzVATnMItH1PCm98A3VuWc= X-Microsoft-Exchange-Diagnostics: 1; BN3PR0301MB0898; 31:jPVOG7T0d0yom2yN17WyYhP71/qVSSkkasXZGgHonMlTLOP2fpYS5pRkVIvr03IXCi6pa9gVHVl+dlD4IgAo+2gwhwXVoDCVc26boWgKsELmMnz98aJw+kyH5tL+yqj623B+umKb6xrHi0TnZyQG25+RCGqoboT5rp7bXPePwBYvyRgJNkdmvcpBzPk8q6kihVYYRQBFz3MNzVUf7lXN3YbpWdgEqMBr69qSEnpDKfpV0VQiyU2M9XFF5Gy39j9f X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(601004)(2401047)(5005006)(13017025)(13015025)(13024025)(13023025)(13018025)(8121501046)(3002001)(93006095)(93001095)(10201501046)(6055026)(6096035)(20161123561025)(20161123563025)(20161123559100)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(20161123556025)(20161123565025); SRVR:BN3PR0301MB0898; BCL:0; PCL:0; RULEID:(400006); SRVR:BN3PR0301MB0898; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR0301MB0898; 4:QbWQbOWTtSogPQ9Hdq5VKszDDRFP0Amiaj1IP8Sb?= =?us-ascii?Q?zuoV+pDThAwoJR9ZRdV3rWLumNen1ruI8peJylAnirdaNjwL/Sr5VLjGvyNe?= =?us-ascii?Q?OAewsH46+yIDbdNGNDljs65W2FK9Bsu/fp6CNVznE2G0nQicyk8JMLprvegT?= =?us-ascii?Q?35rrXHB6+gxva0zzPA15/0FfNCGDKIl6wNRasaipVvciOLAg0Fl5ebYEtqYA?= =?us-ascii?Q?OFG+emrDZVQaq2bjBP0mmGLZfg7jOmhjlUTP4HqnxMyKBh6a2CqtdZLo+8DE?= =?us-ascii?Q?qKOU13ThB9dO+fCg94lwAxMyk1nLV7M4MBTgzKY36JZslnxbi6czMOV75HD8?= =?us-ascii?Q?r4HI+vhjKkYQwvU1Cs823eNjujC5LdUMv0bBuyLq8JZVv/vhQYj1fQp+n4XE?= =?us-ascii?Q?8AQOmNuiAkP+9fVRkbIRORrOkOQgJBq1iRRgfX5mJT2xqsRJmFAKcKY829cb?= =?us-ascii?Q?X3x9zGZDKgpo5KEzjQNp2LEuTiPYq30ECaInO7d24vzGGVc7AogJO/o2ibLT?= =?us-ascii?Q?kswEkJJeaIQt87mufBpS2Ut3KpSzg9HM6Aye5lxAQRwS4BiOMQGep0oaFtJv?= =?us-ascii?Q?FGdPpsdUM42zKrgwqRUNcNILXWEN3xnSHmyumsFseE2L3r1TET5MjeXN/qLf?= =?us-ascii?Q?IJ14Wo6yVrQg15EqhgnM0uhb83B90NdaMAKsTBybsZRFIf9+lrv1GW6yPFxu?= =?us-ascii?Q?tEWK2XP2bwgveFUSkTIEIgOf/ljbbvrAoOXpgupIiwhjfhVhp5QPy6CsIkY2?= =?us-ascii?Q?YjI4T7wXYi/aUQbV9LSlhMkmONjJH/Ir9f/EMIjKN+yzj889W97N7KlB8fm+?= =?us-ascii?Q?VfLnNkzcJJTgAi/eMr534OBpv6fV6iK0PEMnSWvn4CvNshwEbsstTbveFQLk?= =?us-ascii?Q?TlAJmmaMNmmQFoS2mrgyOrZzGGyFnNA4/S9rG2ymGv1ws397nTGBES7dEBRB?= =?us-ascii?Q?JvFoK21L5G2hvu0U2F/xeLv+pXuLtqudDiAsjvamBg=3D=3D?= X-Forefront-PRVS: 031257FE13 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR0301MB0898; 23:NXj5SO89KrkB8Lqqxfh9ohiM7xqmq9Dumi6eqhn?= =?us-ascii?Q?qiyUHwKlxCH2srKvCJE5vk+ABFznSngnkuB3AaY8dKiHQ/6eBMCojL/R91Y5?= =?us-ascii?Q?7oXdxxxxA/6Gh6C4r58JBJv0tchmkoy9itV2qxaM+wHsssNFOFYVWlW0w8ZF?= =?us-ascii?Q?9dFIoMJfeg00jmFMkJjHHjCGrC47jM9TF2spjXC2qTWjqaVxCXo8KSJUcRhQ?= =?us-ascii?Q?Wq00+S4TLCsRcCuKHWlTteI6lpgCbrTRMSQBrGssIR5P9j5r3kSPr24S1Q86?= =?us-ascii?Q?Ff/LLDiBBjrjmfBnE45HDTcuKeMNC2r9rp0+Q8OQoh/CUyT1wU2yDOVrzDCB?= =?us-ascii?Q?Fw9w9sxNyvucSSiD1unB4TsFEzqXH/AUIIk8Xl8yYiaHwbOSZVzAvZg9HQ3s?= =?us-ascii?Q?quHrlBSDnINXmVTePlNNgo4H7mc6tQSqQZmrtOVhi7NiImGL2PUDtXxenlhh?= =?us-ascii?Q?Jz/DJ3H3A8k6yevvoPIUEKC9FTiDqwtYjQqU1NUTzqyY/flzozrgCdX1pnND?= =?us-ascii?Q?2QdoJmk8j1Mc9XYTqCNnglF7Bq4jqriGDL2cSM91Xg8UZ3vGEUV+8SOEwgUr?= =?us-ascii?Q?gmL3F40iuSFtPWEFyHDkdUqRBTgy1VjggRkZ/msHdRO1SaIoNIaRAZoaAY6t?= =?us-ascii?Q?x6O+ygK8gLDCKAJmXv7QCW+tJDVYbrim/fwLdunOGxcbojtWfuekbqQMnw37?= =?us-ascii?Q?3S0QzX15AAGGhfDKT4zrFJaO/c9bYuCNO4GAAEr8dGIg2WSeIB/mhuQ2aVgt?= =?us-ascii?Q?m9x2esjGR6pX6hRLlwaTQvsBkEvTONGxNqS6QJk7p7Cw1URt9FQ2rbwNwoL6?= =?us-ascii?Q?4tIhDbTVUVcUoo2fLr5OwHHPwU/yQIofsEgrwO2QCjtV5lGal4w/l0AodBPH?= =?us-ascii?Q?KUgvBSB01zo5gywv0FgpTSj/d35jVdUNvlgwP3ByTX/kG0/CFP+iae5codWC?= =?us-ascii?Q?SDFxrLu/49cf4Cq3pL+FD5fR/lIEgkzPkTStZCzNdVeRgChEs4611VzxaRhW?= =?us-ascii?Q?rFR53uL9QHHTcSuY0hsTvxOtpqnLxJ27sOg+BL893k5i/M6z/zaeMdI1T6Gj?= =?us-ascii?Q?vW1fGWEJFtC9MbLbvVNEdkhlzEvnpl4Znb9nAivRqTvWNvK12eeu0unRgOxT?= =?us-ascii?Q?WDaPzry8tXzoUYlgAsS36xQwipnmizREuw516Q/LGqxHJHTQjN7Z/DZyZbjj?= =?us-ascii?Q?2ocoAS3T8O/RBf13wXYnHjcc+B3bZcw+eIhU2swJ+moGD/nAGIGF72N9M8P4?= =?us-ascii?Q?HdBUR90zMQzYh57hsVXo=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR0301MB0898; 6:1voRD8SSZRHzJyqqrLPfq9LSydPfC1T8l0pE7iaQZ3F9dhTw4/iw8NSSmzEMKAIe+OV3NbubNGz44Y+pOU8OANcdRRGANBxSM/8X7QsdrewXJLaq5g5H9Ynbp+GfAKgPlEnkdbUXxNSn08PuX0JgKY2eWR769rqhQm51eYVNHjcQb3i+hvd0J4Euf3nLuSlWmKFiOudPVS9zjp+P/qkyCA4n09NjY1lprSYrpU0WlT2db7Zcl6Q7Jc4iR8ts11hsogj6zoDn0dUIwua6d72BZheT4qfQ6bz2jT7z50P5KFRTaumhZtnXMKVIqtVZhNuwQ35K0bCPolzIMjhFyhMaxlxKu0DGRLeF8Z9xj0M/j/mjTT2fauRyBLK/hbpnFkeahiIv8nxR3hhQlxgOiSTSzg6pCxdJePLkUgdnutL0xvk0BKx+SfWW3ySO2GwK3/RfNYNAmQz+6o+23V+Ujk8I6tfyobYtwfyCfYj5Rec8EAYWcdXh3qWpGMH6c/PbEQDlQm8cw7UGbYjcOcFPeELOIg==; 5:cj9ZVR7uKlXSlcIJavHlDpg8kcK5+SxZv0iUe4LRI4ssWzKUVR+yD54VGQMpyCOSnEWjGeRYMx7XbS/DwWhSOsXbt/YU+vSRibyPJPKhxd/cv7trg8Xbb8QTcgmo2z1T4FT8wxkkF7KHsihQwkOwUjUHLGxmEdBK9G38oTYnfhP6EAdyDruRIneZ18+tELZA; 24:pPZd5YUZeNXXcns1T/uwRQb91M2/sC2oAg4ibu7AT5GuDSi5AOEN6Mgu/2hoMk1kaLQWfwaY0z5VT2gWFMxJiPp+/lJR7xyHNI4Jk9/Oo7M= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN3PR0301MB0898; 7:wEjdRIajEQMr0FbgjkO+MAMh51G/2bmMGgkQJBYqSIQDbSDEkqPNqBr8p1JOPLtmjVI/pUhOo8XXhKPl+H/B6YjeZEnvk2o/lhhPzNkw+sw6t9llROatPxsrCMqDXXVnCwMrOGxXZyxxcI5jttd5fnevq2pPPpzDTZ9qZ1GwBlyLXHGRQr1k5ttAxelhxY32vCgw4FlhD4QOqzGvZvc3rLmH5ifAT/JfCJ1hso7Bq7GlIa5bypBDOw19tsGKL+RwP7weThxKXgFNNd6X8j1Lgo8k/yy9s+jdVQ0nQIWNNYPkIZKlUVnaTaHaxqKlzRYoUUxRhVPi48IvOL++H46fQw== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2017 07:05:45.7482 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0301MB0898 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The original implemented debug message does not work for SHARE_MUX_CONF_REG case. This patch fixes it. Cc: Linus Walleij Cc: Shawn Guo Fixes: bf5a530971af ("pinctrl: imx: add VF610 support to imx pinctrl framework") Signed-off-by: Dong Aisheng Acked-by: Shawn Guo --- * no changes --- drivers/pinctrl/freescale/pinctrl-imx.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c index a7ace9e..6882644 100644 --- a/drivers/pinctrl/freescale/pinctrl-imx.c +++ b/drivers/pinctrl/freescale/pinctrl-imx.c @@ -199,11 +199,13 @@ static int imx_pmx_set(struct pinctrl_dev *pctldev, unsigned selector, reg &= ~(0x7 << 20); reg |= (pin->mux_mode << 20); writel(reg, ipctl->base + pin_reg->mux_reg); + dev_dbg(ipctl->dev, "write: offset 0x%x val 0x%x\n", + pin_reg->mux_reg, reg); } else { writel(pin->mux_mode, ipctl->base + pin_reg->mux_reg); + dev_dbg(ipctl->dev, "write: offset 0x%x val 0x%x\n", + pin_reg->mux_reg, pin->mux_mode); } - dev_dbg(ipctl->dev, "write: offset 0x%x val 0x%x\n", - pin_reg->mux_reg, pin->mux_mode); /* * If the select input value begins with 0xff, it's a quirky @@ -405,11 +407,13 @@ static int imx_pinconf_set(struct pinctrl_dev *pctldev, reg &= ~0xffff; reg |= configs[i]; writel(reg, ipctl->base + pin_reg->conf_reg); + dev_dbg(ipctl->dev, "write: offset 0x%x val 0x%x\n", + pin_reg->conf_reg, reg); } else { writel(configs[i], ipctl->base + pin_reg->conf_reg); + dev_dbg(ipctl->dev, "write: offset 0x%x val 0x%lx\n", + pin_reg->conf_reg, configs[i]); } - dev_dbg(ipctl->dev, "write: offset 0x%x val 0x%lx\n", - pin_reg->conf_reg, configs[i]); } /* for each config */ return 0;