[ovs-dev] Fix flake8 check
diff mbox

Message ID 1495166976-16935-1-git-send-email-twilson@redhat.com
State Superseded
Headers show

Commit Message

Terry Wilson May 19, 2017, 4:09 a.m. UTC
Stop occluding the previous definition of filename.

Signed-off-by: Terry Wilson <twilson@redhat.com>
---
 Documentation/conf.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Numan Siddique May 19, 2017, 5:39 a.m. UTC | #1
On Fri, May 19, 2017 at 9:39 AM, Terry Wilson <twilson@redhat.com> wrote:

> Stop occluding the previous definition of filename.
>
> Signed-off-by: Terry Wilson <twilson@redhat.com>
>

Acked-by: Numan Siddique <nusiddiq@redhat.com>



> ---
>  Documentation/conf.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/conf.py b/Documentation/conf.py
> index d70ee6b..62531dd 100644
> --- a/Documentation/conf.py
> +++ b/Documentation/conf.py
> @@ -121,6 +121,6 @@ _man_pages = [
>
>  # Generate list of (path, name, description, [author, ...], section)
>  man_pages = [
> -    ('ref/%s' % filename, filename.split('.', 1)[0],
> -     description, [author], filename.split('.', 1)[1])
> -    for filename, description in _man_pages]
> +    ('ref/%s' % fname, fname.split('.', 1)[0],
> +     description, [author], fname.split('.', 1)[1])
> +    for fname, description in _man_pages]
> --
> 1.8.3.1
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
Marcin Mirecki May 19, 2017, 12:35 p.m. UTC | #2
On Fri, May 19, 2017 at 2:16 PM, Numan Siddique <nusiddiq@redhat.com> wrote:

>
> ---------- Forwarded message ----------
> From: Numan Siddique <nusiddiq@redhat.com>
> Date: Fri, May 19, 2017 at 11:09 AM
> Subject: Re: [ovs-dev] [PATCH] Fix flake8 check
> To: Terry Wilson <twilson@redhat.com>
> Cc: ovs dev <dev@openvswitch.org>
>
>
>
>
> On Fri, May 19, 2017 at 9:39 AM, Terry Wilson <twilson@redhat.com> wrote:
>
>> Stop occluding the previous definition of filename.
>>
>> Signed-off-by: Terry Wilson <twilson@redhat.com>
>>
>
> Acked-by: Numan Siddique <nusiddiq@redhat.com>
>
>
>
>> ---
>>  Documentation/conf.py | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/conf.py b/Documentation/conf.py
>> index d70ee6b..62531dd 100644
>> --- a/Documentation/conf.py
>> +++ b/Documentation/conf.py
>> @@ -121,6 +121,6 @@ _man_pages = [
>>
>>  # Generate list of (path, name, description, [author, ...], section)
>>  man_pages = [
>> -    ('ref/%s' % filename, filename.split('.', 1)[0],
>> -     description, [author], filename.split('.', 1)[1])
>> -    for filename, description in _man_pages]
>> +    ('ref/%s' % fname, fname.split('.', 1)[0],
>> +     description, [author], fname.split('.', 1)[1])
>> +    for fname, description in _man_pages]
>> --
>> 1.8.3.1
>>
>> _______________________________________________
>> dev mailing list
>> dev@openvswitch.org
>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>>
>
>
>
Tested-by: Marcin Mirecki <mmirecki@redhat.com>

<https://www.redhat.com>
Joe Stringer May 19, 2017, 8:36 p.m. UTC | #3
On 19 May 2017 at 05:35, Marcin Mirecki <mmirecki@redhat.com> wrote:
> On Fri, May 19, 2017 at 2:16 PM, Numan Siddique <nusiddiq@redhat.com> wrote:
>
>>
>> ---------- Forwarded message ----------
>> From: Numan Siddique <nusiddiq@redhat.com>
>> Date: Fri, May 19, 2017 at 11:09 AM
>> Subject: Re: [ovs-dev] [PATCH] Fix flake8 check
>> To: Terry Wilson <twilson@redhat.com>
>> Cc: ovs dev <dev@openvswitch.org>
>>
>>
>>
>>
>> On Fri, May 19, 2017 at 9:39 AM, Terry Wilson <twilson@redhat.com> wrote:
>>
>>> Stop occluding the previous definition of filename.
>>>
>>> Signed-off-by: Terry Wilson <twilson@redhat.com>
>>>
>>
>> Acked-by: Numan Siddique <nusiddiq@redhat.com>
>>
>>
>>
>>> ---
>>>  Documentation/conf.py | 6 +++---
>>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/Documentation/conf.py b/Documentation/conf.py
>>> index d70ee6b..62531dd 100644
>>> --- a/Documentation/conf.py
>>> +++ b/Documentation/conf.py
>>> @@ -121,6 +121,6 @@ _man_pages = [
>>>
>>>  # Generate list of (path, name, description, [author, ...], section)
>>>  man_pages = [
>>> -    ('ref/%s' % filename, filename.split('.', 1)[0],
>>> -     description, [author], filename.split('.', 1)[1])
>>> -    for filename, description in _man_pages]
>>> +    ('ref/%s' % fname, fname.split('.', 1)[0],
>>> +     description, [author], fname.split('.', 1)[1])
>>> +    for fname, description in _man_pages]
>>> --
>>> 1.8.3.1
>>>
>>> _______________________________________________
>>> dev mailing list
>>> dev@openvswitch.org
>>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>>>
>>
>>
>>
> Tested-by: Marcin Mirecki <mmirecki@redhat.com>

Thanks all on this, looks like the equivalent patch here was merged to
the same effect:
https://mail.openvswitch.org/pipermail/ovs-dev/2017-May/332669.html

Patch
diff mbox

diff --git a/Documentation/conf.py b/Documentation/conf.py
index d70ee6b..62531dd 100644
--- a/Documentation/conf.py
+++ b/Documentation/conf.py
@@ -121,6 +121,6 @@  _man_pages = [
 
 # Generate list of (path, name, description, [author, ...], section)
 man_pages = [
-    ('ref/%s' % filename, filename.split('.', 1)[0],
-     description, [author], filename.split('.', 1)[1])
-    for filename, description in _man_pages]
+    ('ref/%s' % fname, fname.split('.', 1)[0],
+     description, [author], fname.split('.', 1)[1])
+    for fname, description in _man_pages]