From patchwork Wed Dec 22 16:25:00 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 76431 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 673E5B70A9 for ; Thu, 23 Dec 2010 03:26:12 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754050Ab0LVQZH (ORCPT ); Wed, 22 Dec 2010 11:25:07 -0500 Received: from mail-wy0-f174.google.com ([74.125.82.174]:38109 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753504Ab0LVQZF (ORCPT ); Wed, 22 Dec 2010 11:25:05 -0500 Received: by wyb28 with SMTP id 28so5200849wyb.19 for ; Wed, 22 Dec 2010 08:25:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:cc :in-reply-to:references:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; bh=6g+TGxnDf8PDFXjmqkTV7HYEzA99wfLVq2YJX9/u1CY=; b=iEiufqy1cJN3gacXH4nvdVHERDJ7TRr2zqdGj+giVxdeBi+IVhQUBQlxsOxqZgULKR CBPezLhuKIPDJtYUBo/F0KR52MEVy8dXPerX/1I145Ot9RJPuCvJk8iliL5G0VrK8jVL XCt5wS0WiTKpA6wcexdm4ag0NKpBnPYKrRU20= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; b=NrEYQezgWNgrP59qwL0g1HQd4RwQytpXfF21sOgRfIHiuJgm6G+Mqtxlntl7nodK7k xsQ0hWNjlFTCHe/37lEVYqsRzHkhfNsFxDW3rArcNGAHuAcMl2EiSqV9VuY3RwrHdQDG KXwIWzbVYJKlLkiPebxyhs1gv5QMp5F8MLeco= Received: by 10.216.154.147 with SMTP id h19mr1776501wek.42.1293035103592; Wed, 22 Dec 2010 08:25:03 -0800 (PST) Received: from [10.150.51.215] (gw0.net.jmsp.net [212.23.165.14]) by mx.google.com with ESMTPS id j58sm3219685wes.21.2010.12.22.08.25.01 (version=SSLv3 cipher=RC4-MD5); Wed, 22 Dec 2010 08:25:02 -0800 (PST) Subject: Re: Help: major pppoe regression since 2.6.35 (panic on first ppp conection)? From: Eric Dumazet To: Joel Soete Cc: Jarek Poplawski , Andrew Morton , Linux Kernel , netdev@vger.kernel.org In-Reply-To: <4D122093.6060900@scarlet.be> References: <20101222110021.GA8985@ff.dom.local> <4D122093.6060900@scarlet.be> Date: Wed, 22 Dec 2010 17:25:00 +0100 Message-ID: <1293035100.3027.247.camel@edumazet-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Le mercredi 22 décembre 2010 à 17:00 +0100, Joel Soete a écrit : > Hello Jarek, > > Nice to read you :<) > > On 12/22/2010 12:00 PM, Jarek Poplawski wrote: > > On 2010-12-22 09:22, Andrew Morton wrote: > >> (cc netdev) > >> > >> The bug is still present in 2.6.37-rc6. > >> > >> On Sat, 18 Dec 2010 11:33:14 +0000 Joel Soete wrote: > >> > >>> Hello all, > > > > Hi, > > Could you reproduce this bug with a vanilla kernel (without nvidia > > patch)? If so, please include dmesg and .config to the next report. > > > Yes (it was already a vanilla kernel but 2.6.35 with my config, even thought same issue occurs some other distro stock > kernel 2.6.35), but here are some more dmesg with vanilla 2.6.37-rc6 and rc7 (I just added your debugging patch > I found here, just because if I don't do it kernel is panicing immediately without letting any chance to capture dmesg (and > unfortunately I don't have any more chance to grab panic messages from serial console: no more rs232 on latest office laptop :<) > > So you will find here attached personal config files of 2 kernels and respective dmesg. > > If ever you need more details, don't hesitate to ask me. > > Thanks a lot, > J. Something overwrites nr_frags in skb_shinfo(skb) As skb_shinfo follows head portion of an skb, something overflows skb head Please try adding some room like in following patch ? --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index e6ba898..adf2834 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -187,6 +187,7 @@ enum { * the end of the header data, ie. at skb->end. */ struct skb_shared_info { + char filler[64]; unsigned short nr_frags; unsigned short gso_size; /* Warning: this field is not always filled in (UFO)! */