Patchwork [U-Boot] cfi_flash: avoid flash_verbose when possible

login
register
mail settings
Submitter Mike Frysinger
Date Dec. 22, 2010, 2:41 p.m.
Message ID <1293028873-16231-1-git-send-email-vapier@gentoo.org>
Download mbox | patch
Permalink /patch/76412/
State Accepted
Headers show

Comments

Mike Frysinger - Dec. 22, 2010, 2:41 p.m.
The flash_verbose logic is only used by the CFI MTD layer, so if we aren't
using that, disable the logic completely.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 drivers/mtd/cfi_flash.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
Wolfgang Denk - Jan. 9, 2011, 5:05 p.m.
Dear Mike Frysinger,

In message <1293028873-16231-1-git-send-email-vapier@gentoo.org> you wrote:
> The flash_verbose logic is only used by the CFI MTD layer, so if we aren't
> using that, disable the logic completely.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  drivers/mtd/cfi_flash.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)

Applied, thanks.

Stefan, this is somewhat global and looks simple enough - hope this is
OK with you.

Best regards,

Wolfgang Denk
Stefan Roese - Jan. 10, 2011, 11:25 a.m.
Hi Wolfgang,

On Sunday 09 January 2011 18:05:42 Wolfgang Denk wrote:
> > The flash_verbose logic is only used by the CFI MTD layer, so if we
> > aren't using that, disable the logic completely.
> > 
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> > ---
> > 
> >  drivers/mtd/cfi_flash.c |    6 ++++++
> >  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> Applied, thanks.
> 
> Stefan, this is somewhat global and looks simple enough - hope this is
> OK with you.

No problem at all. Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office@denx.de

Patch

diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c
index 39c235e..b05264b 100644
--- a/drivers/mtd/cfi_flash.c
+++ b/drivers/mtd/cfi_flash.c
@@ -63,7 +63,11 @@ 
  */
 
 static uint flash_offset_cfi[2] = { FLASH_OFFSET_CFI, FLASH_OFFSET_CFI_ALT };
+#ifdef CONFIG_FLASH_CFI_MTD
 static uint flash_verbose = 1;
+#else
+#define flash_verbose 1
+#endif
 
 flash_info_t flash_info[CFI_MAX_FLASH_BANKS];	/* FLASH chips info */
 
@@ -2016,10 +2020,12 @@  ulong flash_get_size (phys_addr_t base, int banknum)
 	return (info->size);
 }
 
+#ifdef CONFIG_FLASH_CFI_MTD
 void flash_set_verbose(uint v)
 {
 	flash_verbose = v;
 }
+#endif
 
 /*-----------------------------------------------------------------------
  */