diff mbox

[kteam-tools] create-release-tracker: adds prefix for cycle tag

Message ID 20170518152613.8924-1-kleber.souza@canonical.com
State New
Headers show

Commit Message

Kleber Sacilotto de Souza May 18, 2017, 3:26 p.m. UTC
Adds the 'kernel-sru-cycle-' prefix to the cycle tag parameter
so it behaves the same as 'start-sru-cycle'.

Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
---
 stable/create-release-tracker | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Thadeu Lima de Souza Cascardo May 18, 2017, 4:03 p.m. UTC | #1
On Thu, May 18, 2017 at 05:26:13PM +0200, Kleber Sacilotto de Souza wrote:
> Adds the 'kernel-sru-cycle-' prefix to the cycle tag parameter
> so it behaves the same as 'start-sru-cycle'.
> 
> Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
> ---
>  stable/create-release-tracker | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/stable/create-release-tracker b/stable/create-release-tracker
> index cb1abefd..abc97b5f 100755
> --- a/stable/create-release-tracker
> +++ b/stable/create-release-tracker
> @@ -72,7 +72,7 @@ class CreateTrackingBug():
>                            private=self.args.private)
>  
>              if self.args.cycle is not None:
> -                bug.tags.append(self.args.cycle)
> +                bug.tags.append('kernel-sru-cycle-' + self.args.cycle)
>  
>              # -------------------------------------------------------------------------------------
>              # C H A N G E L O G   W O R K
> @@ -122,7 +122,7 @@ if __name__ == '__main__':
>      parser.add_argument('--private', action='store_true', default=False, help='The bug will be private and not everyone will have access.')
>      parser.add_argument('--staging', action='store_true', default=False, help='Use the staging LP server to create the bug. This is just for testing and will go away when the staging database is reset.')
>      parser.add_argument('--master_bug', default=None, help='If you are running this from a derivative or backport branch, you should use this option to specify the number of the tracking bug for the master branch release where this was rebased on.')
> -    parser.add_argument('--cycle', default=None, help='The sru cycle tag to be applied to the bug that is created.')
> +    parser.add_argument('--cycle', default=None, help='The sru cycle tag to be applied to the bug that is created (e.g. \'2017.04.04-1\').')
>  
>      args = parser.parse_args()
>  
> -- 
> 2.11.0

+1 for the help option, thanks!

Acked-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
Colin Ian King May 19, 2017, 12:38 p.m. UTC | #2
On 18/05/17 16:26, Kleber Sacilotto de Souza wrote:
> Adds the 'kernel-sru-cycle-' prefix to the cycle tag parameter
> so it behaves the same as 'start-sru-cycle'.
> 
> Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
> ---
>  stable/create-release-tracker | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/stable/create-release-tracker b/stable/create-release-tracker
> index cb1abefd..abc97b5f 100755
> --- a/stable/create-release-tracker
> +++ b/stable/create-release-tracker
> @@ -72,7 +72,7 @@ class CreateTrackingBug():
>                            private=self.args.private)
>  
>              if self.args.cycle is not None:
> -                bug.tags.append(self.args.cycle)
> +                bug.tags.append('kernel-sru-cycle-' + self.args.cycle)
>  
>              # -------------------------------------------------------------------------------------
>              # C H A N G E L O G   W O R K
> @@ -122,7 +122,7 @@ if __name__ == '__main__':
>      parser.add_argument('--private', action='store_true', default=False, help='The bug will be private and not everyone will have access.')
>      parser.add_argument('--staging', action='store_true', default=False, help='Use the staging LP server to create the bug. This is just for testing and will go away when the staging database is reset.')
>      parser.add_argument('--master_bug', default=None, help='If you are running this from a derivative or backport branch, you should use this option to specify the number of the tracking bug for the master branch release where this was rebased on.')
> -    parser.add_argument('--cycle', default=None, help='The sru cycle tag to be applied to the bug that is created.')
> +    parser.add_argument('--cycle', default=None, help='The sru cycle tag to be applied to the bug that is created (e.g. \'2017.04.04-1\').')
>  
>      args = parser.parse_args()
>  
> 
Looks fine to me

Acked-by: Colin Ian King <colin.king@canonical.com>
Kleber Sacilotto de Souza May 23, 2017, 2:47 p.m. UTC | #3

diff mbox

Patch

diff --git a/stable/create-release-tracker b/stable/create-release-tracker
index cb1abefd..abc97b5f 100755
--- a/stable/create-release-tracker
+++ b/stable/create-release-tracker
@@ -72,7 +72,7 @@  class CreateTrackingBug():
                           private=self.args.private)
 
             if self.args.cycle is not None:
-                bug.tags.append(self.args.cycle)
+                bug.tags.append('kernel-sru-cycle-' + self.args.cycle)
 
             # -------------------------------------------------------------------------------------
             # C H A N G E L O G   W O R K
@@ -122,7 +122,7 @@  if __name__ == '__main__':
     parser.add_argument('--private', action='store_true', default=False, help='The bug will be private and not everyone will have access.')
     parser.add_argument('--staging', action='store_true', default=False, help='Use the staging LP server to create the bug. This is just for testing and will go away when the staging database is reset.')
     parser.add_argument('--master_bug', default=None, help='If you are running this from a derivative or backport branch, you should use this option to specify the number of the tracking bug for the master branch release where this was rebased on.')
-    parser.add_argument('--cycle', default=None, help='The sru cycle tag to be applied to the bug that is created.')
+    parser.add_argument('--cycle', default=None, help='The sru cycle tag to be applied to the bug that is created (e.g. \'2017.04.04-1\').')
 
     args = parser.parse_args()