| Message ID | 1495112495-25086-2-git-send-email-geert+renesas@glider.be |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
Hi Geert, Thank you for the patch. On Thursday 18 May 2017 15:01:35 Geert Uytterhoeven wrote: > EPROBE_DEFER is not an error, hence printing an error message like > > sh-eth ee700000.ethernet: failed to initialise MDIO > > may confuse the user. > > To fix this, suppress the error message in case of probe deferral. > While at it, shorten the message, and add the actual error code. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/net/ethernet/renesas/sh_eth.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/renesas/sh_eth.c > b/drivers/net/ethernet/renesas/sh_eth.c index > c85222b02754f5a7..2d686ccf971b1b65 100644 > --- a/drivers/net/ethernet/renesas/sh_eth.c > +++ b/drivers/net/ethernet/renesas/sh_eth.c > @@ -3220,7 +3220,8 @@ static int sh_eth_drv_probe(struct platform_device > *pdev) /* MDIO bus init */ > ret = sh_mdio_init(mdp, pd); > if (ret) { > - dev_err(&pdev->dev, "failed to initialise MDIO\n"); > + if (ret != -EPROBE_DEFER) > + dev_err(&pdev->dev, "MDIO init failed: %d\n", ret); > goto out_release; > }
From: Geert Uytterhoeven <geert+renesas@glider.be> Date: Thu, 18 May 2017 15:01:35 +0200 > EPROBE_DEFER is not an error, hence printing an error message like > > sh-eth ee700000.ethernet: failed to initialise MDIO > > may confuse the user. > > To fix this, suppress the error message in case of probe deferral. > While at it, shorten the message, and add the actual error code. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Applied.
On 05/18/2017 04:01 PM, Geert Uytterhoeven wrote: > EPROBE_DEFER is not an error, hence printing an error message like > > sh-eth ee700000.ethernet: failed to initialise MDIO > > may confuse the user. > > To fix this, suppress the error message in case of probe deferral. > While at it, shorten the message, and add the actual error code. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> MBR, Sergei
diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index c85222b02754f5a7..2d686ccf971b1b65 100644 --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c @@ -3220,7 +3220,8 @@ static int sh_eth_drv_probe(struct platform_device *pdev) /* MDIO bus init */ ret = sh_mdio_init(mdp, pd); if (ret) { - dev_err(&pdev->dev, "failed to initialise MDIO\n"); + if (ret != -EPROBE_DEFER) + dev_err(&pdev->dev, "MDIO init failed: %d\n", ret); goto out_release; }
EPROBE_DEFER is not an error, hence printing an error message like sh-eth ee700000.ethernet: failed to initialise MDIO may confuse the user. To fix this, suppress the error message in case of probe deferral. While at it, shorten the message, and add the actual error code. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/net/ethernet/renesas/sh_eth.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)