| Message ID | 1495112495-25086-1-git-send-email-geert+renesas@glider.be |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
Hi Geert, Thank you for the patch. On Thursday 18 May 2017 15:01:34 Geert Uytterhoeven wrote: > The MDIO initialization failure message is printed using the network > device, before it has been registered, leading to: > > (null): failed to initialise MDIO > > Use the platform device instead to fix this: > > sh-eth ee700000.ethernet: failed to initialise MDIO > > Fixes: daacf03f0bbfefee ("sh_eth: Register MDIO bus before registering the > network device") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/net/ethernet/renesas/sh_eth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/renesas/sh_eth.c > b/drivers/net/ethernet/renesas/sh_eth.c index > f68c4db656eda846..c85222b02754f5a7 100644 > --- a/drivers/net/ethernet/renesas/sh_eth.c > +++ b/drivers/net/ethernet/renesas/sh_eth.c > @@ -3220,7 +3220,7 @@ static int sh_eth_drv_probe(struct platform_device > *pdev) /* MDIO bus init */ > ret = sh_mdio_init(mdp, pd); > if (ret) { > - dev_err(&ndev->dev, "failed to initialise MDIO\n"); > + dev_err(&pdev->dev, "failed to initialise MDIO\n"); > goto out_release; > }
From: Geert Uytterhoeven <geert+renesas@glider.be> Date: Thu, 18 May 2017 15:01:34 +0200 > The MDIO initialization failure message is printed using the network > device, before it has been registered, leading to: > > (null): failed to initialise MDIO > > Use the platform device instead to fix this: > > sh-eth ee700000.ethernet: failed to initialise MDIO > > Fixes: daacf03f0bbfefee ("sh_eth: Register MDIO bus before registering the network device") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Applied.
On 05/18/2017 04:01 PM, Geert Uytterhoeven wrote: > The MDIO initialization failure message is printed using the network > device, before it has been registered, leading to: > > (null): failed to initialise MDIO > > Use the platform device instead to fix this: > > sh-eth ee700000.ethernet: failed to initialise MDIO > > Fixes: daacf03f0bbfefee ("sh_eth: Register MDIO bus before registering the network device") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> MBR, Sergei
diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index f68c4db656eda846..c85222b02754f5a7 100644 --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c @@ -3220,7 +3220,7 @@ static int sh_eth_drv_probe(struct platform_device *pdev) /* MDIO bus init */ ret = sh_mdio_init(mdp, pd); if (ret) { - dev_err(&ndev->dev, "failed to initialise MDIO\n"); + dev_err(&pdev->dev, "failed to initialise MDIO\n"); goto out_release; }
The MDIO initialization failure message is printed using the network device, before it has been registered, leading to: (null): failed to initialise MDIO Use the platform device instead to fix this: sh-eth ee700000.ethernet: failed to initialise MDIO Fixes: daacf03f0bbfefee ("sh_eth: Register MDIO bus before registering the network device") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/net/ethernet/renesas/sh_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)