[net] sctp: do not inherit ipv6_{mc|ac|fl}_list from parent

Submitted by Eric Dumazet on May 17, 2017, 2:16 p.m.

Details

Message ID 1495030600.6465.19.camel@edumazet-glaptop3.roam.corp.google.com
State Accepted
Delegated to: David Miller
Headers show

Commit Message

Eric Dumazet May 17, 2017, 2:16 p.m.
From: Eric Dumazet <edumazet@google.com>

SCTP needs fixes similar to 83eaddab4378 ("ipv6/dccp: do not inherit
ipv6_mc_list from parent"), otherwise bad things can happen.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Andrey Konovalov <andreyknvl@google.com>
Tested-by: Andrey Konovalov <andreyknvl@google.com>
---
 net/sctp/ipv6.c |    3 +++
 1 file changed, 3 insertions(+)

Comments

David Miller May 18, 2017, 2:24 p.m.
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 17 May 2017 07:16:40 -0700

> From: Eric Dumazet <edumazet@google.com>
> 
> SCTP needs fixes similar to 83eaddab4378 ("ipv6/dccp: do not inherit
> ipv6_mc_list from parent"), otherwise bad things can happen.
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Andrey Konovalov <andreyknvl@google.com>
> Tested-by: Andrey Konovalov <andreyknvl@google.com>

Applied and queued up for -stable, thanks.

Patch hide | download patch | download mbox

diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c
index 142b70e959af9142ce35b88749ad2160327c8267..f5b45b8b8b16e6965d24cd79b150828a608c2121 100644
--- a/net/sctp/ipv6.c
+++ b/net/sctp/ipv6.c
@@ -677,6 +677,9 @@  static struct sock *sctp_v6_create_accept_sk(struct sock *sk,
 	newnp = inet6_sk(newsk);
 
 	memcpy(newnp, np, sizeof(struct ipv6_pinfo));
+	newnp->ipv6_mc_list = NULL;
+	newnp->ipv6_ac_list = NULL;
+	newnp->ipv6_fl_list = NULL;
 
 	rcu_read_lock();
 	opt = rcu_dereference(np->opt);