diff mbox

[ovs-dev] datapath-windows: Fix alignment in actions

Message ID 20170517125648.14116-1-aserdean@cloudbasesolutions.com
State Accepted
Headers show

Commit Message

Alin Serdean May 17, 2017, 12:57 p.m. UTC 
Found by inspection.

Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
---
 datapath-windows/ovsext/Actions.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

Comments

Gurucharan Shetty May 23, 2017, 10:26 p.m. UTC | #1 
On 17 May 2017 at 05:57, Alin Serdean <aserdean@cloudbasesolutions.com>
wrote:

> Found by inspection.
>
> Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
>

Thanks, applied!



> ---
>  datapath-windows/ovsext/Actions.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/datapath-windows/ovsext/Actions.c b/datapath-windows/ovsext/
> Actions.c
> index e2eae9a..ebfb8a3 100644
> --- a/datapath-windows/ovsext/Actions.c
> +++ b/datapath-windows/ovsext/Actions.c
> @@ -2035,18 +2035,18 @@ OvsDoExecuteActions(POVS_SWITCH_CONTEXT
> switchContext,
>                  }
>                  goto dropit;
>              } else if (oldNbl != ovsFwdCtx.curNbl) {
> -               /*
> -                * OvsIpv4Reassemble consumes the original NBL and creates
> a
> -                * new one and assigns it to the curNbl of ovsFwdCtx.
> -                */
> -               OvsInitForwardingCtx(&ovsFwdCtx,
> -                                    ovsFwdCtx.switchContext,
> -                                    ovsFwdCtx.curNbl,
> -                                    ovsFwdCtx.srcVportNo,
> -                                    ovsFwdCtx.sendFlags,
> -                                    NET_BUFFER_LIST_SWITCH_
> FORWARDING_DETAIL(ovsFwdCtx.curNbl),
> -                                    ovsFwdCtx.completionList,
> -                                    &ovsFwdCtx.layers, FALSE);
> +                /*
> +                 * OvsIpv4Reassemble consumes the original NBL and
> creates a
> +                 * new one and assigns it to the curNbl of ovsFwdCtx.
> +                 */
> +                OvsInitForwardingCtx(&ovsFwdCtx,
> +                                     ovsFwdCtx.switchContext,
> +                                     ovsFwdCtx.curNbl,
> +                                     ovsFwdCtx.srcVportNo,
> +                                     ovsFwdCtx.sendFlags,
> +                                     NET_BUFFER_LIST_SWITCH_
> FORWARDING_DETAIL(ovsFwdCtx.curNbl),
> +                                     ovsFwdCtx.completionList,
> +                                     &ovsFwdCtx.layers, FALSE);
>              }
>              break;
>          }
> --
> 2.10.2.windows.1
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
diff mbox

Patch

diff --git a/datapath-windows/ovsext/Actions.c b/datapath-windows/ovsext/Actions.c
index e2eae9a..ebfb8a3 100644
--- a/datapath-windows/ovsext/Actions.c
+++ b/datapath-windows/ovsext/Actions.c
@@ -2035,18 +2035,18 @@  OvsDoExecuteActions(POVS_SWITCH_CONTEXT switchContext,
                 }
                 goto dropit;
             } else if (oldNbl != ovsFwdCtx.curNbl) {
-               /*
-                * OvsIpv4Reassemble consumes the original NBL and creates a
-                * new one and assigns it to the curNbl of ovsFwdCtx.
-                */
-               OvsInitForwardingCtx(&ovsFwdCtx,
-                                    ovsFwdCtx.switchContext,
-                                    ovsFwdCtx.curNbl,
-                                    ovsFwdCtx.srcVportNo,
-                                    ovsFwdCtx.sendFlags,
-                                    NET_BUFFER_LIST_SWITCH_FORWARDING_DETAIL(ovsFwdCtx.curNbl),
-                                    ovsFwdCtx.completionList,
-                                    &ovsFwdCtx.layers, FALSE);
+                /*
+                 * OvsIpv4Reassemble consumes the original NBL and creates a
+                 * new one and assigns it to the curNbl of ovsFwdCtx.
+                 */
+                OvsInitForwardingCtx(&ovsFwdCtx,
+                                     ovsFwdCtx.switchContext,
+                                     ovsFwdCtx.curNbl,
+                                     ovsFwdCtx.srcVportNo,
+                                     ovsFwdCtx.sendFlags,
+                                     NET_BUFFER_LIST_SWITCH_FORWARDING_DETAIL(ovsFwdCtx.curNbl),
+                                     ovsFwdCtx.completionList,
+                                     &ovsFwdCtx.layers, FALSE);
             }
             break;
         }