Message ID | 20170517124042.1430-1-stefanha@redhat.com |
---|---|
State | New |
Headers | show |
Stefan Hajnoczi <stefanha@redhat.com> writes: > The scripts/qemu-gdb.py file is not easily discoverable. Add a .gdbinit > file so GDB either loads qemu-gdb.py automatically or prints a message > informing the user how to enable them (some systems disable ./.gdbinit > loading for security reasons). > > Symlink .gdbinit and the scripts directory in order to make out-of-tree > builds work. The scripts directory is used to find the qemu-gdb.py file > specified by a relative path in .gdbinit. > > Suggested-by: Eric Blake <eblake@redhat.com> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: Alex Bennée <alex.bennee@linaro.org> > --- > v2: > * Support out-of-tree builds [Daniel, Markus] > > configure | 1 + > .gdbinit | 8 ++++++++ > 2 files changed, 9 insertions(+) > create mode 100644 .gdbinit > > diff --git a/configure b/configure > index 57b5ae6..04f7272 100755 > --- a/configure > +++ b/configure > @@ -6382,6 +6382,7 @@ FILES="$FILES pc-bios/spapr-rtas/Makefile" > FILES="$FILES pc-bios/s390-ccw/Makefile" > FILES="$FILES roms/seabios/Makefile roms/vgabios/Makefile" > FILES="$FILES pc-bios/qemu-icon.bmp" > +FILES="$FILES .gdbinit scripts" # scripts needed by relative path in .gdbinit > for bios_file in \ > $source_path/pc-bios/*.bin \ > $source_path/pc-bios/*.lid \ > diff --git a/.gdbinit b/.gdbinit > new file mode 100644 > index 0000000..9d322fc > --- /dev/null > +++ b/.gdbinit > @@ -0,0 +1,8 @@ > +# GDB may have ./.gdbinit loading disabled by default. In that case you can > +# follow the instructions it prints. They boil down to adding the following to > +# your home directory's ~/.gdbinit file: > +# > +# add-auto-load-safe-path /path/to/qemu/.gdbinit > + > +# Load QEMU-specific sub-commands and settings > +source scripts/qemu-gdb.py -- Alex Bennée
On 05/17/2017 07:40 AM, Stefan Hajnoczi wrote: > The scripts/qemu-gdb.py file is not easily discoverable. Add a .gdbinit > file so GDB either loads qemu-gdb.py automatically or prints a message > informing the user how to enable them (some systems disable ./.gdbinit > loading for security reasons). > > Symlink .gdbinit and the scripts directory in order to make out-of-tree > builds work. The scripts directory is used to find the qemu-gdb.py file > specified by a relative path in .gdbinit. > > Suggested-by: Eric Blake <eblake@redhat.com> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> > --- > v2: > * Support out-of-tree builds [Daniel, Markus] Tested-by: Eric Blake <eblake@redhat.com>
On 05/17/2017 09:40 AM, Stefan Hajnoczi wrote: > The scripts/qemu-gdb.py file is not easily discoverable. Add a .gdbinit > file so GDB either loads qemu-gdb.py automatically or prints a message > informing the user how to enable them (some systems disable ./.gdbinit > loading for security reasons). > > Symlink .gdbinit and the scripts directory in order to make out-of-tree > builds work. The scripts directory is used to find the qemu-gdb.py file > specified by a relative path in .gdbinit. > > Suggested-by: Eric Blake <eblake@redhat.com> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > v2: > * Support out-of-tree builds [Daniel, Markus] > > configure | 1 + > .gdbinit | 8 ++++++++ > 2 files changed, 9 insertions(+) > create mode 100644 .gdbinit > > diff --git a/configure b/configure > index 57b5ae6..04f7272 100755 > --- a/configure > +++ b/configure > @@ -6382,6 +6382,7 @@ FILES="$FILES pc-bios/spapr-rtas/Makefile" > FILES="$FILES pc-bios/s390-ccw/Makefile" > FILES="$FILES roms/seabios/Makefile roms/vgabios/Makefile" > FILES="$FILES pc-bios/qemu-icon.bmp" > +FILES="$FILES .gdbinit scripts" # scripts needed by relative path in .gdbinit > for bios_file in \ > $source_path/pc-bios/*.bin \ > $source_path/pc-bios/*.lid \ > diff --git a/.gdbinit b/.gdbinit > new file mode 100644 > index 0000000..9d322fc > --- /dev/null > +++ b/.gdbinit > @@ -0,0 +1,8 @@ > +# GDB may have ./.gdbinit loading disabled by default. In that case you can > +# follow the instructions it prints. They boil down to adding the following to > +# your home directory's ~/.gdbinit file: > +# > +# add-auto-load-safe-path /path/to/qemu/.gdbinit > + > +# Load QEMU-specific sub-commands and settings > +source scripts/qemu-gdb.py >
On Wed, May 17, 2017 at 01:40:42PM +0100, Stefan Hajnoczi wrote: > The scripts/qemu-gdb.py file is not easily discoverable. Add a .gdbinit > file so GDB either loads qemu-gdb.py automatically or prints a message > informing the user how to enable them (some systems disable ./.gdbinit > loading for security reasons). > > Symlink .gdbinit and the scripts directory in order to make out-of-tree > builds work. The scripts directory is used to find the qemu-gdb.py file > specified by a relative path in .gdbinit. > > Suggested-by: Eric Blake <eblake@redhat.com> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> > --- > v2: > * Support out-of-tree builds [Daniel, Markus] > > configure | 1 + > .gdbinit | 8 ++++++++ > 2 files changed, 9 insertions(+) > create mode 100644 .gdbinit Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan
diff --git a/configure b/configure index 57b5ae6..04f7272 100755 --- a/configure +++ b/configure @@ -6382,6 +6382,7 @@ FILES="$FILES pc-bios/spapr-rtas/Makefile" FILES="$FILES pc-bios/s390-ccw/Makefile" FILES="$FILES roms/seabios/Makefile roms/vgabios/Makefile" FILES="$FILES pc-bios/qemu-icon.bmp" +FILES="$FILES .gdbinit scripts" # scripts needed by relative path in .gdbinit for bios_file in \ $source_path/pc-bios/*.bin \ $source_path/pc-bios/*.lid \ diff --git a/.gdbinit b/.gdbinit new file mode 100644 index 0000000..9d322fc --- /dev/null +++ b/.gdbinit @@ -0,0 +1,8 @@ +# GDB may have ./.gdbinit loading disabled by default. In that case you can +# follow the instructions it prints. They boil down to adding the following to +# your home directory's ~/.gdbinit file: +# +# add-auto-load-safe-path /path/to/qemu/.gdbinit + +# Load QEMU-specific sub-commands and settings +source scripts/qemu-gdb.py
The scripts/qemu-gdb.py file is not easily discoverable. Add a .gdbinit file so GDB either loads qemu-gdb.py automatically or prints a message informing the user how to enable them (some systems disable ./.gdbinit loading for security reasons). Symlink .gdbinit and the scripts directory in order to make out-of-tree builds work. The scripts directory is used to find the qemu-gdb.py file specified by a relative path in .gdbinit. Suggested-by: Eric Blake <eblake@redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> --- v2: * Support out-of-tree builds [Daniel, Markus] configure | 1 + .gdbinit | 8 ++++++++ 2 files changed, 9 insertions(+) create mode 100644 .gdbinit