| Message ID | 1494967531-6463-1-git-send-email-luca@lucaceresoli.net |
|---|---|
| State | Accepted |
| Headers | show |
Hello, On Tue, 16 May 2017 22:45:29 +0200, Luca Ceresoli wrote: > has_broken_links makes it self-explanatory that this is a predicate > function, and that the return value tells whether there _are_ broken > links, not the opposite. > > Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> > --- > support/testing/tests/toolchain/test_external.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Series applied to master. Thanks! Thomas
diff --git a/support/testing/tests/toolchain/test_external.py b/support/testing/tests/toolchain/test_external.py index 1fbf81f8d356..0b15d489db8f 100644 --- a/support/testing/tests/toolchain/test_external.py +++ b/support/testing/tests/toolchain/test_external.py @@ -7,7 +7,7 @@ BR2_TARGET_ROOTFS_CPIO=y # BR2_TARGET_ROOTFS_TAR is not set """ -def check_broken_links(path): +def has_broken_links(path): for root, dirs, files in os.walk(path): for f in files: fpath = os.path.join(root, f) @@ -20,9 +20,9 @@ class TestExternalToolchain(infra.basetest.BRTest): # Check for broken symlinks for d in ["lib", "usr/lib"]: path = os.path.join(self.builddir, "staging", d) - self.assertFalse(check_broken_links(path)) + self.assertFalse(has_broken_links(path)) path = os.path.join(self.builddir, "target", d) - self.assertFalse(check_broken_links(path)) + self.assertFalse(has_broken_links(path)) interp = infra.get_elf_prog_interpreter(self.builddir, self.toolchain_prefix,
has_broken_links makes it self-explanatory that this is a predicate function, and that the return value tells whether there _are_ broken links, not the opposite. Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> --- support/testing/tests/toolchain/test_external.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)