From patchwork Tue May 16 19:34:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Orlando Arias X-Patchwork-Id: 763144 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3wS71G6nZtz9s7j for ; Wed, 17 May 2017 05:34:10 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=knightsucfedu39751.onmicrosoft.com header.i=@knightsucfedu39751.onmicrosoft.com header.b="hMbb5rmx"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750799AbdEPTeK (ORCPT ); Tue, 16 May 2017 15:34:10 -0400 Received: from mail-dm3nam03on0085.outbound.protection.outlook.com ([104.47.41.85]:52741 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750785AbdEPTeJ (ORCPT ); Tue, 16 May 2017 15:34:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=knightsucfedu39751.onmicrosoft.com; s=selector1-knights-ucf-edu; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vVzR0n0yJ254HK4AscmH4se9mEEJ2OuwFLv6u+JqjYM=; b=hMbb5rmxHphdXoQ/9c/37MS1ACSKx+aHp0buq9wgSXPsrU/Yg1dtqc/u7DDlNLH9/exCi4aQmTiK26VQCYC/7DlO2QeRUPDoAkonlzmynFGxdkS5cjlnQicihh28tl9s9i4B6LBB1/KjxWZ8xeEhlYkY5MFsxBt2W8ZIYWBIzhQ= Authentication-Results: davemloft.net; dkim=none (message not signed) header.d=none;davemloft.net; dmarc=none action=none header.from=knights.ucf.edu; Received: from [10.32.196.153] (132.170.212.14) by BN6PR07MB2946.namprd07.prod.outlook.com (10.173.29.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1084.16; Tue, 16 May 2017 19:34:07 +0000 To: sparclinux@vger.kernel.org Cc: "David S. Miller" From: Orlando Arias Subject: [PATCH sparc] sparc: Fix -Wstringop-overflow warning Message-ID: <98e7b774-29c5-b669-1bf6-24c1c3f1409e@knights.ucf.edu> Date: Tue, 16 May 2017 15:34:00 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 X-Originating-IP: [132.170.212.14] X-ClientProxiedBy: DM5PR15CA0012.namprd15.prod.outlook.com (10.173.207.150) To BN6PR07MB2946.namprd07.prod.outlook.com (10.173.29.12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b91db0c3-52ca-40f5-8c89-08d49c9284f3 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:BN6PR07MB2946; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB2946; 3:Lja3ZD24X1kFQs/oT/+l0uWmUiat/aXb1KWkmJWop8Ud5V8nXIjE15pXHp6/27wAav7KtfX44oQJUA/XsZiImq7OsnuPGWmT0sMV1RaV6EvS4ODElZdIWLhO0ynDfEDO40JGuMJ/1l+IoUkSpSuR9j+Lg82sBwoRcXtvbHZDSb31nwPbyireHuRIKsUJKcfAGDJqj9D6C674SiE2PDZeBLHbt8WHOQ4ksl/1Aj5Udsvy6tCk6PUtXc5sfvPbInPh6dnv6KrEhWaXvI17dbV04SsSIVZM+P0OebLUtGE8byMMSZ1lkWz3HWV5VviVYR/kqJtI035oXPJ9rw63TaRgQQ==; 25:dQBC37a9LLaM+OkkSCjpvLIBf+umfZhbeCrsj/NfZeV794ZxvYf47KvS/vOy0xAgCjRVX/ArftZMfOjAFoDbKurxbcaSTlN+jESVegnX0Sea7X6IiuiWcUM9B8X+iyKpgk0n9z6mfjAUnGSSf1XM49r0jsyZCPoASaS8xNA3svKIm0kOc98BIw4jGgwCEJP3hcznDPSZtHy1u/gikYX1BGQ9VjHwfO+ELIzNbV21fzvm17Jg6t0a6PIJgl3i/sz6mixPsRA//tvtkTv/hj8votVhzQG6iXqtxNQcRx+pZa6mIVPNf/SZfEIZx7MbZw2ewa3HXVGrKzSr5qN++7BDCGlpADov9V+ivBrAIofelYkz94nJW5NYN6rltfGsXCePVMZ+LqqMDtl0lnH/KM/j6yqdvpZ2q+sy7A8OyCyiWa488sFTME3zBjiJGhTl0QlS3tN8O+SXLwLdW91DhP0Eg+5yyzcJ8ItjaED5sUu9NDY= X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB2946; 31:JYePmOqQGBsYbFUThbEz8HMA1ymG9tfvjRA2rMeztGyLCCJYwsHYviSi3V3eB69IiNlUJpN+UDd1ALx06dDzFN+KbOybRkg61k7T/bc27Mz6k0OiF4j8SgO73OcAd4KwfjBmNS+6c7qPbUS1g42Vf7dhnxyQIN3VD3yltGlbgZMlwbPouYayc+upiiHfI3zHoLF1h2buY1irEsuL/SYYo/0m2s4su1Qv8VSPWR2YTPW3Uj/4T89cSu5ZimxEgyLgSWfkrF5axIDrx7zx5x0uvQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(22074186197030)(9452136761055)(183786458502308); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(6041248)(20161123558100)(20161123560025)(20161123555025)(20161123562025)(201703131423075)(201702281529075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148); SRVR:BN6PR07MB2946; BCL:0; PCL:0; RULEID:; SRVR:BN6PR07MB2946; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB2946; 4:1k3amPAFKArPSJbqTjKBo/USl3Ch8MBxU5Lswj0oP8vAzL4c5ntmvqb8m75R5VR0Ps/LdwqMTIMFh9tNDRAJ5at/W/o5WLaIvO3VmYrRL++QayrIhV4tmWofso/U5Kcc93bprRAY82fgbyNl34I9oqXNXJ01hHqkNFGA360/Jvjku9LUmFI8AyrGl1X8vfQCA38S5avikU/cdbF5SLZNsz9nDcAa3hfx2SpbdZJfPrWvK5r2VjUK0nY5GVMHWrMUlmfpyyv2fRWFvdimYTDHwzQb446w3miCLHTFYJ9rI4arsL0zrrEMfSorwDl5uZTgqoeng9s0GZi5/VOSz1apTXa1Wjd47H4bXKzJu1BPOvxWjzLyK9mglS/8gy1132m17/pu6XO1oTL1ejhnsv5/uXSPIy3ijnyyOG6dTjQJRir4cfWUeCfLjAbvlXIkT9Oo982RjqJhW6cmNzsM9MaaycdGDY/LbZbNl5Hk0aL7mf/+KX4PHoehYP9tV4QKZ9ed55NNZBNBxT8Tw7SugNupnpGxzVD7jYp+9HeDcUt1YbkTNTBBHsMDgzhctpnqaYC+HCC45lT0PaQND8qIoPjaeWqV9YbYSpnNA0mOkzD/ovxD670u1LAaNYSOk8Vr76wOpcqFNgA0NEGxCnxZuF+lqipQjzj0Eyc1Y+43i2Yp7l2LM5hfTyQqpXZI7eD1BvBUoOxKt++EWLifXPcXg+xWD6a8CCByZKOAx5PSjbePvyKnX2X3lr3gaQQeAV+Ddo3a+juAdvITB7HMg85tLw5hjXG4RR64dHTmn6LwP1Q/nXyis7J2gKnMGguLUNlFnKo5KvMlqkPsOU8mZn2aieQ5gL+mkuh+m6f6/Kr3/e3JqGAbOvbmKn7+GMkjtVQLEWYU4UQ1Ddvgj4Vk1KjAWmzI/PQuX7hHK+Dt3NRvXAQ5sgDA+2cdQHlrOUxiDXKib9KY X-Forefront-PRVS: 03094A4065 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6049001)(6009001)(39450400003)(39410400002)(39840400002)(39400400002)(377424004)(65826007)(81166006)(568964002)(8676002)(6116002)(3846002)(5660300001)(478600001)(53936002)(33646002)(88552002)(305945005)(90366009)(2351001)(6306002)(64126003)(2906002)(2361001)(966005)(77096006)(6486002)(5890100001)(86362001)(84326002)(83506001)(31696002)(66066001)(189998001)(110136004)(4326008)(7736002)(65956001)(31686004)(38730400002)(65806001)(42186005)(6666003)(6916009)(25786009)(4001350100001)(21480400002)(42882006)(50986999)(75432002)(54356999); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR07MB2946; H:[10.32.196.153]; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR07MB2946; 23:bpM6PCnUiadpuZYkKOv7IVNIBnZHfsOd1ivv/Yg26?= =?us-ascii?Q?1VCZd/FLdNPVzIX5hJGtVBl1D/UtSjn/5KC03/O+01Njo1phikOwDy8Ob9IV?= =?us-ascii?Q?6M+N4ft7VLR8izbBZSv0dzgoMRvxmZMJSeDHHjkBO15O6qpkZ0TrECL/v1NQ?= =?us-ascii?Q?q8snGreRG4RnzEssK1x9JGE2IDLUQPTlDVnmkzZf2jIGNOdcQ/rEZ7TSOed9?= =?us-ascii?Q?3y51/123L2c3Gh6y8ffm3HkU4enkIgqjnNoWdv9kw2TVtGk3CQ8Taq9v7gRk?= =?us-ascii?Q?fh2jEKEgEO1ty3YguXp2phTqh7vPv5ZCdX1VF11kOA5EyZcN2cZ1dYcMs4ZV?= =?us-ascii?Q?E6hTefcfotbN178+laOuDQNfSLScYAVa6t+LUecNPYHo8tob31wzpV6B5H1O?= =?us-ascii?Q?7kKcpRCLiOoNdP2Lxn9gLbBdLl9EkS2qaQYdnNQd3XsJolOqDG/NSpDStlY4?= =?us-ascii?Q?Kg0ufdBZlt/P14C4poLLexfOloq908byJRbhpUmHYIqRAMTbE2bkj9oufQ0E?= =?us-ascii?Q?Aof0S+f75FSZZDiV8ELYSRXP38gbLMfC+mS0/8wdnrwSZaMotI1ep4TJp5JG?= =?us-ascii?Q?53JYMHLnFSX0D2RdxIzIITksi23EYtTb6UlZAc+jIqXHG92z2cwGXkj38SoF?= =?us-ascii?Q?GcU4ldgsYvMPJjTTk6OCy4adP4xhQOqOFqSV5jJ6vefAvzu/dOl5GnNPzWp4?= =?us-ascii?Q?ONl9RCVfJDwGvQ1MSgiICA64vShKwF5irQcURipMKDjZyYDbMJdnUBr+m9le?= =?us-ascii?Q?yblML+woluXdD72jtAhTQ9QAFwpbg9nY2XeuKStQbMau2BNS2JFLYpoLgGyx?= =?us-ascii?Q?BzVUGZqHpu9dVAiu5YxyZdz1Dmb0ZvimLNA7BWphuGIcUyJWdNtuW1IgJWXg?= =?us-ascii?Q?Nz8RfJ4AWDTzOGFkfsoVOJuJa79tohVLlGIkmic3BXk5Hww4QPyHoqdYAgUC?= =?us-ascii?Q?xIbSwSPXwzIKM8JxaB5D2b9SX/TNaVESmAtYnfZvH8nPqIS9vse3FZNrgI3q?= =?us-ascii?Q?Bnq6VOyEZVRpPHy6TpqChNQk4lkx2GTadxe/lnWW3Jm6LeXTph95TZvTTfGl?= =?us-ascii?Q?z7nIfXxhmBd/1budKZi7f55e5px4Gn/zQ0rjPXmTL5I30YPwtGmuffaOI//B?= =?us-ascii?Q?Wx1x+M+rFl8bDkYtN5xgfZn1YRKBnbTeJd0A4pythXCREfvHYX3ArNbGdbIF?= =?us-ascii?Q?vOv+in/aFdtRWf2Ha7ewHNQR9RQJUM+Jx7tpHjql7kik46fF3pVnR/x+bbXk?= =?us-ascii?Q?77hsHnoE26LUc0pX/D9YUN7YdIXAwBjSOPwxqsqaBsIR90C4z1isRXmUbAhQ?= =?us-ascii?Q?tT6tpL1mOb1B7Qtijc52pg=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB2946; 6:W0kz2aGHyErnCsDab/kk+FY7xwsHfWCmdVyzaRR283G7Nr4HFtJtCX+8zQscTaFgoOKzFCHounOsUhdSBtmuwsLJt37WqnT79ZTPwAoXvgTKN633estHafGxFlzmtqkFGwAWBDjC/ymPpTyl5a0hJgaZIbYIIvSBNDExaP6uAkrjtcYn8sKjfFq55FCVor+eE+gWapBt9LY6BHuyZS20kLzpqA9+JhmTgPgD6SpR2q9vcpuuH91gWLEr0gxmBfM/3P1LH6AMg0L3GXLm/9gnNVG1WH+wloGcIFJZcwP6MrXD8kzfD36DVCI5HSUu/lEJApXDaFbxHN3+Ahhun3I/VJBZDmJGM66z1XUALuiBOvkM33BvHy2EUUgK2JpD0l/PybybVZY0DOd6CQTFboIKx3fz9bZ6rI/1CvhFSJ7pYPbQZHFqAexUkCZc2GY5D6XgU0jGoe3uTotYEEVw7McnyTYdwvlude/UBBjA3eFE9SQj8mp2RkKkrsT8aePCZgiyWw5xqO0LfvCZXuZ6i6ptYQ==; 5:ZzJxvkHftql0e2v5JaUtOUGFjXT0QrZLKkCB5wOXCjt4juxcVBWLT1GTBXJ2kFfvbQ2eWnENtXt/CMnJHarYyuPmpRVqs2UwHZN7KVtYaiCGPUGDNINKFdFf6QGl/x9ePm9oIqgXa5Bj/EAwKke9TQ==; 24:J7GlDgJuIGqjNvwBBZYE9q4eP2IQDoq+kB6puYMN3K3k4qy9aShEYRfpfoJv2I6DEg6+hliDwRJ+AsymZCKEd5RDnK58XgH44e6o1JVhRYk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB2946; 7:eqW5pIxshYhyz3aiCYNgObmnQIZozmMDD5HJEtIuQ7PBQMh3Zana3m0opMyTx+gRAjMoZMb4flPjT1SmLU5bdcY9OfUO+Kym+Dvhd2SL0M+aI+KafRq3JS6SKXOgxWUO3Ojr53Zlw3i6aaB7LMZ3GpxGwl+6jhFwWypK4pgrvQC+x2b9jvBosWOYz799JDkxnh4ZEzJSYM50Ch+kU2ZA16R3YLnrY2/zyOCR+m+w5wyW99fRD0VQEkhgkIoVO0+x5d8hO6vaKyQWomuoaxrYgA+CZLqGb8ddGAPaFEMlk3k//YFTezXsfMd1G4aKhDDWaS0mncXpZUnQU1SqBURcsA== X-OriginatorOrg: knights.ucf.edu X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2017 19:34:07.2141 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB2946 Sender: sparclinux-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: sparclinux@vger.kernel.org Greetings, GCC 7 introduced the -Wstringop-overflow flag to detect buffer overflows in calls to string handling functions [1][2]. Due to the way ``empty_zero_page'' is declared in arch/sparc/include/setup.h, this causes a warning to trigger at compile time in the function mem_init(), which is subsequently converted to an error. The ensuing patch fixes this issue and aligns the declaration of empty_zero_page to that of other architectures. Thank you. Cheers, Orlando. [1] https://gcc.gnu.org/ml/gcc-patches/2016-10/msg02308.html [2] https://gcc.gnu.org/gcc-7/changes.html Signed-off-by: Orlando Arias -------------------------------------------------------------------------------- diff -rupN linux-4.11.1-pristine/arch/sparc/include/asm/pgtable_32.h linux-4.11.1-modified/arch/sparc/include/asm/pgtable_32.h --- linux-4.11.1-pristine/arch/sparc/include/asm/pgtable_32.h 2017-05-14 08:06:16.000000000 -0400 +++ linux-4.11.1-modified/arch/sparc/include/asm/pgtable_32.h 2017-05-16 14:08:21.220784497 -0400 @@ -91,9 +91,9 @@ extern unsigned long pfn_base; * ZERO_PAGE is a global shared page that is always zero: used * for zero-mapped memory areas etc.. */ -extern unsigned long empty_zero_page; +extern unsigned long empty_zero_page[PAGE_SIZE / sizeof(unsigned long)]; -#define ZERO_PAGE(vaddr) (virt_to_page(&empty_zero_page)) +#define ZERO_PAGE(vaddr) (virt_to_page(empty_zero_page)) /* * In general all page table modifications should use the V8 atomic diff -rupN linux-4.11.1-pristine/arch/sparc/include/asm/setup.h linux-4.11.1-modified/arch/sparc/include/asm/setup.h --- linux-4.11.1-pristine/arch/sparc/include/asm/setup.h 2017-05-14 08:06:16.000000000 -0400 +++ linux-4.11.1-modified/arch/sparc/include/asm/setup.h 2017-05-16 14:05:31.887441581 -0400 @@ -16,7 +16,7 @@ extern char reboot_command[]; */ extern unsigned char boot_cpu_id; -extern unsigned long empty_zero_page; +extern unsigned long empty_zero_page[PAGE_SIZE / sizeof(unsigned long)]; extern int serial_console; static inline int con_is_present(void) diff -rupN linux-4.11.1-pristine/arch/sparc/mm/init_32.c linux-4.11.1-modified/arch/sparc/mm/init_32.c --- linux-4.11.1-pristine/arch/sparc/mm/init_32.c 2017-05-14 08:06:16.000000000 -0400 +++ linux-4.11.1-modified/arch/sparc/mm/init_32.c 2017-05-16 14:06:02.497443313 -0400 @@ -290,7 +290,7 @@ void __init mem_init(void) /* Saves us work later. */ - memset((void *)&empty_zero_page, 0, PAGE_SIZE); + memset((void *)empty_zero_page, 0, PAGE_SIZE); i = last_valid_pfn >> ((20 - PAGE_SHIFT) + 5); i += 1;