| Message ID | 1494948714-15203-1-git-send-email-ckeepax@opensource.wolfsonmicro.com |
|---|---|
| State | New |
| Headers | show |
On Tue, May 16, 2017 at 5:31 PM, Charles Keepax <ckeepax@opensource.wolfsonmicro.com> wrote: > Add new flags to allow users to specify that they are not concerned with > the status of GPIOs whilst in a sleep/low power state. > > Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> Would be nice to have some opinion from the DT maintainers about this but seems all right to me. > +++ b/include/dt-bindings/gpio/gpio.h > @@ -21,6 +21,10 @@ > #define GPIO_LINE_OPEN_SOURCE 0 > #define GPIO_LINE_OPEN_DRAIN 4 > > +/* Bit 3 express GPIO suspend/resume persistence */ > +#define GPIO_SLEEP_MAINTAIN_VALUE 0 > +#define GPIO_SLEEP_MAY_LOOSE_VALUE 8 > + > /* > * Open Drain/Collector is the combination of single-ended open drain interface. > * Open Source/Emitter is the combination of single-ended open source interface. Please move the define below the comment and macros below it, that is using the defines right above... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 23 May 2017, Linus Walleij wrote: > On Tue, May 16, 2017 at 5:31 PM, Charles Keepax > <ckeepax@opensource.wolfsonmicro.com> wrote: > > > Add new flags to allow users to specify that they are not concerned with > > the status of GPIOs whilst in a sleep/low power state. > > > > Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> > > Would be nice to have some opinion from the DT maintainers about > this but seems all right to me. Not sure if it makes a difference, but Rob Acked the bindings already. > > +++ b/include/dt-bindings/gpio/gpio.h > > @@ -21,6 +21,10 @@ > > #define GPIO_LINE_OPEN_SOURCE 0 > > #define GPIO_LINE_OPEN_DRAIN 4 > > > > +/* Bit 3 express GPIO suspend/resume persistence */ > > +#define GPIO_SLEEP_MAINTAIN_VALUE 0 > > +#define GPIO_SLEEP_MAY_LOOSE_VALUE 8 > > + > > /* > > * Open Drain/Collector is the combination of single-ended open drain interface. > > * Open Source/Emitter is the combination of single-ended open source interface. > > Please move the define below the comment and macros below it, > that is using the defines right above... > > Yours, > Linus Walleij
On Tue, May 23, 2017 at 3:51 AM, Lee Jones <lee.jones@linaro.org> wrote: > On Tue, 23 May 2017, Linus Walleij wrote: > >> On Tue, May 16, 2017 at 5:31 PM, Charles Keepax >> <ckeepax@opensource.wolfsonmicro.com> wrote: >> >> > Add new flags to allow users to specify that they are not concerned with >> > the status of GPIOs whilst in a sleep/low power state. >> > >> > Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> >> >> Would be nice to have some opinion from the DT maintainers about >> this but seems all right to me. > > Not sure if it makes a difference, but Rob Acked the bindings already. Seems PW doesn't pick-up header only patches, so I missed this. Acked-by: Rob Herring <robh@kernel.org> Rob -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/dt-bindings/gpio/gpio.h b/include/dt-bindings/gpio/gpio.h index b4f54da..48c28f0 100644 --- a/include/dt-bindings/gpio/gpio.h +++ b/include/dt-bindings/gpio/gpio.h @@ -21,6 +21,10 @@ #define GPIO_LINE_OPEN_SOURCE 0 #define GPIO_LINE_OPEN_DRAIN 4 +/* Bit 3 express GPIO suspend/resume persistence */ +#define GPIO_SLEEP_MAINTAIN_VALUE 0 +#define GPIO_SLEEP_MAY_LOOSE_VALUE 8 + /* * Open Drain/Collector is the combination of single-ended open drain interface. * Open Source/Emitter is the combination of single-ended open source interface.
Add new flags to allow users to specify that they are not concerned with the status of GPIOs whilst in a sleep/low power state. Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> --- include/dt-bindings/gpio/gpio.h | 4 ++++ 1 file changed, 4 insertions(+)