| Message ID | 1494926782-25700-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Tue, 2017-05-16 at 14:56 +0530, Aneesh Kumar K.V wrote: > > +static inline bool __hard_irqs_disabled(void) > +{ > + unsigned long flags = mfmsr(); > + return (flags & MSR_EE) == 0; > +} > + Reading the MSR has a cost. Can't we rely on paca->irq_happened being non-0 ? (If you are paranoid, add a test of msr as well and warn if there's a mismatch ...) Cheers, Ben.
On Tue, 2017-05-16 at 14:56 +0530, Aneesh Kumar K.V wrote: > Add __hard_irqs_disabled() similar to arch_irqs_disabled to check whether irqs > are hard disabled. > > Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> > --- > arch/powerpc/include/asm/hw_irq.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/powerpc/include/asm/hw_irq.h b/arch/powerpc/include/asm/hw_irq.h > index eba60416536e..541bd42f902f 100644 > --- a/arch/powerpc/include/asm/hw_irq.h > +++ b/arch/powerpc/include/asm/hw_irq.h > @@ -88,6 +88,12 @@ static inline bool arch_irqs_disabled(void) > return arch_irqs_disabled_flags(arch_local_save_flags()); > } > > +static inline bool __hard_irqs_disabled(void) > +{ > + unsigned long flags = mfmsr(); > + return (flags & MSR_EE) == 0; I have some patches that ensure MSR_EE is never 0, what are we protecting against - external interrupts, IPI's or something else? I suspect its IPI's Balbir SIngh.
diff --git a/arch/powerpc/include/asm/hw_irq.h b/arch/powerpc/include/asm/hw_irq.h index eba60416536e..541bd42f902f 100644 --- a/arch/powerpc/include/asm/hw_irq.h +++ b/arch/powerpc/include/asm/hw_irq.h @@ -88,6 +88,12 @@ static inline bool arch_irqs_disabled(void) return arch_irqs_disabled_flags(arch_local_save_flags()); } +static inline bool __hard_irqs_disabled(void) +{ + unsigned long flags = mfmsr(); + return (flags & MSR_EE) == 0; +} + #ifdef CONFIG_PPC_BOOK3E #define __hard_irq_enable() asm volatile("wrteei 1" : : : "memory") #define __hard_irq_disable() asm volatile("wrteei 0" : : : "memory") @@ -197,6 +203,7 @@ static inline bool arch_irqs_disabled(void) } #define hard_irq_disable() arch_local_irq_disable() +#define __hard_irqs_disabled() arch_irqs_disabled() static inline bool arch_irq_disabled_regs(struct pt_regs *regs) {
Add __hard_irqs_disabled() similar to arch_irqs_disabled to check whether irqs are hard disabled. Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> --- arch/powerpc/include/asm/hw_irq.h | 7 +++++++ 1 file changed, 7 insertions(+)