Message ID | 20170515141014.25793-1-famz@redhat.com |
---|---|
State | New |
Headers | show |
On 05/15/2017 09:10 AM, Fam Zheng wrote: > Reported by Coverity. > > Signed-off-by: Fam Zheng <famz@redhat.com> > --- > qemu-img.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Eric Blake <eblake@redhat.com>
On 2017-05-15 16:10, Fam Zheng wrote: > Reported by Coverity. > > Signed-off-by: Fam Zheng <famz@redhat.com> > --- > qemu-img.c | 1 + > 1 file changed, 1 insertion(+) Thanks, applied to my block branch: https://github.com/XanClic/qemu/commits/block Max
diff --git a/qemu-img.c b/qemu-img.c index b506839..8b0dfa7 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -294,6 +294,7 @@ static BlockBackend *img_open_opts(const char *optstr, if (qdict_haskey(options, BDRV_OPT_FORCE_SHARE) && !qdict_get_bool(options, BDRV_OPT_FORCE_SHARE)) { error_report("--force-share/-U conflicts with image options"); + QDECREF(options); return NULL; } qdict_put(options, BDRV_OPT_FORCE_SHARE, qbool_from_bool(true));
Reported by Coverity. Signed-off-by: Fam Zheng <famz@redhat.com> --- qemu-img.c | 1 + 1 file changed, 1 insertion(+)