| Message ID | 20170515080244.21345-15-oliver@schinagl.nl |
|---|---|
| State | Changes Requested |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
On Mon, May 15, 2017 at 10:02:30AM +0200, Olliver Schinagl wrote: > Currently, we print that the MAC from the SROM does not match. It can be > many forms of ROM, so lets drop the S. > > Signed-off-by: Olliver Schinagl <oliver@schinagl.nl> > --- > net/eth_legacy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/eth_legacy.c b/net/eth_legacy.c > index 4276058800..800b91c327 100644 > --- a/net/eth_legacy.c > +++ b/net/eth_legacy.c > @@ -146,7 +146,7 @@ int eth_write_hwaddr(struct eth_device *dev, const char *base_name, > memcmp(dev->enetaddr, env_enetaddr, ARP_HLEN)) { > printf("\nWarning: %s MAC addresses don't match:\n", > dev->name); > - printf("Address in SROM is %pM\n", > + printf("Address in ROM is %pM\n", > dev->enetaddr); > printf("Address in environment is %pM\n", > env_enetaddr); We need to add a space in the print then as the output is manually aligned.
Hey Tom, On 15-05-17 14:53, Tom Rini wrote: > On Mon, May 15, 2017 at 10:02:30AM +0200, Olliver Schinagl wrote: >> Currently, we print that the MAC from the SROM does not match. It can be >> many forms of ROM, so lets drop the S. >> >> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl> >> --- >> net/eth_legacy.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/net/eth_legacy.c b/net/eth_legacy.c >> index 4276058800..800b91c327 100644 >> --- a/net/eth_legacy.c >> +++ b/net/eth_legacy.c >> @@ -146,7 +146,7 @@ int eth_write_hwaddr(struct eth_device *dev, const char *base_name, >> memcmp(dev->enetaddr, env_enetaddr, ARP_HLEN)) { >> printf("\nWarning: %s MAC addresses don't match:\n", >> dev->name); >> - printf("Address in SROM is %pM\n", >> + printf("Address in ROM is %pM\n", >> dev->enetaddr); >> printf("Address in environment is %pM\n", >> env_enetaddr); > > We need to add a space in the print then as the output is manually > aligned. > I did not realize, I'll add a space to this one, and a space to the already merged one as well. Olliver
On Mon, May 15, 2017 at 7:53 AM, Tom Rini <trini@konsulko.com> wrote: > On Mon, May 15, 2017 at 10:02:30AM +0200, Olliver Schinagl wrote: >> Currently, we print that the MAC from the SROM does not match. It can be >> many forms of ROM, so lets drop the S. >> >> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl> >> --- >> net/eth_legacy.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/net/eth_legacy.c b/net/eth_legacy.c >> index 4276058800..800b91c327 100644 >> --- a/net/eth_legacy.c >> +++ b/net/eth_legacy.c >> @@ -146,7 +146,7 @@ int eth_write_hwaddr(struct eth_device *dev, const char *base_name, >> memcmp(dev->enetaddr, env_enetaddr, ARP_HLEN)) { >> printf("\nWarning: %s MAC addresses don't match:\n", >> dev->name); >> - printf("Address in SROM is %pM\n", >> + printf("Address in ROM is %pM\n", >> dev->enetaddr); >> printf("Address in environment is %pM\n", >> env_enetaddr); > > We need to add a space in the print then as the output is manually > aligned. Agreed.
diff --git a/net/eth_legacy.c b/net/eth_legacy.c index 4276058800..800b91c327 100644 --- a/net/eth_legacy.c +++ b/net/eth_legacy.c @@ -146,7 +146,7 @@ int eth_write_hwaddr(struct eth_device *dev, const char *base_name, memcmp(dev->enetaddr, env_enetaddr, ARP_HLEN)) { printf("\nWarning: %s MAC addresses don't match:\n", dev->name); - printf("Address in SROM is %pM\n", + printf("Address in ROM is %pM\n", dev->enetaddr); printf("Address in environment is %pM\n", env_enetaddr);
Currently, we print that the MAC from the SROM does not match. It can be many forms of ROM, so lets drop the S. Signed-off-by: Olliver Schinagl <oliver@schinagl.nl> --- net/eth_legacy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)