Patchwork e1000: use pci_config_set_revision()

login
register
mail settings
Submitter Sebastian Herbszt
Date Dec. 20, 2010, 9:31 p.m.
Message ID <1292880715$3178@local>
Download mbox | patch
Permalink /patch/76238/
State New
Headers show

Comments

Sebastian Herbszt - Dec. 20, 2010, 9:31 p.m.
Use pci_config_set_revision().

Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>

Patch

diff --git a/hw/e1000.c b/hw/e1000.c
index af101bd..7bad51a 100644
--- a/hw/e1000.c
+++ b/hw/e1000.c
@@ -1116,7 +1116,7 @@  static int pci_e1000_init(PCIDevice *pci_dev)
     pci_config_set_device_id(pci_conf, E1000_DEVID);
     /* TODO: we have no capabilities, so why is this bit set? */
     pci_set_word(pci_conf + PCI_STATUS, PCI_STATUS_CAP_LIST);
-    pci_conf[PCI_REVISION_ID] = 0x03;
+    pci_config_set_revision(pci_conf, 0x03);
     pci_config_set_class(pci_conf, PCI_CLASS_NETWORK_ETHERNET);
     /* TODO: RST# value should be 0, PCI spec 6.2.4 */
     pci_conf[PCI_CACHE_LINE_SIZE] = 0x10;