| Message ID | 20170515105802.23023-3-sjg@chromium.org |
|---|---|
| State | Accepted |
| Commit | 523f97ac75449e9522ff4a3f138114908220aaee |
| Delegated to: | Tom Rini |
| Headers | show |
On Mon, May 15, 2017 at 04:57:17AM -0600, Simon Glass wrote: > This option is only used in one driver and two boards. It does not seem > worth having the ability to remove this part of the support. > > Drop the option. > > Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-by: Tom Rini <trini@konsulko.com>
Hello Simon, Am 15.05.2017 um 12:57 schrieb Simon Glass: > This option is only used in one driver and two boards. It does not seem > worth having the ability to remove this part of the support. > > Drop the option. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > README | 1 - > drivers/misc/ds4510.c | 8 -------- > include/configs/xpedite517x.h | 1 - > include/configs/xpedite537x.h | 1 - > scripts/config_whitelist.txt | 1 - > 5 files changed, 12 deletions(-) Reviewed-by: Heiko Schocher <hs@denx.de> bye, Heiko > > diff --git a/README b/README > index 2ca0102b57..3c4f0165b1 100644 > --- a/README > +++ b/README > @@ -831,7 +831,6 @@ The following options need to be configured: > CONFIG_CMD_DHCP * DHCP support > CONFIG_CMD_DIAG * Diagnostics > CONFIG_CMD_DS4510 * ds4510 I2C gpio commands > - CONFIG_CMD_DS4510_INFO * ds4510 I2C info command > CONFIG_CMD_DS4510_MEM * ds4510 I2C eeprom/sram commansd > CONFIG_CMD_DS4510_RST * ds4510 I2C rst command > CONFIG_CMD_DTT * Digital Therm and Thermostat > diff --git a/drivers/misc/ds4510.c b/drivers/misc/ds4510.c > index d7c9bd73c8..940e2ce6a0 100644 > --- a/drivers/misc/ds4510.c > +++ b/drivers/misc/ds4510.c > @@ -186,7 +186,6 @@ int ds4510_gpio_read_val(uint8_t chip) > } > > #ifdef CONFIG_CMD_DS4510 > -#ifdef CONFIG_CMD_DS4510_INFO > /* > * Display DS4510 information > */ > @@ -240,7 +239,6 @@ static int ds4510_info(uint8_t chip) > > return 0; > } > -#endif /* CONFIG_CMD_DS4510_INFO */ > > cmd_tbl_t cmd_ds4510[] = { > U_BOOT_CMD_MKENT(device, 3, 0, (void *)DS4510_CMD_DEVICE, "", ""), > @@ -248,9 +246,7 @@ cmd_tbl_t cmd_ds4510[] = { > U_BOOT_CMD_MKENT(output, 4, 0, (void *)DS4510_CMD_OUTPUT, "", ""), > U_BOOT_CMD_MKENT(input, 3, 0, (void *)DS4510_CMD_INPUT, "", ""), > U_BOOT_CMD_MKENT(pullup, 4, 0, (void *)DS4510_CMD_PULLUP, "", ""), > -#ifdef CONFIG_CMD_DS4510_INFO > U_BOOT_CMD_MKENT(info, 2, 0, (void *)DS4510_CMD_INFO, "", ""), > -#endif > #ifdef CONFIG_CMD_DS4510_RST > U_BOOT_CMD_MKENT(rstdelay, 3, 0, (void *)DS4510_CMD_RSTDELAY, "", ""), > #endif > @@ -324,10 +320,8 @@ int do_ds4510(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) > else > tmp &= ~(1 << ul_arg2); > return ds4510_pullup_write(chip, tmp); > -#ifdef CONFIG_CMD_DS4510_INFO > case DS4510_CMD_INFO: > return ds4510_info(chip); > -#endif > #ifdef CONFIG_CMD_DS4510_RST > case DS4510_CMD_RSTDELAY: > return ds4510_rstdelay_write(chip, ul_arg2); > @@ -378,10 +372,8 @@ U_BOOT_CMD( > "ds4510 eeprom/seeprom/sram/gpio access", > "device [dev]\n" > " - show or set current device address\n" > -#ifdef CONFIG_CMD_DS4510_INFO > "ds4510 info\n" > " - display ds4510 info\n" > -#endif > "ds4510 output pin 0|1\n" > " - set pin low or high-Z\n" > "ds4510 input pin\n" > diff --git a/include/configs/xpedite517x.h b/include/configs/xpedite517x.h > index 447fd9557a..dae61b11e4 100644 > --- a/include/configs/xpedite517x.h > +++ b/include/configs/xpedite517x.h > @@ -503,7 +503,6 @@ extern unsigned long get_board_sys_clk(unsigned long dummy); > * Command configuration. > */ > #define CONFIG_CMD_DS4510 > -#define CONFIG_CMD_DS4510_INFO > #define CONFIG_CMD_DTT > #define CONFIG_CMD_EEPROM > #define CONFIG_CMD_IRQ > diff --git a/include/configs/xpedite537x.h b/include/configs/xpedite537x.h > index 48f07b08c0..ce1ff86135 100644 > --- a/include/configs/xpedite537x.h > +++ b/include/configs/xpedite537x.h > @@ -355,7 +355,6 @@ extern unsigned long get_board_ddr_clk(unsigned long dummy); > * Command configuration. > */ > #define CONFIG_CMD_DS4510 > -#define CONFIG_CMD_DS4510_INFO > #define CONFIG_CMD_DTT > #define CONFIG_CMD_EEPROM > #define CONFIG_CMD_JFFS2 > diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt > index 7646bb6842..b4c3d6b311 100644 > --- a/scripts/config_whitelist.txt > +++ b/scripts/config_whitelist.txt > @@ -385,7 +385,6 @@ CONFIG_CMDLINE_EDITING > CONFIG_CMDLINE_PS_SUPPORT > CONFIG_CMDLINE_TAG > CONFIG_CMD_DS4510 > -CONFIG_CMD_DS4510_INFO > CONFIG_CMD_DS4510_MEM > CONFIG_CMD_DS4510_RST > CONFIG_CMD_DTT >
diff --git a/README b/README index 2ca0102b57..3c4f0165b1 100644 --- a/README +++ b/README @@ -831,7 +831,6 @@ The following options need to be configured: CONFIG_CMD_DHCP * DHCP support CONFIG_CMD_DIAG * Diagnostics CONFIG_CMD_DS4510 * ds4510 I2C gpio commands - CONFIG_CMD_DS4510_INFO * ds4510 I2C info command CONFIG_CMD_DS4510_MEM * ds4510 I2C eeprom/sram commansd CONFIG_CMD_DS4510_RST * ds4510 I2C rst command CONFIG_CMD_DTT * Digital Therm and Thermostat diff --git a/drivers/misc/ds4510.c b/drivers/misc/ds4510.c index d7c9bd73c8..940e2ce6a0 100644 --- a/drivers/misc/ds4510.c +++ b/drivers/misc/ds4510.c @@ -186,7 +186,6 @@ int ds4510_gpio_read_val(uint8_t chip) } #ifdef CONFIG_CMD_DS4510 -#ifdef CONFIG_CMD_DS4510_INFO /* * Display DS4510 information */ @@ -240,7 +239,6 @@ static int ds4510_info(uint8_t chip) return 0; } -#endif /* CONFIG_CMD_DS4510_INFO */ cmd_tbl_t cmd_ds4510[] = { U_BOOT_CMD_MKENT(device, 3, 0, (void *)DS4510_CMD_DEVICE, "", ""), @@ -248,9 +246,7 @@ cmd_tbl_t cmd_ds4510[] = { U_BOOT_CMD_MKENT(output, 4, 0, (void *)DS4510_CMD_OUTPUT, "", ""), U_BOOT_CMD_MKENT(input, 3, 0, (void *)DS4510_CMD_INPUT, "", ""), U_BOOT_CMD_MKENT(pullup, 4, 0, (void *)DS4510_CMD_PULLUP, "", ""), -#ifdef CONFIG_CMD_DS4510_INFO U_BOOT_CMD_MKENT(info, 2, 0, (void *)DS4510_CMD_INFO, "", ""), -#endif #ifdef CONFIG_CMD_DS4510_RST U_BOOT_CMD_MKENT(rstdelay, 3, 0, (void *)DS4510_CMD_RSTDELAY, "", ""), #endif @@ -324,10 +320,8 @@ int do_ds4510(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) else tmp &= ~(1 << ul_arg2); return ds4510_pullup_write(chip, tmp); -#ifdef CONFIG_CMD_DS4510_INFO case DS4510_CMD_INFO: return ds4510_info(chip); -#endif #ifdef CONFIG_CMD_DS4510_RST case DS4510_CMD_RSTDELAY: return ds4510_rstdelay_write(chip, ul_arg2); @@ -378,10 +372,8 @@ U_BOOT_CMD( "ds4510 eeprom/seeprom/sram/gpio access", "device [dev]\n" " - show or set current device address\n" -#ifdef CONFIG_CMD_DS4510_INFO "ds4510 info\n" " - display ds4510 info\n" -#endif "ds4510 output pin 0|1\n" " - set pin low or high-Z\n" "ds4510 input pin\n" diff --git a/include/configs/xpedite517x.h b/include/configs/xpedite517x.h index 447fd9557a..dae61b11e4 100644 --- a/include/configs/xpedite517x.h +++ b/include/configs/xpedite517x.h @@ -503,7 +503,6 @@ extern unsigned long get_board_sys_clk(unsigned long dummy); * Command configuration. */ #define CONFIG_CMD_DS4510 -#define CONFIG_CMD_DS4510_INFO #define CONFIG_CMD_DTT #define CONFIG_CMD_EEPROM #define CONFIG_CMD_IRQ diff --git a/include/configs/xpedite537x.h b/include/configs/xpedite537x.h index 48f07b08c0..ce1ff86135 100644 --- a/include/configs/xpedite537x.h +++ b/include/configs/xpedite537x.h @@ -355,7 +355,6 @@ extern unsigned long get_board_ddr_clk(unsigned long dummy); * Command configuration. */ #define CONFIG_CMD_DS4510 -#define CONFIG_CMD_DS4510_INFO #define CONFIG_CMD_DTT #define CONFIG_CMD_EEPROM #define CONFIG_CMD_JFFS2 diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt index 7646bb6842..b4c3d6b311 100644 --- a/scripts/config_whitelist.txt +++ b/scripts/config_whitelist.txt @@ -385,7 +385,6 @@ CONFIG_CMDLINE_EDITING CONFIG_CMDLINE_PS_SUPPORT CONFIG_CMDLINE_TAG CONFIG_CMD_DS4510 -CONFIG_CMD_DS4510_INFO CONFIG_CMD_DS4510_MEM CONFIG_CMD_DS4510_RST CONFIG_CMD_DTT
This option is only used in one driver and two boards. It does not seem worth having the ability to remove this part of the support. Drop the option. Signed-off-by: Simon Glass <sjg@chromium.org> --- README | 1 - drivers/misc/ds4510.c | 8 -------- include/configs/xpedite517x.h | 1 - include/configs/xpedite537x.h | 1 - scripts/config_whitelist.txt | 1 - 5 files changed, 12 deletions(-)