| Message ID | 20170513171009.5219-2-romain.naour@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
Romain, All, On 2017-05-13 19:10 +0200, Romain Naour spake thusly: > Tests are enabled since this has been introduced [1], so keep > them for now. Why don't you want to simply disable tests altogehter, especially since there is an option for that: --disable-test And if we disable tests, then we do not need patch 3/3. Regards, Yann E. MORIN. > bluez_utils needs check tool and check if it's available [2]. > > [1] 06c3e2159686a886e52b2522a47e60c300cfb7f7 > [2] https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/configure.ac?h=4.101#n51 > > Signed-off-by: Romain Naour <romain.naour@gmail.com> > Cc: Yegor Yefremov <yegorslists@googlemail.com> > --- > package/bluez_utils/bluez_utils.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/bluez_utils/bluez_utils.mk b/package/bluez_utils/bluez_utils.mk > index 526804a..256f012 100644 > --- a/package/bluez_utils/bluez_utils.mk > +++ b/package/bluez_utils/bluez_utils.mk > @@ -8,7 +8,7 @@ BLUEZ_UTILS_VERSION = 4.101 > BLUEZ_UTILS_SOURCE = bluez-$(BLUEZ_UTILS_VERSION).tar.xz > BLUEZ_UTILS_SITE = $(BR2_KERNEL_MIRROR)/linux/bluetooth > BLUEZ_UTILS_INSTALL_STAGING = YES > -BLUEZ_UTILS_DEPENDENCIES = host-pkgconf dbus libglib2 > +BLUEZ_UTILS_DEPENDENCIES = host-pkgconf check dbus libglib2 > BLUEZ_UTILS_CONF_OPTS = --enable-test --enable-tools > BLUEZ_UTILS_AUTORECONF = YES > BLUEZ_UTILS_LICENSE = GPL-2.0+, LGPL-2.1+ > -- > 2.9.3 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Hi Yann, Yegor, Le 13/05/2017 à 22:28, Yann E. MORIN a écrit : > Romain, All, > > On 2017-05-13 19:10 +0200, Romain Naour spake thusly: >> Tests are enabled since this has been introduced [1], so keep >> them for now. > > Why don't you want to simply disable tests altogehter, especially since > there is an option for that: > > --disable-test > > And if we disable tests, then we do not need patch 3/3. Indeed, I hesitated to do so because tests are explicitly enabled for some reason. Yegor, do you think that tests can be safely disabled ? Best regards, Romain > > Regards, > Yann E. MORIN. > >> bluez_utils needs check tool and check if it's available [2]. >> >> [1] 06c3e2159686a886e52b2522a47e60c300cfb7f7 >> [2] https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/configure.ac?h=4.101#n51 >> >> Signed-off-by: Romain Naour <romain.naour@gmail.com> >> Cc: Yegor Yefremov <yegorslists@googlemail.com> >> --- >> package/bluez_utils/bluez_utils.mk | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/package/bluez_utils/bluez_utils.mk b/package/bluez_utils/bluez_utils.mk >> index 526804a..256f012 100644 >> --- a/package/bluez_utils/bluez_utils.mk >> +++ b/package/bluez_utils/bluez_utils.mk >> @@ -8,7 +8,7 @@ BLUEZ_UTILS_VERSION = 4.101 >> BLUEZ_UTILS_SOURCE = bluez-$(BLUEZ_UTILS_VERSION).tar.xz >> BLUEZ_UTILS_SITE = $(BR2_KERNEL_MIRROR)/linux/bluetooth >> BLUEZ_UTILS_INSTALL_STAGING = YES >> -BLUEZ_UTILS_DEPENDENCIES = host-pkgconf dbus libglib2 >> +BLUEZ_UTILS_DEPENDENCIES = host-pkgconf check dbus libglib2 >> BLUEZ_UTILS_CONF_OPTS = --enable-test --enable-tools >> BLUEZ_UTILS_AUTORECONF = YES >> BLUEZ_UTILS_LICENSE = GPL-2.0+, LGPL-2.1+ >> -- >> 2.9.3 >> >> _______________________________________________ >> buildroot mailing list >> buildroot@busybox.net >> http://lists.busybox.net/mailman/listinfo/buildroot >
Hello, On Sat, 13 May 2017 19:10:08 +0200, Romain Naour wrote: > Tests are enabled since this has been introduced [1], so keep > them for now. > > bluez_utils needs check tool and check if it's available [2]. > > [1] 06c3e2159686a886e52b2522a47e60c300cfb7f7 > [2] https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/configure.ac?h=4.101#n51 > > Signed-off-by: Romain Naour <romain.naour@gmail.com> > Cc: Yegor Yefremov <yegorslists@googlemail.com> > --- > package/bluez_utils/bluez_utils.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to master, thanks. Thomas
Hello, On Sat, 13 May 2017 22:28:45 +0200, Yann E. MORIN wrote: > On 2017-05-13 19:10 +0200, Romain Naour spake thusly: > > Tests are enabled since this has been introduced [1], so keep > > them for now. > > Why don't you want to simply disable tests altogehter, especially since > there is an option for that: > > --disable-test > > And if we disable tests, then we do not need patch 3/3. In bluez_utils, "tests" apparently a good number of tools that are not really tests, and might be needed on the target. I'll let Yegor answer on this though, but in the mean time, I believe it's better to fix things rather than changing the set of available tools on the target, which is why I've applied Romain's patch. Thomas
On Sun, May 14, 2017 at 4:05 PM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Hello, > > On Sat, 13 May 2017 22:28:45 +0200, Yann E. MORIN wrote: > >> On 2017-05-13 19:10 +0200, Romain Naour spake thusly: >> > Tests are enabled since this has been introduced [1], so keep >> > them for now. >> >> Why don't you want to simply disable tests altogehter, especially since >> there is an option for that: >> >> --disable-test >> >> And if we disable tests, then we do not need patch 3/3. > > In bluez_utils, "tests" apparently a good number of tools that are not > really tests, and might be needed on the target. I'll let Yegor answer > on this though, but in the mean time, I believe it's better to fix > things rather than changing the set of available tools on the target, > which is why I've applied Romain's patch. I'll have to take a closer look at this. Haven't used bluez_utils for ages. Yegor
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes: > Hello, > On Sat, 13 May 2017 22:28:45 +0200, Yann E. MORIN wrote: >> On 2017-05-13 19:10 +0200, Romain Naour spake thusly: >> > Tests are enabled since this has been introduced [1], so keep >> > them for now. >> >> Why don't you want to simply disable tests altogehter, especially since >> there is an option for that: >> >> --disable-test >> >> And if we disable tests, then we do not need patch 3/3. > In bluez_utils, "tests" apparently a good number of tools that are not > really tests, and might be needed on the target. I'll let Yegor answer > on this though, but in the mean time, I believe it's better to fix > things rather than changing the set of available tools on the target, > which is why I've applied Romain's patch. :/ It looks to be a bit of a mess. The only thing that gets linked with libcheck (check is a library, not a program) is unit/test-eir, which doesn't even get installed. But oh well, it is indeed safer to keep it enabled.
>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes: > Tests are enabled since this has been introduced [1], so keep > them for now. > bluez_utils needs check tool and check if it's available [2]. > [1] 06c3e2159686a886e52b2522a47e60c300cfb7f7 > [2] https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/configure.ac?h=4.101#n51 > Signed-off-by: Romain Naour <romain.naour@gmail.com> > Cc: Yegor Yefremov <yegorslists@googlemail.com> Committed to 2017.02.x, thanks.
diff --git a/package/bluez_utils/bluez_utils.mk b/package/bluez_utils/bluez_utils.mk index 526804a..256f012 100644 --- a/package/bluez_utils/bluez_utils.mk +++ b/package/bluez_utils/bluez_utils.mk @@ -8,7 +8,7 @@ BLUEZ_UTILS_VERSION = 4.101 BLUEZ_UTILS_SOURCE = bluez-$(BLUEZ_UTILS_VERSION).tar.xz BLUEZ_UTILS_SITE = $(BR2_KERNEL_MIRROR)/linux/bluetooth BLUEZ_UTILS_INSTALL_STAGING = YES -BLUEZ_UTILS_DEPENDENCIES = host-pkgconf dbus libglib2 +BLUEZ_UTILS_DEPENDENCIES = host-pkgconf check dbus libglib2 BLUEZ_UTILS_CONF_OPTS = --enable-test --enable-tools BLUEZ_UTILS_AUTORECONF = YES BLUEZ_UTILS_LICENSE = GPL-2.0+, LGPL-2.1+
Tests are enabled since this has been introduced [1], so keep them for now. bluez_utils needs check tool and check if it's available [2]. [1] 06c3e2159686a886e52b2522a47e60c300cfb7f7 [2] https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/configure.ac?h=4.101#n51 Signed-off-by: Romain Naour <romain.naour@gmail.com> Cc: Yegor Yefremov <yegorslists@googlemail.com> --- package/bluez_utils/bluez_utils.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)