| Message ID | 6155891d19531be018d30fd55ffd6d42493af8c1.1494660546.git.jan.kiszka@siemens.com |
|---|---|
| State | New |
| Headers | show |
On Sat, May 13, 2017 at 9:28 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote: > This is the safe default for GPIOs with unknown external wiring. > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Greg, On 2017-05-13 09:28, Jan Kiszka wrote: > This is the safe default for GPIOs with unknown external wiring. > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> > --- > drivers/tty/serial/8250/8250_exar.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c > index 1270ff163f63..b4fa585156c7 100644 > --- a/drivers/tty/serial/8250/8250_exar.c > +++ b/drivers/tty/serial/8250/8250_exar.c > @@ -177,13 +177,13 @@ static void setup_gpio(u8 __iomem *p) > writeb(0x00, p + UART_EXAR_MPIOLVL_7_0); > writeb(0x00, p + UART_EXAR_MPIO3T_7_0); > writeb(0x00, p + UART_EXAR_MPIOINV_7_0); > - writeb(0x00, p + UART_EXAR_MPIOSEL_7_0); > + writeb(0xff, p + UART_EXAR_MPIOSEL_7_0); > writeb(0x00, p + UART_EXAR_MPIOOD_7_0); > writeb(0x00, p + UART_EXAR_MPIOINT_15_8); > writeb(0x00, p + UART_EXAR_MPIOLVL_15_8); > writeb(0x00, p + UART_EXAR_MPIO3T_15_8); > writeb(0x00, p + UART_EXAR_MPIOINV_15_8); > - writeb(0x00, p + UART_EXAR_MPIOSEL_15_8); > + writeb(0xff, p + UART_EXAR_MPIOSEL_15_8); > writeb(0x00, p + UART_EXAR_MPIOOD_15_8); > } > > Please drop from this tty-next, it may break Commtech adapters. I have an update ready. I may also send a fix on top if that is preferred, just let me know. Thanks, Jan
On Fri, May 26, 2017 at 4:04 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: > Greg, > Please drop from this tty-next, it may break Commtech adapters. I have > an update ready. > > I may also send a fix on top if that is preferred, just let me know. AFAIK what is in tty-next is left there, so, looks like latter is the option.
On Fri, May 26, 2017 at 03:04:26PM +0200, Jan Kiszka wrote: > Greg, > > On 2017-05-13 09:28, Jan Kiszka wrote: > > This is the safe default for GPIOs with unknown external wiring. > > > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> > > --- > > drivers/tty/serial/8250/8250_exar.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c > > index 1270ff163f63..b4fa585156c7 100644 > > --- a/drivers/tty/serial/8250/8250_exar.c > > +++ b/drivers/tty/serial/8250/8250_exar.c > > @@ -177,13 +177,13 @@ static void setup_gpio(u8 __iomem *p) > > writeb(0x00, p + UART_EXAR_MPIOLVL_7_0); > > writeb(0x00, p + UART_EXAR_MPIO3T_7_0); > > writeb(0x00, p + UART_EXAR_MPIOINV_7_0); > > - writeb(0x00, p + UART_EXAR_MPIOSEL_7_0); > > + writeb(0xff, p + UART_EXAR_MPIOSEL_7_0); > > writeb(0x00, p + UART_EXAR_MPIOOD_7_0); > > writeb(0x00, p + UART_EXAR_MPIOINT_15_8); > > writeb(0x00, p + UART_EXAR_MPIOLVL_15_8); > > writeb(0x00, p + UART_EXAR_MPIO3T_15_8); > > writeb(0x00, p + UART_EXAR_MPIOINV_15_8); > > - writeb(0x00, p + UART_EXAR_MPIOSEL_15_8); > > + writeb(0xff, p + UART_EXAR_MPIOSEL_15_8); > > writeb(0x00, p + UART_EXAR_MPIOOD_15_8); > > } > > > > > > Please drop from this tty-next, it may break Commtech adapters. I have > an update ready. > > I may also send a fix on top if that is preferred, just let me know. I need a fixup patch, I can't drop a patch, only revert it. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c index 1270ff163f63..b4fa585156c7 100644 --- a/drivers/tty/serial/8250/8250_exar.c +++ b/drivers/tty/serial/8250/8250_exar.c @@ -177,13 +177,13 @@ static void setup_gpio(u8 __iomem *p) writeb(0x00, p + UART_EXAR_MPIOLVL_7_0); writeb(0x00, p + UART_EXAR_MPIO3T_7_0); writeb(0x00, p + UART_EXAR_MPIOINV_7_0); - writeb(0x00, p + UART_EXAR_MPIOSEL_7_0); + writeb(0xff, p + UART_EXAR_MPIOSEL_7_0); writeb(0x00, p + UART_EXAR_MPIOOD_7_0); writeb(0x00, p + UART_EXAR_MPIOINT_15_8); writeb(0x00, p + UART_EXAR_MPIOLVL_15_8); writeb(0x00, p + UART_EXAR_MPIO3T_15_8); writeb(0x00, p + UART_EXAR_MPIOINV_15_8); - writeb(0x00, p + UART_EXAR_MPIOSEL_15_8); + writeb(0xff, p + UART_EXAR_MPIOSEL_15_8); writeb(0x00, p + UART_EXAR_MPIOOD_15_8); }
This is the safe default for GPIOs with unknown external wiring. Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> --- drivers/tty/serial/8250/8250_exar.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)