diff mbox

maintainers: Add myself as a NetBSD reviewer

Message ID 20170513022143.2838-1-n54@gmx.com
State New
Headers show

Commit Message

Kamil Rytarowski May 13, 2017, 2:21 a.m. UTC
I volunteer to review NetBSD patches.
Adding myself will help to not miss some of them.

Restore NetBSD as a maintained host.

All patches to make qemu/pkgsrc building have been emitted to review.

Signed-off-by: Kamil Rytarowski <n54@gmx.com>
---
 MAINTAINERS | 6 ++++++
 configure   | 1 +
 2 files changed, 7 insertions(+)

Comments

Stefan Hajnoczi May 15, 2017, 2:13 p.m. UTC | #1
On Sat, May 13, 2017 at 04:21:43AM +0200, Kamil Rytarowski wrote:
> I volunteer to review NetBSD patches.
> Adding myself will help to not miss some of them.
> 
> Restore NetBSD as a maintained host.
> 
> All patches to make qemu/pkgsrc building have been emitted to review.
> 
> Signed-off-by: Kamil Rytarowski <n54@gmx.com>
> ---
>  MAINTAINERS | 6 ++++++
>  configure   | 1 +
>  2 files changed, 7 insertions(+)

Will you maintain a patch queue (git repo) so you can send pull
requests?  If yes, please add a T: field.

Thanks,
Stefan
Kamil Rytarowski May 15, 2017, 2:22 p.m. UTC | #2
On 15.05.2017 16:13, Stefan Hajnoczi wrote:
> On Sat, May 13, 2017 at 04:21:43AM +0200, Kamil Rytarowski wrote:
>> I volunteer to review NetBSD patches.
>> Adding myself will help to not miss some of them.
>>
>> Restore NetBSD as a maintained host.
>>
>> All patches to make qemu/pkgsrc building have been emitted to review.
>>
>> Signed-off-by: Kamil Rytarowski <n54@gmx.com>
>> ---
>>  MAINTAINERS | 6 ++++++
>>  configure   | 1 +
>>  2 files changed, 7 insertions(+)
> 
> Will you maintain a patch queue (git repo) so you can send pull
> requests?  If yes, please add a T: field.
> 

I don't think that there is a need for an additional patch queue, at
least in the maintained mode as a volunteer in spare time.

If there would be more BSD people, we could share a dedicated queue of
patches.

> Thanks,
> Stefan
>
Paolo Bonzini May 15, 2017, 2:43 p.m. UTC | #3
On 15/05/2017 16:22, Kamil Rytarowski wrote:
> On 15.05.2017 16:13, Stefan Hajnoczi wrote:
>> On Sat, May 13, 2017 at 04:21:43AM +0200, Kamil Rytarowski wrote:
>>> I volunteer to review NetBSD patches.
>>> Adding myself will help to not miss some of them.
>>>
>>> Restore NetBSD as a maintained host.
>>>
>>> All patches to make qemu/pkgsrc building have been emitted to review.
>>>
>>> Signed-off-by: Kamil Rytarowski <n54@gmx.com>
>>> ---
>>>  MAINTAINERS | 6 ++++++
>>>  configure   | 1 +
>>>  2 files changed, 7 insertions(+)
>>
>> Will you maintain a patch queue (git repo) so you can send pull
>> requests?  If yes, please add a T: field.
>>
> 
> I don't think that there is a need for an additional patch queue, at
> least in the maintained mode as a volunteer in spare time.
> 
> If there would be more BSD people, we could share a dedicated queue of
> patches.

How would patches be sent to the committer then?

Thanks,

Paolo
Stefan Hajnoczi May 16, 2017, 2:32 p.m. UTC | #4
On Mon, May 15, 2017 at 04:43:41PM +0200, Paolo Bonzini wrote:
> 
> 
> On 15/05/2017 16:22, Kamil Rytarowski wrote:
> > On 15.05.2017 16:13, Stefan Hajnoczi wrote:
> >> On Sat, May 13, 2017 at 04:21:43AM +0200, Kamil Rytarowski wrote:
> >>> I volunteer to review NetBSD patches.
> >>> Adding myself will help to not miss some of them.
> >>>
> >>> Restore NetBSD as a maintained host.
> >>>
> >>> All patches to make qemu/pkgsrc building have been emitted to review.
> >>>
> >>> Signed-off-by: Kamil Rytarowski <n54@gmx.com>
> >>> ---
> >>>  MAINTAINERS | 6 ++++++
> >>>  configure   | 1 +
> >>>  2 files changed, 7 insertions(+)
> >>
> >> Will you maintain a patch queue (git repo) so you can send pull
> >> requests?  If yes, please add a T: field.
> >>
> > 
> > I don't think that there is a need for an additional patch queue, at
> > least in the maintained mode as a volunteer in spare time.
> > 
> > If there would be more BSD people, we could share a dedicated queue of
> > patches.
> 
> How would patches be sent to the committer then?

After discussing on IRC it seems likely that NetBSD patches will go via
subsystem maintainers.  Therefore Kamil does not plan to send pull
requests directly.

Stefan
Stefan Hajnoczi May 16, 2017, 2:35 p.m. UTC | #5
On Sat, May 13, 2017 at 04:21:43AM +0200, Kamil Rytarowski wrote:
> I volunteer to review NetBSD patches.
> Adding myself will help to not miss some of them.
> 
> Restore NetBSD as a maintained host.
> 
> All patches to make qemu/pkgsrc building have been emitted to review.
> 
> Signed-off-by: Kamil Rytarowski <n54@gmx.com>
> ---
>  MAINTAINERS | 6 ++++++
>  configure   | 1 +
>  2 files changed, 7 insertions(+)

Thanks, applied to my staging tree:
https://github.com/stefanha/qemu/commits/staging

Stefan
diff mbox

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 0e8d731ebf..c4eff13ce2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -354,6 +354,12 @@  L: qemu-devel@nongnu.org
 S: Maintained
 F: *posix*
 
+NETBSD
+L: qemu-devel@nongnu.org
+M: Kamil Rytarowski <kamil@netbsd.org>
+S: Maintained
+K: (?i)NetBSD
+
 W32, W64
 L: qemu-devel@nongnu.org
 M: Stefan Weil <sw@weilnetz.de>
diff --git a/configure b/configure
index 7c020c076b..0b3e014c93 100755
--- a/configure
+++ b/configure
@@ -611,6 +611,7 @@  NetBSD)
   audio_possible_drivers="oss sdl"
   oss_lib="-lossaudio"
   HOST_VARIANT_DIR="netbsd"
+  supported_os="yes"
 ;;
 OpenBSD)
   bsd="yes"