| Message ID | 20170512183810.26185-4-anthony.l.nguyen@intel.com |
|---|---|
| State | Accepted |
| Delegated to: | Jeff Kirsher |
| Headers | show |
> -----Original Message----- > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On > Behalf Of Tony Nguyen > Sent: Friday, May 12, 2017 11:38 AM > To: intel-wired-lan@lists.osuosl.org > Subject: [Intel-wired-lan] [PATCH 4/4] ixgbevf: Resolve warnings for - > Wimplicit-fallthrough > > Additions to gcc 7 now warn whenever a switch statement falls through > implicitly. This patch adds explicit fall through comments to address the > following warnings: > > drivers/net/ethernet/intel/ixgbevf/vf.c: In function > ‘ixgbevf_get_reta_locked’: > drivers/net/ethernet/intel/ixgbevf/vf.c:336:6: warning: this statement may > fall through [-Wimplicit-fallthrough=] > if (hw->mac.type < ixgbe_mac_X550_vf) > ^ > drivers/net/ethernet/intel/ixgbevf/vf.c:338:2: note: here > default: > ^~~~~~~ > drivers/net/ethernet/intel/ixgbevf/vf.c: In function > ‘ixgbevf_get_rss_key_locked’: > drivers/net/ethernet/intel/ixgbevf/vf.c:402:6: warning: this statement may > fall through [-Wimplicit-fallthrough=] > if (hw->mac.type < ixgbe_mac_X550_vf) > ^ > drivers/net/ethernet/intel/ixgbevf/vf.c:404:2: note: here > default: > ^~~~~~~ > > Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com> > --- > drivers/net/ethernet/intel/ixgbevf/vf.c | 2 ++ > 1 file changed, 2 insertions(+) Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
diff --git a/drivers/net/ethernet/intel/ixgbevf/vf.c b/drivers/net/ethernet/intel/ixgbevf/vf.c index b6d0c01..0c25006 100644 --- a/drivers/net/ethernet/intel/ixgbevf/vf.c +++ b/drivers/net/ethernet/intel/ixgbevf/vf.c @@ -335,6 +335,7 @@ int ixgbevf_get_reta_locked(struct ixgbe_hw *hw, u32 *reta, int num_rx_queues) case ixgbe_mbox_api_12: if (hw->mac.type < ixgbe_mac_X550_vf) break; + /* fall through */ default: return -EOPNOTSUPP; } @@ -401,6 +402,7 @@ int ixgbevf_get_rss_key_locked(struct ixgbe_hw *hw, u8 *rss_key) case ixgbe_mbox_api_12: if (hw->mac.type < ixgbe_mac_X550_vf) break; + /* fall through */ default: return -EOPNOTSUPP; }
Additions to gcc 7 now warn whenever a switch statement falls through implicitly. This patch adds explicit fall through comments to address the following warnings: drivers/net/ethernet/intel/ixgbevf/vf.c: In function ‘ixgbevf_get_reta_locked’: drivers/net/ethernet/intel/ixgbevf/vf.c:336:6: warning: this statement may fall through [-Wimplicit-fallthrough=] if (hw->mac.type < ixgbe_mac_X550_vf) ^ drivers/net/ethernet/intel/ixgbevf/vf.c:338:2: note: here default: ^~~~~~~ drivers/net/ethernet/intel/ixgbevf/vf.c: In function ‘ixgbevf_get_rss_key_locked’: drivers/net/ethernet/intel/ixgbevf/vf.c:402:6: warning: this statement may fall through [-Wimplicit-fallthrough=] if (hw->mac.type < ixgbe_mac_X550_vf) ^ drivers/net/ethernet/intel/ixgbevf/vf.c:404:2: note: here default: ^~~~~~~ Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com> --- drivers/net/ethernet/intel/ixgbevf/vf.c | 2 ++ 1 file changed, 2 insertions(+)