Patchwork I2C: Add support for 64bit system.

login
register
mail settings
Submitter Xulei
Date Dec. 20, 2010, 7:37 a.m.
Message ID <1292830654-7056-1-git-send-email-B33228@freescale.com>
Download mbox | patch
Permalink /patch/76175/
State Superseded
Delegated to: Kumar Gala
Headers show

Comments

Xulei - Dec. 20, 2010, 7:37 a.m.
Currently I2C_MPC supports 32bit system only, then this
modification makes it support 32bit and 64bit system both.

Signed-off-by: Xulei <B33228@freescale.com>
---
 drivers/i2c/busses/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Ben Dooks - Dec. 20, 2010, 2:59 p.m.
On Mon, Dec 20, 2010 at 03:37:34PM +0800, Xulei wrote:
> Currently I2C_MPC supports 32bit system only, then this
> modification makes it support 32bit and 64bit system both.
> 
> Signed-off-by: Xulei <B33228@freescale.com>

This been build or run tested?

> ---
>  drivers/i2c/busses/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 9c6170c..3392f4b 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -422,7 +422,7 @@ config I2C_IXP2000
>  
>  config I2C_MPC
>  	tristate "MPC107/824x/85xx/512x/52xx/83xx/86xx"
> -	depends on PPC32
> +	depends on PPC32 || PPC64
>  	help
>  	  If you say yes to this option, support will be included for the
>  	  built-in I2C interface on the MPC107, Tsi107, MPC512x, MPC52xx,
> -- 
> 1.7.0.4
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Xulei - Dec. 21, 2010, 7:32 a.m.
yes, it has been built and could access the RTC well.

On δΈ€, 2010-12-20 at 14:59 +0000, Ben Dooks wrote:
> On Mon, Dec 20, 2010 at 03:37:34PM +0800, Xulei wrote:
> > Currently I2C_MPC supports 32bit system only, then this
> > modification makes it support 32bit and 64bit system both.
> > 
> > Signed-off-by: Xulei <B33228@freescale.com>
> 
> This been build or run tested?
> 
> > ---
> >  drivers/i2c/busses/Kconfig |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> > index 9c6170c..3392f4b 100644
> > --- a/drivers/i2c/busses/Kconfig
> > +++ b/drivers/i2c/busses/Kconfig
> > @@ -422,7 +422,7 @@ config I2C_IXP2000
> >  
> >  config I2C_MPC
> >  	tristate "MPC107/824x/85xx/512x/52xx/83xx/86xx"
> > -	depends on PPC32
> > +	depends on PPC32 || PPC64
> >  	help
> >  	  If you say yes to this option, support will be included for the
> >  	  built-in I2C interface on the MPC107, Tsi107, MPC512x, MPC52xx,
> > -- 
> > 1.7.0.4
> > 
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
Kumar Gala - March 15, 2011, 3:44 p.m.
On Dec 20, 2010, at 8:59 AM, Ben Dooks wrote:

> On Mon, Dec 20, 2010 at 03:37:34PM +0800, Xulei wrote:
>> Currently I2C_MPC supports 32bit system only, then this
>> modification makes it support 32bit and 64bit system both.
>> 
>> Signed-off-by: Xulei <B33228@freescale.com>
> 
> This been build or run tested?

Yes, Any issues with me applying this via the powerpc.git tree?

> 
>> ---
>> drivers/i2c/busses/Kconfig |    2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>> 
>> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
>> index 9c6170c..3392f4b 100644
>> --- a/drivers/i2c/busses/Kconfig
>> +++ b/drivers/i2c/busses/Kconfig
>> @@ -422,7 +422,7 @@ config I2C_IXP2000
>> 
>> config I2C_MPC
>> 	tristate "MPC107/824x/85xx/512x/52xx/83xx/86xx"
>> -	depends on PPC32
>> +	depends on PPC32 || PPC64
>> 	help
>> 	  If you say yes to this option, support will be included for the
>> 	  built-in I2C interface on the MPC107, Tsi107, MPC512x, MPC52xx,
>> -- 
>> 1.7.0.4
>> 
>> 
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> -- 
> Ben Dooks, ben@fluff.org, http://www.fluff.org/ben/
> 
> Large Hadron Colada: A large Pina Colada that makes the universe disappear.
> 
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
Timur Tabi - March 15, 2011, 3:56 p.m.
On Tue, Mar 15, 2011 at 10:44 AM, Kumar Gala <galak@kernel.crashing.org> wrote:
>
> On Dec 20, 2010, at 8:59 AM, Ben Dooks wrote:
>
>> On Mon, Dec 20, 2010 at 03:37:34PM +0800, Xulei wrote:
>>> Currently I2C_MPC supports 32bit system only, then this
>>> modification makes it support 32bit and 64bit system both.
>>>
>>> Signed-off-by: Xulei <B33228@freescale.com>
>>
>> This been build or run tested?
>
> Yes, Any issues with me applying this via the powerpc.git tree?

I'm concerned about the fact that we have to have two defines to
declare code that is 32-bit and 64-bit clean.  Technically speaking,
all drivers should work in both environments.  It seems silly to have
"PPC32 || PPC64" for everything.  Isn't there a generic "PPC" config
option that covers this?
Kumar Gala - March 15, 2011, 4 p.m.
On Mar 15, 2011, at 10:56 AM, Timur Tabi wrote:

> On Tue, Mar 15, 2011 at 10:44 AM, Kumar Gala <galak@kernel.crashing.org> wrote:
>> 
>> On Dec 20, 2010, at 8:59 AM, Ben Dooks wrote:
>> 
>>> On Mon, Dec 20, 2010 at 03:37:34PM +0800, Xulei wrote:
>>>> Currently I2C_MPC supports 32bit system only, then this
>>>> modification makes it support 32bit and 64bit system both.
>>>> 
>>>> Signed-off-by: Xulei <B33228@freescale.com>
>>> 
>>> This been build or run tested?
>> 
>> Yes, Any issues with me applying this via the powerpc.git tree?
> 
> I'm concerned about the fact that we have to have two defines to
> declare code that is 32-bit and 64-bit clean.  Technically speaking,
> all drivers should work in both environments.  It seems silly to have
> "PPC32 || PPC64" for everything.  Isn't there a generic "PPC" config
> option that covers this?

There is, I'll post a new patch that uses it.

- k

Patch

diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 9c6170c..3392f4b 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -422,7 +422,7 @@  config I2C_IXP2000
 
 config I2C_MPC
 	tristate "MPC107/824x/85xx/512x/52xx/83xx/86xx"
-	depends on PPC32
+	depends on PPC32 || PPC64
 	help
 	  If you say yes to this option, support will be included for the
 	  built-in I2C interface on the MPC107, Tsi107, MPC512x, MPC52xx,