Patchwork sparc32: ledma extra registers need tracing too

login
register
mail settings
Submitter Bob Breuer
Date Dec. 19, 2010, 8 p.m.
Message ID <4D0E6448.7070006@mc.net>
Download mbox | patch
Permalink /patch/76154/
State New
Headers show

Comments

Bob Breuer - Dec. 19, 2010, 8 p.m.
Also trace the extra registers, and call them undocumented instead.

Signed-off-by: Bob Breuer <breuerr@mc.net>

Patch

diff --git a/hw/sparc32_dma.c b/hw/sparc32_dma.c
index 56be8c8..0325a55 100644
--- a/hw/sparc32_dma.c
+++ b/hw/sparc32_dma.c
@@ -170,7 +170,9 @@  static uint32_t dma_mem_readl(void *opaque, target_phys_addr_t addr)
     uint32_t saddr;
 
     if (s->is_ledma && (addr > DMA_MAX_REG_OFFSET)) {
-        return 0; /* extra mystery register(s) */
+        /* extra undocumented register(s) */
+        trace_sparc32_dma_mem_readl(addr, 0);
+        return 0;
     }
     saddr = (addr & DMA_MASK) >> 2;
     trace_sparc32_dma_mem_readl(addr, s->dmaregs[saddr]);
@@ -183,7 +185,9 @@  static void dma_mem_writel(void *opaque, target_phys_addr_t addr, uint32_t val)
     uint32_t saddr;
 
     if (s->is_ledma && (addr > DMA_MAX_REG_OFFSET)) {
-        return; /* extra mystery register(s) */
+        /* extra undocumented register(s) */
+        trace_sparc32_dma_mem_writel(addr, 0, val);
+        return;
     }
     saddr = (addr & DMA_MASK) >> 2;
     trace_sparc32_dma_mem_writel(addr, s->dmaregs[saddr], val);