Patchwork [v4,3/3] target-i386: Fix accidental use of SoftFloat uint64 type

login
register
mail settings
Submitter Andreas Färber
Date Dec. 19, 2010, 4:22 p.m.
Message ID <1292775761-6061-4-git-send-email-andreas.faerber@web.de>
Download mbox | patch
Permalink /patch/76143/
State New
Headers show

Comments

Andreas Färber - Dec. 19, 2010, 4:22 p.m.
softfloat.h's uint64 type has least-width semantics.
Use uint64_t instead since that is used in helpers.

v4:
* Summary change.

v3:
* Split off.

Cc: Huang Ying <ying.huang@intel.com>
Signed-off-by: Andreas Färber <andreas.faerber@web.de>
Acked-by: Juan Quintela <quintela@redhat.com>
---
 target-i386/cpu.h |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
Andreas Färber - Dec. 20, 2010, 6:42 a.m.
Am 19.12.2010 um 17:22 schrieb Andreas Färber:

> softfloat.h's uint64 type has least-width semantics.
> Use uint64_t instead since that is used in helpers.
>
> v4:
> * Summary change.
>
> v3:
> * Split off.
>
> Cc: Huang Ying <ying.huang@intel.com>
> Signed-off-by: Andreas Färber <andreas.faerber@web.de>
> Acked-by: Juan Quintela <quintela@redhat.com>

Updated on branch with Cc -> Acked-by.

> ---
> target-i386/cpu.h |    8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/target-i386/cpu.h b/target-i386/cpu.h
> index 06e40f3..f0c07cd 100644
> --- a/target-i386/cpu.h
> +++ b/target-i386/cpu.h
> @@ -737,10 +737,10 @@ typedef struct CPUX86State {
>       user */
>    struct DeviceState *apic_state;
>
> -    uint64 mcg_cap;
> -    uint64 mcg_status;
> -    uint64 mcg_ctl;
> -    uint64 mce_banks[MCE_BANKS_DEF*4];
> +    uint64_t mcg_cap;
> +    uint64_t mcg_status;
> +    uint64_t mcg_ctl;
> +    uint64_t mce_banks[MCE_BANKS_DEF*4];
>
>    uint64_t tsc_aux;
>
> -- 
> 1.7.3.4
>
>

Patch

diff --git a/target-i386/cpu.h b/target-i386/cpu.h
index 06e40f3..f0c07cd 100644
--- a/target-i386/cpu.h
+++ b/target-i386/cpu.h
@@ -737,10 +737,10 @@  typedef struct CPUX86State {
        user */
     struct DeviceState *apic_state;
 
-    uint64 mcg_cap;
-    uint64 mcg_status;
-    uint64 mcg_ctl;
-    uint64 mce_banks[MCE_BANKS_DEF*4];
+    uint64_t mcg_cap;
+    uint64_t mcg_status;
+    uint64_t mcg_ctl;
+    uint64_t mce_banks[MCE_BANKS_DEF*4];
 
     uint64_t tsc_aux;