diff mbox

[3/3] net/filter-rewriter: Remove unused option in filter-rewirter

Message ID 1494552955-30529-4-git-send-email-zhangchen.fnst@cn.fujitsu.com
State New
Headers show

Commit Message

Zhang Chen May 12, 2017, 1:35 a.m. UTC
Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
---
 qemu-options.hx | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Eric Blake May 12, 2017, 5:43 p.m. UTC | #1
On 05/11/2017 08:35 PM, Zhang Chen wrote:
> Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>

In the subject: s/rewirter/rewriter/

> ---
>  qemu-options.hx | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 70c0ded..f5e088e 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -4038,7 +4038,8 @@ Create a filter-redirector we need to differ outdev id from indev id, id can not
>  be the same. we can just use indev or outdev, but at least one of indev or outdev
>  need to be specified.
>  
> -@item -object filter-rewriter,id=@var{id},netdev=@var{netdevid},rewriter-mode=@var{mode}[,queue=@var{all|rx|tx}]
> +@item -object filter-rewriter,id=@var{id},netdev=@var{netdevid},
> +[,queue=@var{all|rx|tx}]

Texinfo sources have restrictions on how line-wrapping works, and it's
not always consistent.  It's probably best to stick with the long line,
if you haven't actually validated that the rendered documentation is not
broken when you split the line.
Zhang Chen May 15, 2017, 5:32 a.m. UTC | #2
On 05/13/2017 01:43 AM, Eric Blake wrote:
> On 05/11/2017 08:35 PM, Zhang Chen wrote:
>> Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
> In the subject: s/rewirter/rewriter/

OK.

>> ---
>>   qemu-options.hx | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/qemu-options.hx b/qemu-options.hx
>> index 70c0ded..f5e088e 100644
>> --- a/qemu-options.hx
>> +++ b/qemu-options.hx
>> @@ -4038,7 +4038,8 @@ Create a filter-redirector we need to differ outdev id from indev id, id can not
>>   be the same. we can just use indev or outdev, but at least one of indev or outdev
>>   need to be specified.
>>   
>> -@item -object filter-rewriter,id=@var{id},netdev=@var{netdevid},rewriter-mode=@var{mode}[,queue=@var{all|rx|tx}]
>> +@item -object filter-rewriter,id=@var{id},netdev=@var{netdevid},
>> +[,queue=@var{all|rx|tx}]
> Texinfo sources have restrictions on how line-wrapping works, and it's
> not always consistent.  It's probably best to stick with the long line,
> if you haven't actually validated that the rendered documentation is not
> broken when you split the line.

OK, I will change it to a long line.

Thanks
Zhang Chen
diff mbox

Patch

diff --git a/qemu-options.hx b/qemu-options.hx
index 70c0ded..f5e088e 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -4038,7 +4038,8 @@  Create a filter-redirector we need to differ outdev id from indev id, id can not
 be the same. we can just use indev or outdev, but at least one of indev or outdev
 need to be specified.
 
-@item -object filter-rewriter,id=@var{id},netdev=@var{netdevid},rewriter-mode=@var{mode}[,queue=@var{all|rx|tx}]
+@item -object filter-rewriter,id=@var{id},netdev=@var{netdevid},
+[,queue=@var{all|rx|tx}]
 
 Filter-rewriter is a part of COLO project.It will rewrite tcp packet to
 secondary from primary to keep secondary tcp connection,and rewrite