| Message ID | ydd7f1nhuh5.fsf@CeBiTec.Uni-Bielefeld.DE |
|---|---|
| State | New |
| Headers | show |
On 12 May 2017 00:57:58 CEST, Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> wrote: >Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> writes: > >> On 11 May 2017 15:10:36 CEST, Nathan Sidwell <nathan@acm.org> wrote: >>>On 05/11/2017 08:28 AM, Rainer Orth wrote: >>> >>>> On the gcc-7 branch, the dump file (from -fdump-class-hierarchy) >was >>>> called covariant7.C.002t.class, now it's covariant7.C.002l.class. >>>But >>>> gcc/testsuite/lib/scantree.exp (scan-tree-dump) expects the >>>NNNt.<dump> >>>> form. >>> >>>fixed thusly, applied as obvious. >>> >>>the scan$foo.exp files look like they could benefit from a >higher-level >>> >>>scandump.exp interface, but that's a cleanup for another day. >> >> Yea and once we can require a recent dejagnu (maybe for gcc-8 >finally) we >> can apply the removal of the load_lib TCL hackery. I meant handling the "l" class of dumps along the lines of t, i, r of existing dump files. >However, the introduction of scanlang.exp broke libatomic, libgomp, and >libitm testing. Their logfiles show Indeed I remember. I don't remember offhand if the search_dirs fix up in dejagnu allowed to reduce this mess but I think it did. Oh well.
On 05/11/2017 06:57 PM, Rainer Orth wrote: er, the introduction of scanlang.exp broke libatomic, libgomp, and > libitm testing. Their logfiles show > > trunk/12-gcc/build/sparc-sun-solaris2.12/libatomic/testsuite/libatomic.log:ERROR: Couldn't find library file scanlang.exp. > trunk/12-gcc/build/sparc-sun-solaris2.12/libgomp/testsuite/libgomp.log:ERROR: Couldn't find library file scanlang.exp. > trunk/12-gcc/build/sparc-sun-solaris2.12/libitm/testsuite/libitm.log:ERROR: Couldn't find library file scanlang.exp. > > and the testsuites aren't run. The following patch fixes this (manually > tested on libatomic and libitm so far). Thanks Rainer!
Hi Nathan, > On 05/11/2017 06:57 PM, Rainer Orth wrote: > er, the introduction of scanlang.exp broke libatomic, libgomp, and >> libitm testing. Their logfiles show >> >> trunk/12-gcc/build/sparc-sun-solaris2.12/libatomic/testsuite/libatomic.log:ERROR: >> Couldn't find library file scanlang.exp. >> trunk/12-gcc/build/sparc-sun-solaris2.12/libgomp/testsuite/libgomp.log:ERROR: >> Couldn't find library file scanlang.exp. >> trunk/12-gcc/build/sparc-sun-solaris2.12/libitm/testsuite/libitm.log:ERROR: >> Couldn't find library file scanlang.exp. >> >> and the testsuites aren't run. The following patch fixes this (manually >> tested on libatomic and libitm so far). > > Thanks Rainer! I've now installed the patch with the following ChangeLog entry after libgomp testing finished: 2017-05-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> libitm: * testsuite/lib/libitm.exp: Load scanlang.exp. libgomp: * testsuite/lib/libgomp.exp: Load scanlang.exp. libatomic: * testsuite/lib/libatomic.exp: Load scanlang.exp. Rainer
On 12 May 2017 01:10:19 CEST, Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> wrote: >On 12 May 2017 00:57:58 CEST, Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> >wrote: >>Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> writes: >> >>> On 11 May 2017 15:10:36 CEST, Nathan Sidwell <nathan@acm.org> wrote: >>>>On 05/11/2017 08:28 AM, Rainer Orth wrote: >>>> >>>>> On the gcc-7 branch, the dump file (from -fdump-class-hierarchy) >>was >>>>> called covariant7.C.002t.class, now it's covariant7.C.002l.class. >>>>But >>>>> gcc/testsuite/lib/scantree.exp (scan-tree-dump) expects the >>>>NNNt.<dump> >>>>> form. >>>> >>>>fixed thusly, applied as obvious. >>>> >>>>the scan$foo.exp files look like they could benefit from a >>higher-level >>>> >>>>scandump.exp interface, but that's a cleanup for another day. >>> >>> Yea and once we can require a recent dejagnu (maybe for gcc-8 >>finally) we >>> can apply the removal of the load_lib TCL hackery. >>However, the introduction of scanlang.exp broke libatomic, libgomp, >and >>libitm testing. Their logfiles show > >Indeed I remember. I don't remember offhand if the search_dirs fix up >in dejagnu allowed to reduce this mess but I think it did. >Oh well. Specifically https://gcc.gnu.org/ml/fortran/2012-03/msg00094.html dejagnu-1.5.2 contains the libdirs tweak and was released 2015-01-30 Mike, can we please bump the required dejagnu version for GCC-8? Thanks
On 05/13/2017 03:58 AM, Bernhard Reutner-Fischer wrote: > Specifically > https://gcc.gnu.org/ml/fortran/2012-03/msg00094.html > > dejagnu-1.5.2 contains the libdirs tweak and was released 2015-01-30 > > Mike, can we please bump the required dejagnu version for GCC-8? > Thanks There's also the version of TCL. My recent attempt to use an 8.5 feature killed some build systems. install.texi doesn't seem to specify a minimum version, just '8.6 is bad, don't use it' nathan
On Sun, May 14, 2017 at 3:57 AM, Nathan Sidwell <nathan@acm.org> wrote: > On 05/13/2017 03:58 AM, Bernhard Reutner-Fischer wrote: > >> Specifically >> https://gcc.gnu.org/ml/fortran/2012-03/msg00094.html >> >> dejagnu-1.5.2 contains the libdirs tweak and was released 2015-01-30 >> >> Mike, can we please bump the required dejagnu version for GCC-8? >> Thanks > > > There's also the version of TCL. My recent attempt to use an 8.5 feature > killed some build systems. install.texi doesn't seem to specify a minimum > version, just '8.6 is bad, don't use it' SLES11 already has 8.5.5, so I'm fine specifying a minimal version of 8.5.x Richard. > nathan > > > -- > Nathan Sidwell
diff --git a/libatomic/testsuite/lib/libatomic.exp b/libatomic/testsuite/lib/libatomic.exp --- a/libatomic/testsuite/lib/libatomic.exp +++ b/libatomic/testsuite/lib/libatomic.exp @@ -34,6 +34,7 @@ load_gcc_lib target-utils.exp load_gcc_lib target-supports-dg.exp load_gcc_lib scanasm.exp load_gcc_lib scandump.exp +load_gcc_lib scanlang.exp load_gcc_lib scanrtl.exp load_gcc_lib scantree.exp load_gcc_lib scanipa.exp diff --git a/libgomp/testsuite/lib/libgomp.exp b/libgomp/testsuite/lib/libgomp.exp --- a/libgomp/testsuite/lib/libgomp.exp +++ b/libgomp/testsuite/lib/libgomp.exp @@ -26,6 +26,7 @@ load_gcc_lib file-format.exp load_gcc_lib target-supports-dg.exp load_gcc_lib scanasm.exp load_gcc_lib scandump.exp +load_gcc_lib scanlang.exp load_gcc_lib scanrtl.exp load_gcc_lib scantree.exp load_gcc_lib scanipa.exp diff --git a/libitm/testsuite/lib/libitm.exp b/libitm/testsuite/lib/libitm.exp --- a/libitm/testsuite/lib/libitm.exp +++ b/libitm/testsuite/lib/libitm.exp @@ -40,6 +40,7 @@ load_gcc_lib file-format.exp load_gcc_lib target-supports-dg.exp load_gcc_lib scanasm.exp load_gcc_lib scandump.exp +load_gcc_lib scanlang.exp load_gcc_lib scanrtl.exp load_gcc_lib scantree.exp load_gcc_lib scanipa.exp