Patchwork [ada] Typos all over the map.

login
register
mail settings
Submitter Ralf Wildenhues
Date Dec. 19, 2010, 2:05 p.m.
Message ID <20101219140512.GP7020@gmx.de>
Download mbox | patch
Permalink /patch/76129/
State New
Headers show

Comments

Ralf Wildenhues - Dec. 19, 2010, 2:05 p.m.
Hi Arnaud,

thanks for the super-fast review!

* Arnaud Charlet wrote on Sun, Dec 19, 2010 at 02:03:01PM CET:
> > This patch fixes a number of typos in gcc/ada/.  Most are in source code
> > comments, but there are also a bunch in the manual and one source code
> > identifiers.
> 
> The change in exp_cg.adb in improper, should be removed.

Argh.  I have changed it to this now:


> This change in exp_ch4.adb cannot be compiled:
> @@ -2434,7 +2434,7 @@ package body Exp_Ch4 is
>  
>        --  We can't just use the index type, or even its base type for this
>        --  purpose for two reasons. First it might be an enumeration type which
> -      --  is not suitable fo computations of any kind, and second it may simply
> +      --  is not suitable for computations of any kind, and second it may simpl
> y
> 
> Since it will exceed the maximum line length.
> 
> Other changes are OK, assuming they pass a bootstrap and regtest successfully
> (I assume your bootstrap failed with the above exp_ch4.adb change).

Yes it failed now.  I need to remember to not send email after stage 1
yet, as that only produces warnings.  Sorry about that, I rewrapped that
part now, and will of course wait until regstrap is finished before
committing.

Thanks,
Ralf

> > Fix typos in gcc/ada.
[...]
Arnaud Charlet - Dec. 19, 2010, 3:22 p.m.
> Argh.  I have changed it to this now:
> 
> diff --git a/gcc/ada/exp_cg.adb b/gcc/ada/exp_cg.adb
> index 995f421..4f96664 100644
> --- a/gcc/ada/exp_cg.adb
> +++ b/gcc/ada/exp_cg.adb
> @@ -354,7 +354,8 @@ package body Exp_CG is
>             or else Entity_Is_In_Main_Unit (Current_Scope)
>           then
>              --  Register a copy of the dispatching call node. Needed since
>              the
> -            --  node containing a dispatching call is rewriten by the expander.
> +            --  node containing a dispatching call is rewritten by the
> +            --  expander.

OK.

> Yes it failed now.  I need to remember to not send email after stage 1
> yet, as that only produces warnings.  Sorry about that, I rewrapped that
> part now, and will of course wait until regstrap is finished before
> committing.

Sounds good, thanks for the patch.

Arno

Patch

diff --git a/gcc/ada/exp_cg.adb b/gcc/ada/exp_cg.adb
index 995f421..4f96664 100644
--- a/gcc/ada/exp_cg.adb
+++ b/gcc/ada/exp_cg.adb
@@ -354,7 +354,8 @@  package body Exp_CG is
            or else Entity_Is_In_Main_Unit (Current_Scope)
          then
             --  Register a copy of the dispatching call node. Needed since the
-            --  node containing a dispatching call is rewriten by the expander.
+            --  node containing a dispatching call is rewritten by the
+            --  expander.
 
             declare
                Copy : constant Node_Id := New_Copy (N);